You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/12/03 13:37:24 UTC
[GitHub] [pulsar] Shoothzj opened a new pull request #13123: Fix log problem in ThreadRuntime, make it's member final
Shoothzj opened a new pull request #13123:
URL: https://github.com/apache/pulsar/pull/13123
### Modifications
- Fix a log not correct in ThreadRuntime
- Make some their fields final
### Documentation
Check the box below and label this PR (if you have committer privilege).
Need to update docs?
- [x] `no-need-doc`
simple optmize
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Shoothzj removed a comment on pull request #13123: Fix log problem in ThreadRuntime, make it's member final
Posted by GitBox <gi...@apache.org>.
Shoothzj removed a comment on pull request #13123:
URL: https://github.com/apache/pulsar/pull/13123#issuecomment-985994619
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Shoothzj commented on pull request #13123: Fix log problem in ThreadRuntime, make it's member final
Posted by GitBox <gi...@apache.org>.
Shoothzj commented on pull request #13123:
URL: https://github.com/apache/pulsar/pull/13123#issuecomment-986014041
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Shoothzj commented on pull request #13123: Fix log problem in ThreadRuntime, make it's member final
Posted by GitBox <gi...@apache.org>.
Shoothzj commented on pull request #13123:
URL: https://github.com/apache/pulsar/pull/13123#issuecomment-985945869
@codelipenghui @hangc0276 @315157973 @michaeljmarshall @lhotari PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Shoothzj removed a comment on pull request #13123: Fix log problem in ThreadRuntime, make it's member final
Posted by GitBox <gi...@apache.org>.
Shoothzj removed a comment on pull request #13123:
URL: https://github.com/apache/pulsar/pull/13123#issuecomment-986014041
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Shoothzj removed a comment on pull request #13123: Fix log problem in ThreadRuntime, make it's member final
Posted by GitBox <gi...@apache.org>.
Shoothzj removed a comment on pull request #13123:
URL: https://github.com/apache/pulsar/pull/13123#issuecomment-986143938
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Shoothzj commented on pull request #13123: Fix log problem in ThreadRuntime, make it's member final
Posted by GitBox <gi...@apache.org>.
Shoothzj commented on pull request #13123:
URL: https://github.com/apache/pulsar/pull/13123#issuecomment-985994619
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Shoothzj removed a comment on pull request #13123: Fix log problem in ThreadRuntime, make it's member final
Posted by GitBox <gi...@apache.org>.
Shoothzj removed a comment on pull request #13123:
URL: https://github.com/apache/pulsar/pull/13123#issuecomment-986005133
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Shoothzj removed a comment on pull request #13123: Fix log problem in ThreadRuntime, make it's member final
Posted by GitBox <gi...@apache.org>.
Shoothzj removed a comment on pull request #13123:
URL: https://github.com/apache/pulsar/pull/13123#issuecomment-986031145
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Shoothzj commented on pull request #13123: Fix log problem in ThreadRuntime, make it's member final
Posted by GitBox <gi...@apache.org>.
Shoothzj commented on pull request #13123:
URL: https://github.com/apache/pulsar/pull/13123#issuecomment-986143938
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Shoothzj removed a comment on pull request #13123: Fix log problem in ThreadRuntime, make it's member final
Posted by GitBox <gi...@apache.org>.
Shoothzj removed a comment on pull request #13123:
URL: https://github.com/apache/pulsar/pull/13123#issuecomment-986000850
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Shoothzj commented on pull request #13123: Fix log problem in ThreadRuntime, make it's member final
Posted by GitBox <gi...@apache.org>.
Shoothzj commented on pull request #13123:
URL: https://github.com/apache/pulsar/pull/13123#issuecomment-985945674
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] michaeljmarshall commented on a change in pull request #13123: Fix log problem in ThreadRuntime, make it's member final
Posted by GitBox <gi...@apache.org>.
michaeljmarshall commented on a change in pull request #13123:
URL: https://github.com/apache/pulsar/pull/13123#discussion_r762381767
##########
File path: pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/runtime/thread/ThreadRuntime.java
##########
@@ -149,7 +149,7 @@ private static ClassLoader loadJars(String jarFile,
} catch (FileNotFoundException e) {
// this is usually like
// java.io.FileNotFoundException: /tmp/pulsar-nar/xxx.jar-unpacked/xxxxx/META-INF/MANIFEST.MF'
- log.error("The file {} does not look like a .nar file", jarFile, e.toString());
+ log.error("The file {} does not look like a .nar file {}", jarFile, e.toString());
Review comment:
@eolivelli - was your intention in https://github.com/apache/pulsar/pull/12667 to avoid logging the error's stack trace? If not, we could also drop the `.toString()` to make this log line work.
```suggestion
log.error("The file {} does not look like a .nar file", jarFile, e);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui merged pull request #13123: Fix log problem in ThreadRuntime, make it's member final
Posted by GitBox <gi...@apache.org>.
codelipenghui merged pull request #13123:
URL: https://github.com/apache/pulsar/pull/13123
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Shoothzj commented on pull request #13123: Fix log problem in ThreadRuntime, make it's member final
Posted by GitBox <gi...@apache.org>.
Shoothzj commented on pull request #13123:
URL: https://github.com/apache/pulsar/pull/13123#issuecomment-986005133
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Shoothzj commented on pull request #13123: Fix log problem in ThreadRuntime, make it's member final
Posted by GitBox <gi...@apache.org>.
Shoothzj commented on pull request #13123:
URL: https://github.com/apache/pulsar/pull/13123#issuecomment-986031145
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Shoothzj commented on pull request #13123: Fix log problem in ThreadRuntime, make it's member final
Posted by GitBox <gi...@apache.org>.
Shoothzj commented on pull request #13123:
URL: https://github.com/apache/pulsar/pull/13123#issuecomment-985955937
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Shoothzj commented on pull request #13123: Fix log problem in ThreadRuntime, make it's member final
Posted by GitBox <gi...@apache.org>.
Shoothzj commented on pull request #13123:
URL: https://github.com/apache/pulsar/pull/13123#issuecomment-986156285
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Shoothzj removed a comment on pull request #13123: Fix log problem in ThreadRuntime, make it's member final
Posted by GitBox <gi...@apache.org>.
Shoothzj removed a comment on pull request #13123:
URL: https://github.com/apache/pulsar/pull/13123#issuecomment-985955937
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Shoothzj commented on pull request #13123: Fix log problem in ThreadRuntime, make it's member final
Posted by GitBox <gi...@apache.org>.
Shoothzj commented on pull request #13123:
URL: https://github.com/apache/pulsar/pull/13123#issuecomment-985978089
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Shoothzj removed a comment on pull request #13123: Fix log problem in ThreadRuntime, make it's member final
Posted by GitBox <gi...@apache.org>.
Shoothzj removed a comment on pull request #13123:
URL: https://github.com/apache/pulsar/pull/13123#issuecomment-985978089
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Shoothzj commented on pull request #13123: Fix log problem in ThreadRuntime, make it's member final
Posted by GitBox <gi...@apache.org>.
Shoothzj commented on pull request #13123:
URL: https://github.com/apache/pulsar/pull/13123#issuecomment-986000850
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org