You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2020/12/21 21:52:02 UTC

[GitHub] [lucene-solr] dsmiley commented on pull request #2159: SOLR-14923: Nested docs indexing performance.

dsmiley commented on pull request #2159:
URL: https://github.com/apache/lucene-solr/pull/2159#issuecomment-749216411


   CC @thomaswoeckinger @moshebla 
   
   Tests pass, precommit passes.
   
   @markrmiller FYI I observed that NestedShardedAtomicUpdateTest on your ref-impl branch commented out an assertion that I wound up fixing in this PR.  I converted that test to use SolrCloudTestCase which made it way easier to debug some elusive bugs.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org