[GitHub] [flink] wanglijie95 commented on a diff in pull request #21111: [FLINK-29664][runtime] Collect subpartition sizes of blocking result partitions

[GitBox <gi...@apache.org>]

wanglijie95 commented on code in PR #21111:
URL: https://github.com/apache/flink/pull/21111#discussion_r1005235773


##########
flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/DefaultExecutionGraphDeploymentTest.java:
##########
@@ -693,41 +664,28 @@ private ExecutionGraph createExecutionGraph(Configuration configuration) throws
                 .setJobGraph(jobGraph)
                 .setJobMasterConfig(configuration)
                 .setBlobWriter(blobWriter)
-                .build(EXECUTOR_RESOURCE.getExecutor());
+                .build(EXECUTOR_EXTENSION.getExecutor());
     }
 
-    private static final class ExecutionStageMatcher
-            extends TypeSafeMatcher<List<ExecutionAttemptID>> {
-        private final List<Collection<ExecutionAttemptID>> executionStages;
-
-        private ExecutionStageMatcher(List<Collection<ExecutionAttemptID>> executionStages) {
-            this.executionStages = executionStages;
-        }
-
-        @Override
-        protected boolean matchesSafely(List<ExecutionAttemptID> submissionOrder) {
-            final Iterator<ExecutionAttemptID> submissionIterator = submissionOrder.iterator();
+    private boolean isDeployedInTopologicalOrder(

Review Comment:
   Fixed



##########
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/metrics/ResultPartitionBytesCounter.java:
##########
@@ -0,0 +1,58 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.runtime.io.network.metrics;
+
+import org.apache.flink.metrics.Counter;
+import org.apache.flink.metrics.SimpleCounter;
+import org.apache.flink.runtime.executiongraph.ResultPartitionBytes;
+
+import java.util.ArrayList;
+import java.util.List;
+import java.util.stream.Collectors;
+
+/** This counter will count the data size of a partition. */
+public class ResultPartitionBytesCounter {
+
+    /** The data size of each subpartition. */
+    private final List<Counter> subpartitionBytes;
+
+    public ResultPartitionBytesCounter(int numSubpartitions) {
+        this.subpartitionBytes = new ArrayList<>();
+        for (int i = 0; i < numSubpartitions; ++i) {
+            subpartitionBytes.add(new SimpleCounter());
+        }
+    }
+
+    public void inc(int targetSubpartition, long bytes) {
+        subpartitionBytes.get(targetSubpartition).inc(bytes);
+    }
+
+    public void broadcastInc(long bytes) {
+        subpartitionBytes.forEach(counter -> counter.inc(bytes));
+    }
+
+    //    public List<Counter> getSubpartitionBytes() {

Review Comment:
   Fixed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org