You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2020/09/23 15:51:14 UTC
[GitHub] [fineract] fynmanoj opened a new pull request #1346: FINERACT-1151-fix
fynmanoj opened a new pull request #1346:
URL: https://github.com/apache/fineract/pull/1346
## Description
Describe the changes made and why they were made.
Ignore if these details are present on the associated [Apache Fineract JIRA ticket](https://github.com/apache/fineract/pull/1284).
## Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
- [ ] Write the commit message as per https://github.com/apache/fineract/#pull-requests
- [ ] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
- [ ] Create/update unit or integration tests for verifying the changes made.
- [ ] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
- [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/api-docs/apiLive.htm with details of any API changes
- [ ] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] fynmanoj commented on a change in pull request #1346: FINERACT-1151-fix
Posted by GitBox <gi...@apache.org>.
fynmanoj commented on a change in pull request #1346:
URL: https://github.com/apache/fineract/pull/1346#discussion_r494038663
##########
File path: fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/loanschedule/domain/LoanScheduleModelDisbursementPeriod.java
##########
@@ -138,4 +138,14 @@ public void setEMIFixedSpecificToInstallmentTrue() {
public boolean isEMIFixedSpecificToInstallment() {
return isEMIFixedSpecificToInstallment;
}
+
+ @Override
+ public BigDecimal rescheduleInterestPortion() {
+ return null;
Review comment:
There is one of the two implimentations of the interface "LoanScheduleModelPeriod" (Disbursement period and Repayment Period). These methods are not significant for Disbursement Period and needed only in Repayment Period, hence they are marked dummy.
##########
File path: fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/loanschedule/domain/LoanScheduleModelDisbursementPeriod.java
##########
@@ -138,4 +138,14 @@ public void setEMIFixedSpecificToInstallmentTrue() {
public boolean isEMIFixedSpecificToInstallment() {
return isEMIFixedSpecificToInstallment;
}
+
+ @Override
+ public BigDecimal rescheduleInterestPortion() {
+ return null;
+ }
+
+ @Override
+ public void setRescheduleInterestPortion(BigDecimal rescheduleInterestPortion) {
+ return;
Review comment:
There is one of the two implimentations of the interface "LoanScheduleModelPeriod" (Disbursement period and Repayment Period). These methods are not significant for Disbursement Period and needed only in Repayment Period, hence they are marked dummy.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] fynmanoj commented on a change in pull request #1346: FINERACT-1151-fix
Posted by GitBox <gi...@apache.org>.
fynmanoj commented on a change in pull request #1346:
URL: https://github.com/apache/fineract/pull/1346#discussion_r494036129
##########
File path: fineract-provider/src/main/resources/sql/migrations/core_db/V362__reschedule_interest_to_lrs.sql
##########
@@ -0,0 +1,22 @@
+--
+-- Licensed to the Apache Software Foundation (ASF) under one
+-- or more contributor license agreements. See the NOTICE file
+-- distributed with this work for additional information
+-- regarding copyright ownership. The ASF licenses this file
+-- to you under the Apache License, Version 2.0 (the
+-- "License"); you may not use this file except in compliance
+-- with the License. You may obtain a copy of the License at
+--
+-- http://www.apache.org/licenses/LICENSE-2.0
+--
+-- Unless required by applicable law or agreed to in writing,
+-- software distributed under the License is distributed on an
+-- "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+-- KIND, either express or implied. See the License for the
+-- specific language governing permissions and limitations
+-- under the License.
+--
+
+
+alter table m_loan_repayment_schedule
+ add column `reschedule_interest_portion` decimal(19,6) DEFAULT NULL after `accrual_interest_derived`;
Review comment:
The history table need not be altered, as the interest portion is carried from the current schedule to the new schedule.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] avikganguly01 merged pull request #1346: FINERACT-1151-fix
Posted by GitBox <gi...@apache.org>.
avikganguly01 merged pull request #1346:
URL: https://github.com/apache/fineract/pull/1346
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] avikganguly01 commented on a change in pull request #1346: FINERACT-1151-fix
Posted by GitBox <gi...@apache.org>.
avikganguly01 commented on a change in pull request #1346:
URL: https://github.com/apache/fineract/pull/1346#discussion_r494830541
##########
File path: fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/loanschedule/domain/LoanScheduleModelDisbursementPeriod.java
##########
@@ -138,4 +138,14 @@ public void setEMIFixedSpecificToInstallmentTrue() {
public boolean isEMIFixedSpecificToInstallment() {
return isEMIFixedSpecificToInstallment;
}
+
+ @Override
+ public BigDecimal rescheduleInterestPortion() {
+ return null;
Review comment:
@vorburger : We can move away from this abstraction and change all the usages in a subsequent PR if you feel it's appropriate. Merging it for now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] fynmanoj commented on a change in pull request #1346: FINERACT-1151-fix
Posted by GitBox <gi...@apache.org>.
fynmanoj commented on a change in pull request #1346:
URL: https://github.com/apache/fineract/pull/1346#discussion_r494036129
##########
File path: fineract-provider/src/main/resources/sql/migrations/core_db/V362__reschedule_interest_to_lrs.sql
##########
@@ -0,0 +1,22 @@
+--
+-- Licensed to the Apache Software Foundation (ASF) under one
+-- or more contributor license agreements. See the NOTICE file
+-- distributed with this work for additional information
+-- regarding copyright ownership. The ASF licenses this file
+-- to you under the Apache License, Version 2.0 (the
+-- "License"); you may not use this file except in compliance
+-- with the License. You may obtain a copy of the License at
+--
+-- http://www.apache.org/licenses/LICENSE-2.0
+--
+-- Unless required by applicable law or agreed to in writing,
+-- software distributed under the License is distributed on an
+-- "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+-- KIND, either express or implied. See the License for the
+-- specific language governing permissions and limitations
+-- under the License.
+--
+
+
+alter table m_loan_repayment_schedule
+ add column `reschedule_interest_portion` decimal(19,6) DEFAULT NULL after `accrual_interest_derived`;
Review comment:
The history table need not be altered, as the interest portion is carried from the current schedule to the new schedule.
##########
File path: fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/loanschedule/domain/LoanScheduleModelDisbursementPeriod.java
##########
@@ -138,4 +138,14 @@ public void setEMIFixedSpecificToInstallmentTrue() {
public boolean isEMIFixedSpecificToInstallment() {
return isEMIFixedSpecificToInstallment;
}
+
+ @Override
+ public BigDecimal rescheduleInterestPortion() {
+ return null;
Review comment:
There is one of the two implimentations of the interface "LoanScheduleModelPeriod" (Disbursement period and Repayment Period). These methods are not significant for Disbursement Period and needed only in Repayment Period, hence they are marked dummy.
##########
File path: fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/loanschedule/domain/LoanScheduleModelDisbursementPeriod.java
##########
@@ -138,4 +138,14 @@ public void setEMIFixedSpecificToInstallmentTrue() {
public boolean isEMIFixedSpecificToInstallment() {
return isEMIFixedSpecificToInstallment;
}
+
+ @Override
+ public BigDecimal rescheduleInterestPortion() {
+ return null;
+ }
+
+ @Override
+ public void setRescheduleInterestPortion(BigDecimal rescheduleInterestPortion) {
+ return;
Review comment:
There is one of the two implimentations of the interface "LoanScheduleModelPeriod" (Disbursement period and Repayment Period). These methods are not significant for Disbursement Period and needed only in Repayment Period, hence they are marked dummy.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] avikganguly01 merged pull request #1346: FINERACT-1151-fix
Posted by GitBox <gi...@apache.org>.
avikganguly01 merged pull request #1346:
URL: https://github.com/apache/fineract/pull/1346
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] avikganguly01 commented on a change in pull request #1346: FINERACT-1151-fix
Posted by GitBox <gi...@apache.org>.
avikganguly01 commented on a change in pull request #1346:
URL: https://github.com/apache/fineract/pull/1346#discussion_r494830541
##########
File path: fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/loanschedule/domain/LoanScheduleModelDisbursementPeriod.java
##########
@@ -138,4 +138,14 @@ public void setEMIFixedSpecificToInstallmentTrue() {
public boolean isEMIFixedSpecificToInstallment() {
return isEMIFixedSpecificToInstallment;
}
+
+ @Override
+ public BigDecimal rescheduleInterestPortion() {
+ return null;
Review comment:
@vorburger : We can move away from this abstraction and change all the usages in a subsequent PR if you feel it's appropriate. Merging it for now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vorburger commented on a change in pull request #1346: FINERACT-1151-fix
Posted by GitBox <gi...@apache.org>.
vorburger commented on a change in pull request #1346:
URL: https://github.com/apache/fineract/pull/1346#discussion_r493767142
##########
File path: fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/loanschedule/domain/LoanScheduleModelDisbursementPeriod.java
##########
@@ -138,4 +138,14 @@ public void setEMIFixedSpecificToInstallmentTrue() {
public boolean isEMIFixedSpecificToInstallment() {
return isEMIFixedSpecificToInstallment;
}
+
+ @Override
+ public BigDecimal rescheduleInterestPortion() {
+ return null;
Review comment:
This looks curious.. is this intentional? Why?
##########
File path: fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/loanschedule/domain/LoanScheduleModelDisbursementPeriod.java
##########
@@ -138,4 +138,14 @@ public void setEMIFixedSpecificToInstallmentTrue() {
public boolean isEMIFixedSpecificToInstallment() {
return isEMIFixedSpecificToInstallment;
}
+
+ @Override
+ public BigDecimal rescheduleInterestPortion() {
+ return null;
+ }
+
+ @Override
+ public void setRescheduleInterestPortion(BigDecimal rescheduleInterestPortion) {
+ return;
Review comment:
as above
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] avikganguly01 commented on a change in pull request #1346: FINERACT-1151-fix
Posted by GitBox <gi...@apache.org>.
avikganguly01 commented on a change in pull request #1346:
URL: https://github.com/apache/fineract/pull/1346#discussion_r493812323
##########
File path: fineract-provider/src/main/resources/sql/migrations/core_db/V362__reschedule_interest_to_lrs.sql
##########
@@ -0,0 +1,22 @@
+--
+-- Licensed to the Apache Software Foundation (ASF) under one
+-- or more contributor license agreements. See the NOTICE file
+-- distributed with this work for additional information
+-- regarding copyright ownership. The ASF licenses this file
+-- to you under the Apache License, Version 2.0 (the
+-- "License"); you may not use this file except in compliance
+-- with the License. You may obtain a copy of the License at
+--
+-- http://www.apache.org/licenses/LICENSE-2.0
+--
+-- Unless required by applicable law or agreed to in writing,
+-- software distributed under the License is distributed on an
+-- "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+-- KIND, either express or implied. See the License for the
+-- specific language governing permissions and limitations
+-- under the License.
+--
+
+
+alter table m_loan_repayment_schedule
+ add column `reschedule_interest_portion` decimal(19,6) DEFAULT NULL after `accrual_interest_derived`;
Review comment:
Where are the changes to schedule history table?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org