You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/12/28 07:18:44 UTC

[GitHub] [flink] wangyang0918 edited a comment on pull request #14281: FLINK-20359 Added Owner Reference to Job Manager in native kubernetes setup

wangyang0918 edited a comment on pull request #14281:
URL: https://github.com/apache/flink/pull/14281#issuecomment-751185846


   @blublinsky Generally, this PR could work. But I think we could make the implementation more gracefully.
   * We could introduce a new Kubernetes resource in Flink `KubernetesOwnerReference`, similar to `KubernetesToleration`.
   * `KubernetesOwnerReference` could be built from a map, which is configured via `kubernetes.jobmanager.ownerref`. It is a config option with map `.mapType()`, similar to `kubernetes.jobmanager.tolerations`. 
   * `KubernetesOwnerReference` could be tested separately.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org