You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2019/04/19 13:56:54 UTC

[GitHub] [incubator-druid] drcrallen commented on issue #7509: Fix too many dentry cache slab objs#7508.

drcrallen commented on issue #7509: Fix too many dentry cache slab objs#7508.
URL: https://github.com/apache/incubator-druid/pull/7509#issuecomment-484903798
 
 
   There's another hidden FS bug here:
   
   ```
   synchronized (files) {
     if (closed) {
       return;
     }
     ...    
   ```
   
   If two methods call this, and the first one that finishes causes the JVM to be shut down, then the other one may never finish and actually do the delete. It is at the author's discretion if they want to keep the scope of this PR to just #7508 or to fix up `LimitedTemporaryStorage::close`` in general

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org