You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/10/28 06:17:02 UTC
[GitHub] [arrow] kou opened a new pull request, #14536: ARROW-18186: [C++][MinGW] Make buildable with clang
kou opened a new pull request, #14536:
URL: https://github.com/apache/arrow/pull/14536
Error1 (can't use `[[gnu::dllexport]]` with template):
cpp/src/arrow/util/int_util.cc:463:1: error: an attribute list cannot appear here
INSTANTIATE_ALL()
^~~~~~~~~~~~~~~~~
cpp/src/arrow/util/int_util.cc:454:3: note: expanded from macro 'INSTANTIATE_ALL'
INSTANTIATE_ALL_DEST(uint8_t) \
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cpp/src/arrow/util/int_util.cc:444:3: note: expanded from macro 'INSTANTIATE_ALL_DEST'
INSTANTIATE(uint8_t, DEST) \
^~~~~~~~~~~~~~~~~~~~~~~~~~
cpp/src/arrow/util/int_util.cc:440:12: note: expanded from macro 'INSTANTIATE'
template ARROW_TEMPLATE_EXPORT void TransposeInts( \
^~~~~~~~~~~~~~~~~~~~~
cpp/src/arrow/util/visibility.h:47:31: note: expanded from macro 'ARROW_TEMPLATE_EXPORT'
#define ARROW_TEMPLATE_EXPORT ARROW_DLLEXPORT
^~~~~~~~~~~~~~~
cpp/src/arrow/util/visibility.h:32:25: note: expanded from macro 'ARROW_DLLEXPORT'
#define ARROW_DLLEXPORT [[gnu::dllexport]]
^~~~~~~~~~~~~~~~~~
Error2 (unused variable):
cpp/src/arrow/util/io_util.cc:1079:7: warning: variable 'oflag' set but not used [-Wunused-but-set-variable]
int oflag = _O_CREAT | _O_BINARY | _O_NOINHERIT;
^
Error3 (missing field initializers):
cpp/src/arrow/util/io_util.cc:1545:29: warning: missing field 'InternalHigh' initializer [-Wmissing-field-initializers]
OVERLAPPED overlapped = {0};
^
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #14536: ARROW-18186: [C++][MinGW] Make buildable with clang
Posted by GitBox <gi...@apache.org>.
kou commented on PR #14536:
URL: https://github.com/apache/arrow/pull/14536#issuecomment-1297696011
> can we try to reduce those build times?
Should we do in this pull request? Or can we defer this to ARROW-18039 ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on a diff in pull request #14536: ARROW-18186: [C++][MinGW] Make buildable with clang
Posted by GitBox <gi...@apache.org>.
pitrou commented on code in PR #14536:
URL: https://github.com/apache/arrow/pull/14536#discussion_r1009826861
##########
.github/workflows/cpp.yml:
##########
@@ -293,18 +293,21 @@ jobs:
ci/scripts/cpp_test.sh $(pwd) $(pwd)/build
windows-mingw:
- name: AMD64 Windows MinGW ${{ matrix.mingw-n-bits }} C++
+ name: AMD64 Windows MinGW ${{ matrix.msystem_upper }} C++
runs-on: windows-2019
if: ${{ !contains(github.event.pull_request.title, 'WIP') }}
- # Build may take 1h+ without cache and installing Google Cloud
- # Storage Testbench may take 20m+ without cache.
+ # Build may take 1h+ without cache.
timeout-minutes: 120
strategy:
fail-fast: false
matrix:
- mingw-n-bits:
- - 32
- - 64
+ include:
+ - msystem_lower: mingw32
+ msystem_upper: MINGW32
+ - msystem_lower: mingw64
+ msystem_upper: MINGW64
+ - msystem_lower: clang64
+ msystem_upper: CLANG64
Review Comment:
CI job took 85 minutes...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #14536: ARROW-18186: [C++][MinGW] Make buildable with clang
Posted by GitBox <gi...@apache.org>.
pitrou commented on PR #14536:
URL: https://github.com/apache/arrow/pull/14536#issuecomment-1297625076
PR looks fine a priori, but can we try to reduce those build times?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #14536: ARROW-18186: [C++][MinGW] Make buildable with clang
Posted by GitBox <gi...@apache.org>.
pitrou commented on PR #14536:
URL: https://github.com/apache/arrow/pull/14536#issuecomment-1297699512
We can defer this to ARROW-18039, but I'd like to make sure this isn't forgotten :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #14536: ARROW-18186: [C++][MinGW] Make buildable with clang
Posted by GitBox <gi...@apache.org>.
kou commented on PR #14536:
URL: https://github.com/apache/arrow/pull/14536#issuecomment-1297701029
OK! I'll do it in this month!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #14536: ARROW-18186: [C++][MinGW] Make buildable with clang
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #14536:
URL: https://github.com/apache/arrow/pull/14536#issuecomment-1299384713
Benchmark runs are scheduled for baseline = 85ae0d2e83a31a1a3e99c30c43e905c0fbdd0791 and contender = 474c7a1cb91298bcabe5bed7e0716c0b6ac7820c. 474c7a1cb91298bcabe5bed7e0716c0b6ac7820c is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/dbc5a65fadcb4f2b9380f0e6bf439d28...4940648ea1f240bd9159f34fa841c0de/)
[Failed :arrow_down:0.0% :arrow_up:0.0%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/497c6a64375c4e1989d8f64b9a5275b9...f033b8274a1e4132b9236e039d8c5184/)
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/f6abecd2d5a3423d95163940651628cd...d4bf1a5c09fd42db8edadae0bbd12a67/)
[Finished :arrow_down:0.14% :arrow_up:0.0%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/9975cf2f18b94a64b12715285fbe687b...6102a10bd6a24b099fb1ae0ad910e97c/)
Buildkite builds:
[Finished] [`474c7a1c` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/1802)
[Failed] [`474c7a1c` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/1823)
[Finished] [`474c7a1c` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/1790)
[Finished] [`474c7a1c` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/1815)
[Finished] [`85ae0d2e` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/1801)
[Failed] [`85ae0d2e` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/1822)
[Finished] [`85ae0d2e` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/1789)
[Finished] [`85ae0d2e` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/1814)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #14536: ARROW-18186: [C++][MinGW] Make buildable with clang
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14536:
URL: https://github.com/apache/arrow/pull/14536#issuecomment-1294513474
:warning: Ticket **has not been started in JIRA**, please click 'Start Progress'.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #14536: ARROW-18186: [C++][MinGW] Make buildable with clang
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14536:
URL: https://github.com/apache/arrow/pull/14536#issuecomment-1294513449
https://issues.apache.org/jira/browse/ARROW-18186
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou merged pull request #14536: ARROW-18186: [C++][MinGW] Make buildable with clang
Posted by GitBox <gi...@apache.org>.
kou merged PR #14536:
URL: https://github.com/apache/arrow/pull/14536
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org