You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/11/23 11:35:28 UTC

[GitHub] [flink] zentol commented on a diff in pull request #21371: [FLINK-30166][Connector/FileSystem] Refactor tests that use the deprecated StreamingFileSink instead of FileSink

zentol commented on code in PR #21371:
URL: https://github.com/apache/flink/pull/21371#discussion_r1030332500


##########
flink-formats/flink-compress/src/test/java/org/apache/flink/formats/compress/CompressionFactoryITCase.java:
##########
@@ -71,8 +72,8 @@ void testWriteCompressedFile(@TempDir java.nio.file.Path tmpDir) throws Exceptio
                 env.addSource(new FiniteTestSource<>(testData), TypeInformation.of(String.class));
 
         stream.map(str -> str)
-                .addSink(
-                        StreamingFileSink.forBulkFormat(

Review Comment:
   This should've removed the related import. It didn't because of references in the class javadoc, which also should be updated. also applies to other classes.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org