You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Mladen Kovacevic (Code Review)" <ge...@cloudera.org> on 2016/08/24 03:16:08 UTC

[kudu-CR] Update contributing doc page with apache/kudu instead of apache/incubator-kudu 

Mladen Kovacevic has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/4107

Change subject: Update contributing doc page with apache/kudu instead of apache/incubator-kudu
......................................................................

Update contributing doc page with apache/kudu instead of apache/incubator-kudu

Change-Id: Id9b0560f073735e55243643ddada6eac0001b9d4
---
M docs/contributing.adoc
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/07/4107/1
-- 
To view, visit http://gerrit.cloudera.org:8080/4107
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id9b0560f073735e55243643ddada6eac0001b9d4
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mladen Kovacevic <ml...@gmail.com>

[kudu-CR] Update contributing doc page with apache/kudu instead of apache/incubator-kudu

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.

Change subject: Update contributing doc page with apache/kudu instead of apache/incubator-kudu
......................................................................


Patch Set 2:

Build Started http://104.196.14.100/job/kudu-gerrit/3044/

-- 
To view, visit http://gerrit.cloudera.org:8080/4107
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id9b0560f073735e55243643ddada6eac0001b9d4
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mladen Kovacevic <ml...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No

[kudu-CR] Replace incubator-kudu links with kudu in docs

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.

Change subject: Replace incubator-kudu links with kudu in docs
......................................................................


Patch Set 4:

Build Started http://104.196.14.100/job/kudu-gerrit/3048/

-- 
To view, visit http://gerrit.cloudera.org:8080/4107
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id9b0560f073735e55243643ddada6eac0001b9d4
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mladen Kovacevic <ml...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mladen Kovacevic <ml...@gmail.com>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-HasComments: No

[kudu-CR] Update contributing doc page with apache/kudu instead of apache/incubator-kudu

Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has posted comments on this change.

Change subject: Update contributing doc page with apache/kudu instead of apache/incubator-kudu
......................................................................


Patch Set 3: Code-Review+1

-- 
To view, visit http://gerrit.cloudera.org:8080/4107
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id9b0560f073735e55243643ddada6eac0001b9d4
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mladen Kovacevic <ml...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mladen Kovacevic <ml...@gmail.com>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-HasComments: No

[kudu-CR] Update contributing doc page with apache/kudu instead of apache/incubator-kudu

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.

Change subject: Update contributing doc page with apache/kudu instead of apache/incubator-kudu
......................................................................


Patch Set 3:

Build Started http://104.196.14.100/job/kudu-gerrit/3045/

-- 
To view, visit http://gerrit.cloudera.org:8080/4107
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id9b0560f073735e55243643ddada6eac0001b9d4
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mladen Kovacevic <ml...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-HasComments: No

[kudu-CR] Replace incubator-kudu links with kudu in docs

Posted by "Mladen Kovacevic (Code Review)" <ge...@cloudera.org>.
Mladen Kovacevic has posted comments on this change.

Change subject: Replace incubator-kudu links with kudu in docs
......................................................................


Patch Set 4:

(3 comments)

Alex and Will, thanks for the comments. Let me know if anything else is needed here.

http://gerrit.cloudera.org:8080/#/c/4107/3//COMMIT_MSG
Commit Message:

Line 7: Replace incubator-kudu links with kudu in docs
> Could you re-format the commit message a bit to follow the git guideline:
Done


http://gerrit.cloudera.org:8080/#/c/4107/3/docs/contributing.adoc
File docs/contributing.adoc:

Line 52: git clone https://github.com/apache/kudu
> now that the repo name is kudu, I think this can be simplified to
Done


http://gerrit.cloudera.org:8080/#/c/4107/3/docs/installation.adoc
File docs/installation.adoc:

Line 242: $ git clone https://github.com/apache/kudu
> same with all these; the kudu at the end can be left off.
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/4107
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id9b0560f073735e55243643ddada6eac0001b9d4
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mladen Kovacevic <ml...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mladen Kovacevic <ml...@gmail.com>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-HasComments: Yes

[kudu-CR] Update contributing doc page with apache/kudu instead of apache/incubator-kudu

Posted by "Mladen Kovacevic (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/4107

to look at the new patch set (#3).

Change subject: Update contributing doc page with apache/kudu instead of apache/incubator-kudu
......................................................................

Update contributing doc page with apache/kudu instead
of apache/incubator-kudu

Change-Id: Id9b0560f073735e55243643ddada6eac0001b9d4
---
M docs/contributing.adoc
M docs/developing.adoc
M docs/installation.adoc
M docs/release_notes.adoc
4 files changed, 15 insertions(+), 15 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/07/4107/3
-- 
To view, visit http://gerrit.cloudera.org:8080/4107
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id9b0560f073735e55243643ddada6eac0001b9d4
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mladen Kovacevic <ml...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>

[kudu-CR] Update contributing doc page with apache/kudu instead of apache/incubator-kudu

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.

Change subject: Update contributing doc page with apache/kudu instead of apache/incubator-kudu
......................................................................


Patch Set 1:

Build Started http://104.196.14.100/job/kudu-gerrit/3043/

-- 
To view, visit http://gerrit.cloudera.org:8080/4107
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id9b0560f073735e55243643ddada6eac0001b9d4
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mladen Kovacevic <ml...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No

[kudu-CR] Replace incubator-kudu links with kudu in docs

Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has submitted this change and it was merged.

Change subject: Replace incubator-kudu links with kudu in docs
......................................................................


Replace incubator-kudu links with kudu in docs

A number of docs were referring to the old incubator link:

  https://github.com/apache/incubator-kudu

As opposed to the new, non-incubator link.

  https://github.com/apache/kudu

We modify several of the documentation files to ensure that the
links are consistent, and up-to-date with the apache/kudu url.

Change-Id: Id9b0560f073735e55243643ddada6eac0001b9d4
Reviewed-on: http://gerrit.cloudera.org:8080/4107
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <as...@cloudera.com>
Reviewed-by: Dan Burkert <da...@cloudera.com>
---
M RELEASING.adoc
M docs/contributing.adoc
M docs/developing.adoc
M docs/installation.adoc
M docs/release_notes.adoc
5 files changed, 17 insertions(+), 17 deletions(-)

Approvals:
  Dan Burkert: Looks good to me, approved
  Alexey Serbin: Looks good to me, but someone else must approve
  Kudu Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/4107
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id9b0560f073735e55243643ddada6eac0001b9d4
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mladen Kovacevic <ml...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mladen Kovacevic <ml...@gmail.com>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>

[kudu-CR] Update contributing doc page with apache/kudu instead of apache/incubator-kudu

Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has posted comments on this change.

Change subject: Update contributing doc page with apache/kudu instead of apache/incubator-kudu
......................................................................


Patch Set 2:

There's a bunch of similar git clone links that use incubator-kudu instead of kudu in installation.adoc. Could you fix those too? Thanks!

-- 
To view, visit http://gerrit.cloudera.org:8080/4107
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id9b0560f073735e55243643ddada6eac0001b9d4
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mladen Kovacevic <ml...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-HasComments: No

[kudu-CR] Replace incubator-kudu links with kudu in docs

Posted by "Mladen Kovacevic (Code Review)" <ge...@cloudera.org>.
Hello Will Berkeley, Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/4107

to look at the new patch set (#4).

Change subject: Replace incubator-kudu links with kudu in docs
......................................................................

Replace incubator-kudu links with kudu in docs

A number of docs were referring to the old incubator link:

  https://github.com/apache/incubator-kudu

As opposed to the new, non-incubator link.

  https://github.com/apache/kudu

We modify several of the documentation files to ensure that the
links are consistent, and up-to-date with the apache/kudu url.

Change-Id: Id9b0560f073735e55243643ddada6eac0001b9d4
---
M RELEASING.adoc
M docs/contributing.adoc
M docs/developing.adoc
M docs/installation.adoc
M docs/release_notes.adoc
5 files changed, 17 insertions(+), 17 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/07/4107/4
-- 
To view, visit http://gerrit.cloudera.org:8080/4107
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id9b0560f073735e55243643ddada6eac0001b9d4
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mladen Kovacevic <ml...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mladen Kovacevic <ml...@gmail.com>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>

[kudu-CR] Update contributing doc page with apache/kudu instead of apache/incubator-kudu

Posted by "Mladen Kovacevic (Code Review)" <ge...@cloudera.org>.
Mladen Kovacevic has posted comments on this change.

Change subject: Update contributing doc page with apache/kudu instead of apache/incubator-kudu
......................................................................


Patch Set 3:

> There's a bunch of similar git clone links that use incubator-kudu
 > instead of kudu in installation.adoc. Could you fix those too?
 > Thanks!

Sure, did a quick grep, and found some changes in developing, installation and release_notes.

-- 
To view, visit http://gerrit.cloudera.org:8080/4107
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id9b0560f073735e55243643ddada6eac0001b9d4
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mladen Kovacevic <ml...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mladen Kovacevic <ml...@gmail.com>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-HasComments: No

[kudu-CR] Update contributing doc page with apache/kudu instead of apache/incubator-kudu

Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.

Change subject: Update contributing doc page with apache/kudu instead of apache/incubator-kudu
......................................................................


Patch Set 3:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/4107/3/docs/contributing.adoc
File docs/contributing.adoc:

Line 52: git clone https://github.com/apache/kudu.git kudu
now that the repo name is kudu, I think this can be simplified to

git clone https://github.com/apache/kudu


http://gerrit.cloudera.org:8080/#/c/4107/3/docs/installation.adoc
File docs/installation.adoc:

Line 242: $ git clone https://github.com/apache/kudu kudu
same with all these; the kudu at the end can be left off.


-- 
To view, visit http://gerrit.cloudera.org:8080/4107
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id9b0560f073735e55243643ddada6eac0001b9d4
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mladen Kovacevic <ml...@gmail.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mladen Kovacevic <ml...@gmail.com>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-HasComments: Yes

[kudu-CR] Replace incubator-kudu links with kudu in docs

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.

Change subject: Replace incubator-kudu links with kudu in docs
......................................................................


Patch Set 4: Code-Review+1

Thanks, this looks good to me!

P.S.  I would give it +2 but I don't have the privilege :)

-- 
To view, visit http://gerrit.cloudera.org:8080/4107
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id9b0560f073735e55243643ddada6eac0001b9d4
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mladen Kovacevic <ml...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mladen Kovacevic <ml...@gmail.com>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-HasComments: No

[kudu-CR] Update contributing doc page with apache/kudu instead of apache/incubator-kudu

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.

Change subject: Update contributing doc page with apache/kudu instead of apache/incubator-kudu
......................................................................


Patch Set 3:

(1 comment)

Could you also update the RELEASING.adoc accordingly?

http://gerrit.cloudera.org:8080/#/c/4107/3//COMMIT_MSG
Commit Message:

Line 7: Update contributing doc page with apache/kudu instead
Could you re-format the commit message a bit to follow the git guideline:

https://git-scm.com/book/en/v2/Distributed-Git-Contributing-to-a-Project#_commit_guidelines


-- 
To view, visit http://gerrit.cloudera.org:8080/4107
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id9b0560f073735e55243643ddada6eac0001b9d4
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mladen Kovacevic <ml...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mladen Kovacevic <ml...@gmail.com>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-HasComments: Yes

[kudu-CR] Replace incubator-kudu links with kudu in docs

Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.

Change subject: Replace incubator-kudu links with kudu in docs
......................................................................


Patch Set 4: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/4107
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id9b0560f073735e55243643ddada6eac0001b9d4
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mladen Kovacevic <ml...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mladen Kovacevic <ml...@gmail.com>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-HasComments: No

[kudu-CR] Update contributing doc page with apache/kudu instead of apache/incubator-kudu

Posted by "Mladen Kovacevic (Code Review)" <ge...@cloudera.org>.
Mladen Kovacevic has uploaded a new patch set (#2).

Change subject: Update contributing doc page with apache/kudu instead of apache/incubator-kudu
......................................................................

Update contributing doc page with apache/kudu instead
of apache/incubator-kudu

Change-Id: Id9b0560f073735e55243643ddada6eac0001b9d4
---
M docs/contributing.adoc
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/07/4107/2
-- 
To view, visit http://gerrit.cloudera.org:8080/4107
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id9b0560f073735e55243643ddada6eac0001b9d4
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mladen Kovacevic <ml...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins