You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@thrift.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/07/20 12:47:20 UTC

[jira] [Commented] (THRIFT-3845) TBinaryProtocolAccelerated cannot use thrift_protocol ext

    [ https://issues.apache.org/jira/browse/THRIFT-3845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15385790#comment-15385790 ] 

ASF GitHub Bot commented on THRIFT-3845:
----------------------------------------

Github user jeking3 commented on the issue:

    https://github.com/apache/thrift/pull/1022
  
    @RobberPhex could you rebase this against master so we can get a build that passes all tests?


> TBinaryProtocolAccelerated cannot use thrift_protocol ext
> ---------------------------------------------------------
>
>                 Key: THRIFT-3845
>                 URL: https://issues.apache.org/jira/browse/THRIFT-3845
>             Project: Thrift
>          Issue Type: Improvement
>          Components: PHP - Compiler, PHP - Library
>    Affects Versions: 0.9.3
>         Environment: PHP7 with thrift 0.9.3, with thrift_protocol, at OS X 10.11
>            Reporter: Robert Lu
>            Priority: Minor
>
> compiler generate phpcode:
>  instanceof TBinaryProtocolAccelerated
> to indicate use thrift_protocol, but when TBinaryProtocolAccelerated warped in TMultiplexedProtocol, thrift_protocol doesn't used, because TMultiplexedProtocol isn't TBinaryProtocolAccelerated's instence.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)