[GitHub] [arrow] coryan commented on a change in pull request #11851: ARROW-14506: [C++] Conda support for google-cloud-cpp

[GitBox <gi...@apache.org>]

coryan commented on a change in pull request #11851:
URL: https://github.com/apache/arrow/pull/11851#discussion_r763076262



##########
File path: dev/tasks/conda-recipes/arrow-cpp/build-arrow.sh
##########
@@ -58,6 +58,7 @@ cmake \
     -DARROW_DEPENDENCY_SOURCE=SYSTEM \
     -DARROW_FLIGHT=ON \
     -DARROW_FLIGHT_REQUIRE_TLSCREDENTIALSOPTIONS=ON \
+    -DARROW_GCS=ON \
     -DARROW_HDFS=ON \

Review comment:
       Done.  I suspect this may break things (see below).

##########
File path: ci/conda_env_cpp_linux.txt
##########
@@ -0,0 +1,21 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+google-cloud-cpp>=1.34.0

Review comment:
       `google-cloud-cpp` is supported on Linux, Windows and macOS.  The Conda packages only work on Linux and macOS:
   
   https://github.com/conda-forge/google-cloud-cpp-feedstock/issues/76
   
   If needed, I am happy to fix the Conda package first and then resubmit this PR.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org