[GitHub] zookeeper pull request #292: ZOOKEEPER-2819:Changing membership configuratio...

[hanm <gi...@git.apache.org>]

Github user hanm commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/292#discussion_r125173093
  
    --- Diff: src/java/main/org/apache/zookeeper/server/quorum/Learner.java ---
    @@ -374,6 +374,13 @@ else if (qp.getType() == Leader.SNAP) {
                     // The leader is going to dump the database
                     // db is clear as part of deserializeSnapshot()
                     zk.getZKDatabase().deserializeSnapshot(leaderIs);
    +                // ZOOKEEPER-2819: overwrite config node content extracted
    +                // from leader snapshot with local config, to avoid potential
    +                // inconsistency of config node content during rolling restart.
    +                if (!QuorumPeerConfig.isReconfigEnabled()) {
    --- End diff --
    
    @shralex instead of avoiding deserializing the config zNode we could overwrite the deserialized zNode content with local quorum config. Test will be covered in the test improvement JIRA ZOOKEEPER-2828.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---