You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jackrabbit.apache.org by "Henry Kuijpers (Jira)" <ji...@apache.org> on 2021/12/15 15:56:00 UTC

[jira] [Updated] (JCRVLT-577) filter.xml does not delete nodes defined in includes/excludes if folder does not exist in content package

     [ https://issues.apache.org/jira/browse/JCRVLT-577?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Henry Kuijpers updated JCRVLT-577:
----------------------------------
    Description: 
We have the following filter.xml:

{code:xml}
    <filter root="/etc/workflow/launcher/config/update_asset_create"/>
    <filter root="/etc/workflow/launcher/config/update_asset_mod"/>
    <filter root="/etc/workflow/launcher/config">
        <include pattern="/etc/workflow/launcher/config/something-.*(/.*)?"/>
    </filter>
{code}

The content package is as follows:

{code:java}
MB0010:Downloads henrykuijpers$ unzip -l "cleanup.zip"
Archive:  cleanup.zip
  Length      Date    Time    Name
---------  ---------- -----   ----
      139  12-15-2021 15:59   META-INF/MANIFEST.MF
        0  12-15-2021 15:59   META-INF/
        0  12-15-2021 15:59   META-INF/vault/
      785  12-15-2021 15:59   META-INF/vault/properties.xml
     3592  12-15-2021 15:59   META-INF/vault/config.xml
      179  12-15-2021 15:59   META-INF/vault/filter.xml
      338  12-15-2021 15:59   jcr_root/.content.xml
      308  12-15-2021 15:59   META-INF/vault/nodetypes.cnd
        0  12-15-2021 15:59   META-INF/vault/definition/
      947  12-15-2021 15:59   META-INF/vault/definition/.content.xml
{code}

As you can see, we're not including any content in the content package. Our assumption would be that:

/etc/workflow/launcher/config/update_asset_create is deleted => Works
/etc/workflow/launcher/config/update_asset_mod is deleted => Works
/etc/workflow/launcher/config/test is untouched => Works
/etc/workflow/launcher/config/something-test is deleted => Does not work

The entries in the "include"-part of the /etc/workflow/launcher/config filter are only considered, when the jcr_root/etc/workflow/launcher/config folder is present in the content package.

However, the other 2 entries do cause the expected deletion.

  was:
We have the following filter.xml:

{code:xml}
    <filter root="/etc/workflow/launcher/config/update_asset_create"/>
    <filter root="/etc/workflow/launcher/config/update_asset_mod"/>
    <filter root="/etc/workflow/launcher/config">
        <include pattern="/etc/workflow/launcher/config/something-.*(/.*)?"/>
    </filter>
{code}

The content package is as follows:

{code:java}
MB0010:Downloads henrykuijpers$ unzip -l "cleanup.zip"
Archive:  cleanup.zip
  Length      Date    Time    Name
---------  ---------- -----   ----
      139  12-15-2021 15:59   META-INF/MANIFEST.MF
        0  12-15-2021 15:59   META-INF/
        0  12-15-2021 15:59   META-INF/vault/
      785  12-15-2021 15:59   META-INF/vault/properties.xml
     3592  12-15-2021 15:59   META-INF/vault/config.xml
      179  12-15-2021 15:59   META-INF/vault/filter.xml
      338  12-15-2021 15:59   jcr_root/.content.xml
      308  12-15-2021 15:59   META-INF/vault/nodetypes.cnd
        0  12-15-2021 15:59   META-INF/vault/definition/
      947  12-15-2021 15:59   META-INF/vault/definition/.content.xml
{code}

As you can see, we're not including any content in the content package. Our assumption would be that:

/etc/workflow/launcher/config/update_asset_create is deleted => Works
/etc/workflow/launcher/config/update_asset_mod is deleted => Works
/etc/workflow/launcher/config/test is untouched => Works
/etc/workflow/launcher/config/something-test is deleted => Does not work

The entries in the "includes"-part of the /etc/workflow/launcher/config filter are only considered, when the jcr_root/etc/workflow/launcher/config folder is present in the content package.

However, the other 2 entries do cause the expected deletion.


> filter.xml does not delete nodes defined in includes/excludes if folder does not exist in content package
> ---------------------------------------------------------------------------------------------------------
>
>                 Key: JCRVLT-577
>                 URL: https://issues.apache.org/jira/browse/JCRVLT-577
>             Project: Jackrabbit FileVault
>          Issue Type: Bug
>          Components: package maven plugin, vlt
>    Affects Versions: 3.5.6
>            Reporter: Henry Kuijpers
>            Priority: Major
>
> We have the following filter.xml:
> {code:xml}
>     <filter root="/etc/workflow/launcher/config/update_asset_create"/>
>     <filter root="/etc/workflow/launcher/config/update_asset_mod"/>
>     <filter root="/etc/workflow/launcher/config">
>         <include pattern="/etc/workflow/launcher/config/something-.*(/.*)?"/>
>     </filter>
> {code}
> The content package is as follows:
> {code:java}
> MB0010:Downloads henrykuijpers$ unzip -l "cleanup.zip"
> Archive:  cleanup.zip
>   Length      Date    Time    Name
> ---------  ---------- -----   ----
>       139  12-15-2021 15:59   META-INF/MANIFEST.MF
>         0  12-15-2021 15:59   META-INF/
>         0  12-15-2021 15:59   META-INF/vault/
>       785  12-15-2021 15:59   META-INF/vault/properties.xml
>      3592  12-15-2021 15:59   META-INF/vault/config.xml
>       179  12-15-2021 15:59   META-INF/vault/filter.xml
>       338  12-15-2021 15:59   jcr_root/.content.xml
>       308  12-15-2021 15:59   META-INF/vault/nodetypes.cnd
>         0  12-15-2021 15:59   META-INF/vault/definition/
>       947  12-15-2021 15:59   META-INF/vault/definition/.content.xml
> {code}
> As you can see, we're not including any content in the content package. Our assumption would be that:
> /etc/workflow/launcher/config/update_asset_create is deleted => Works
> /etc/workflow/launcher/config/update_asset_mod is deleted => Works
> /etc/workflow/launcher/config/test is untouched => Works
> /etc/workflow/launcher/config/something-test is deleted => Does not work
> The entries in the "include"-part of the /etc/workflow/launcher/config filter are only considered, when the jcr_root/etc/workflow/launcher/config folder is present in the content package.
> However, the other 2 entries do cause the expected deletion.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)