You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/02/05 13:01:20 UTC
[GitHub] [flink] beyond1920 opened a new pull request #14880: [FLINK-21302][table-planner-blink] Fix NPE when use row_number() in over agg
beyond1920 opened a new pull request #14880:
URL: https://github.com/apache/flink/pull/14880
## What is the purpose of the change
Fix NPE when use row_number() in over agg.
## Brief change log
Minor update in `DeclarativeAggCodeGen` to take aggregate without parameters into consideration.
## Verifying this change
ITCase
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14880: [FLINK-21302][table-planner-blink] Fix NPE when use row_number() in over agg
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14880:
URL: https://github.com/apache/flink/pull/14880#issuecomment-774029330
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "958d56cf87affe70f80257b1464d572bc86fe4b1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13001",
"triggerID" : "958d56cf87affe70f80257b1464d572bc86fe4b1",
"triggerType" : "PUSH"
}, {
"hash" : "4b1a437943dbf05b91590eed252f8ba83f14cdb9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=16751",
"triggerID" : "822192133",
"triggerType" : "MANUAL"
}, {
"hash" : "4b1a437943dbf05b91590eed252f8ba83f14cdb9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=16751",
"triggerID" : "4b1a437943dbf05b91590eed252f8ba83f14cdb9",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "822192133",
"triggerType" : "MANUAL"
}, {
"hash" : "ebe907b1a908c981b23450d81f95350f43826c09",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=16834",
"triggerID" : "ebe907b1a908c981b23450d81f95350f43826c09",
"triggerType" : "PUSH"
}, {
"hash" : "7b216e786bdfc2d287333d117c34496ff3005197",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=16920",
"triggerID" : "7b216e786bdfc2d287333d117c34496ff3005197",
"triggerType" : "PUSH"
}, {
"hash" : "72a1f4b213d987c5d3ff3cba388973f66650cd18",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=16928",
"triggerID" : "72a1f4b213d987c5d3ff3cba388973f66650cd18",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ebe907b1a908c981b23450d81f95350f43826c09 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=16834)
* 7b216e786bdfc2d287333d117c34496ff3005197 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=16920)
* 72a1f4b213d987c5d3ff3cba388973f66650cd18 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=16928)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] JingsongLi commented on a change in pull request #14880: [FLINK-21302][table-planner-blink] Fix NPE when use row_number() in over agg
Posted by GitBox <gi...@apache.org>.
JingsongLi commented on a change in pull request #14880:
URL: https://github.com/apache/flink/pull/14880#discussion_r619963485
##########
File path: flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/runtime/stream/sql/OverAggregateITCase.scala
##########
@@ -55,6 +55,36 @@ class OverAggregateITCase(mode: StateBackendMode) extends StreamingWithStateTest
env.getCheckpointConfig.enableUnalignedCheckpoints(false)
}
+ @Test
+ def testRowNumberOnOver(): Unit = {
+ val t = failingDataSource(TestData.tupleData5)
+ .toTable(tEnv, 'a, 'b, 'c, 'd, 'e, 'proctime.proctime)
+ tEnv.registerTable("MyTable", t)
+ val sqlQuery = "SELECT a, ROW_NUMBER() OVER (PARTITION BY a ORDER BY proctime()) FROM MyTable"
+
+ val sink = new TestingAppendSink
+ tEnv.sqlQuery(sqlQuery).toAppendStream[Row].addSink(sink)
+ env.execute()
+
+ val expected = List(
+ "1,1",
+ "2,1",
+ "2,2",
+ "3,1",
+ "3,2",
+ "3,3",
+ "4,1",
+ "4,2",
+ "4,3",
+ "4,4",
+ "5,1",
+ "5,2",
+ "5,3",
+ "5,4",
+ "5,5")
+ assertEquals(expected, sink.getAppendResults)
Review comment:
No sort here, this case is unstable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14880: [FLINK-21302][table-planner-blink] Fix NPE when use row_number() in over agg
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14880:
URL: https://github.com/apache/flink/pull/14880#issuecomment-774025655
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 958d56cf87affe70f80257b1464d572bc86fe4b1 (Fri Feb 05 13:13:42 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
* **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-21302).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14880: [FLINK-21302][table-planner-blink] Fix NPE when use row_number() in over agg
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14880:
URL: https://github.com/apache/flink/pull/14880#issuecomment-774029330
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "958d56cf87affe70f80257b1464d572bc86fe4b1",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "958d56cf87affe70f80257b1464d572bc86fe4b1",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 958d56cf87affe70f80257b1464d572bc86fe4b1 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14880: [FLINK-21302][table-planner-blink] Fix NPE when use row_number() in over agg
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14880:
URL: https://github.com/apache/flink/pull/14880#issuecomment-774025655
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 72a1f4b213d987c5d3ff3cba388973f66650cd18 (Fri May 28 09:13:36 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] beyond1920 commented on pull request #14880: [FLINK-21302][table-planner-blink] Fix NPE when use row_number() in over agg
Posted by GitBox <gi...@apache.org>.
beyond1920 commented on pull request #14880:
URL: https://github.com/apache/flink/pull/14880#issuecomment-823750753
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14880: [FLINK-21302][table-planner-blink] Fix NPE when use row_number() in over agg
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14880:
URL: https://github.com/apache/flink/pull/14880#issuecomment-774029330
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "958d56cf87affe70f80257b1464d572bc86fe4b1",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13001",
"triggerID" : "958d56cf87affe70f80257b1464d572bc86fe4b1",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 958d56cf87affe70f80257b1464d572bc86fe4b1 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13001)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14880: [FLINK-21302][table-planner-blink] Fix NPE when use row_number() in over agg
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14880:
URL: https://github.com/apache/flink/pull/14880#issuecomment-774029330
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "958d56cf87affe70f80257b1464d572bc86fe4b1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13001",
"triggerID" : "958d56cf87affe70f80257b1464d572bc86fe4b1",
"triggerType" : "PUSH"
}, {
"hash" : "4b1a437943dbf05b91590eed252f8ba83f14cdb9",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=16751",
"triggerID" : "822192133",
"triggerType" : "MANUAL"
}, {
"hash" : "4b1a437943dbf05b91590eed252f8ba83f14cdb9",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=16751",
"triggerID" : "4b1a437943dbf05b91590eed252f8ba83f14cdb9",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "822192133",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 4b1a437943dbf05b91590eed252f8ba83f14cdb9 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=16751)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14880: [FLINK-21302][table-planner-blink] Fix NPE when use row_number() in over agg
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14880:
URL: https://github.com/apache/flink/pull/14880#issuecomment-774029330
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "958d56cf87affe70f80257b1464d572bc86fe4b1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13001",
"triggerID" : "958d56cf87affe70f80257b1464d572bc86fe4b1",
"triggerType" : "PUSH"
}, {
"hash" : "4b1a437943dbf05b91590eed252f8ba83f14cdb9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=16751",
"triggerID" : "822192133",
"triggerType" : "MANUAL"
}, {
"hash" : "4b1a437943dbf05b91590eed252f8ba83f14cdb9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=16751",
"triggerID" : "4b1a437943dbf05b91590eed252f8ba83f14cdb9",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "822192133",
"triggerType" : "MANUAL"
}, {
"hash" : "ebe907b1a908c981b23450d81f95350f43826c09",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=16834",
"triggerID" : "ebe907b1a908c981b23450d81f95350f43826c09",
"triggerType" : "PUSH"
}, {
"hash" : "7b216e786bdfc2d287333d117c34496ff3005197",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=16920",
"triggerID" : "7b216e786bdfc2d287333d117c34496ff3005197",
"triggerType" : "PUSH"
}, {
"hash" : "72a1f4b213d987c5d3ff3cba388973f66650cd18",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "72a1f4b213d987c5d3ff3cba388973f66650cd18",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ebe907b1a908c981b23450d81f95350f43826c09 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=16834)
* 7b216e786bdfc2d287333d117c34496ff3005197 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=16920)
* 72a1f4b213d987c5d3ff3cba388973f66650cd18 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14880: [FLINK-21302][table-planner-blink] Fix NPE when use row_number() in over agg
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14880:
URL: https://github.com/apache/flink/pull/14880#issuecomment-774029330
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "958d56cf87affe70f80257b1464d572bc86fe4b1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13001",
"triggerID" : "958d56cf87affe70f80257b1464d572bc86fe4b1",
"triggerType" : "PUSH"
}, {
"hash" : "4b1a437943dbf05b91590eed252f8ba83f14cdb9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=16751",
"triggerID" : "822192133",
"triggerType" : "MANUAL"
}, {
"hash" : "4b1a437943dbf05b91590eed252f8ba83f14cdb9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=16751",
"triggerID" : "4b1a437943dbf05b91590eed252f8ba83f14cdb9",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "822192133",
"triggerType" : "MANUAL"
}, {
"hash" : "ebe907b1a908c981b23450d81f95350f43826c09",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=16834",
"triggerID" : "ebe907b1a908c981b23450d81f95350f43826c09",
"triggerType" : "PUSH"
}, {
"hash" : "7b216e786bdfc2d287333d117c34496ff3005197",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "7b216e786bdfc2d287333d117c34496ff3005197",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ebe907b1a908c981b23450d81f95350f43826c09 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=16834)
* 7b216e786bdfc2d287333d117c34496ff3005197 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] beyond1920 closed pull request #14880: [FLINK-21302][table-planner-blink] Fix NPE when use row_number() in over agg
Posted by GitBox <gi...@apache.org>.
beyond1920 closed pull request #14880:
URL: https://github.com/apache/flink/pull/14880
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14880: [FLINK-21302][table-planner-blink] Fix NPE when use row_number() in over agg
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14880:
URL: https://github.com/apache/flink/pull/14880#issuecomment-774029330
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "958d56cf87affe70f80257b1464d572bc86fe4b1",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13001",
"triggerID" : "958d56cf87affe70f80257b1464d572bc86fe4b1",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 958d56cf87affe70f80257b1464d572bc86fe4b1 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13001)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14880: [FLINK-21302][table-planner-blink] Fix NPE when use row_number() in over agg
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14880:
URL: https://github.com/apache/flink/pull/14880#issuecomment-774029330
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "958d56cf87affe70f80257b1464d572bc86fe4b1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13001",
"triggerID" : "958d56cf87affe70f80257b1464d572bc86fe4b1",
"triggerType" : "PUSH"
}, {
"hash" : "4b1a437943dbf05b91590eed252f8ba83f14cdb9",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=16751",
"triggerID" : "822192133",
"triggerType" : "MANUAL"
}, {
"hash" : "4b1a437943dbf05b91590eed252f8ba83f14cdb9",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=16751",
"triggerID" : "4b1a437943dbf05b91590eed252f8ba83f14cdb9",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "822192133",
"triggerType" : "MANUAL"
}, {
"hash" : "ebe907b1a908c981b23450d81f95350f43826c09",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=16834",
"triggerID" : "ebe907b1a908c981b23450d81f95350f43826c09",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4b1a437943dbf05b91590eed252f8ba83f14cdb9 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=16751)
* ebe907b1a908c981b23450d81f95350f43826c09 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=16834)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14880: [FLINK-21302][table-planner-blink] Fix NPE when use row_number() in over agg
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14880:
URL: https://github.com/apache/flink/pull/14880#issuecomment-774029330
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "958d56cf87affe70f80257b1464d572bc86fe4b1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13001",
"triggerID" : "958d56cf87affe70f80257b1464d572bc86fe4b1",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "CANCELED",
"url" : "TBD",
"triggerID" : "822192133",
"triggerType" : "MANUAL"
}, {
"hash" : "4b1a437943dbf05b91590eed252f8ba83f14cdb9",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=16751",
"triggerID" : "822192133",
"triggerType" : "MANUAL"
}, {
"hash" : "4b1a437943dbf05b91590eed252f8ba83f14cdb9",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=16751",
"triggerID" : "4b1a437943dbf05b91590eed252f8ba83f14cdb9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* Unknown: [CANCELED](TBD)
* 4b1a437943dbf05b91590eed252f8ba83f14cdb9 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=16751)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14880: [FLINK-21302][table-planner-blink] Fix NPE when use row_number() in over agg
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14880:
URL: https://github.com/apache/flink/pull/14880#issuecomment-774029330
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "958d56cf87affe70f80257b1464d572bc86fe4b1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13001",
"triggerID" : "958d56cf87affe70f80257b1464d572bc86fe4b1",
"triggerType" : "PUSH"
}, {
"hash" : "4b1a437943dbf05b91590eed252f8ba83f14cdb9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=16751",
"triggerID" : "822192133",
"triggerType" : "MANUAL"
}, {
"hash" : "4b1a437943dbf05b91590eed252f8ba83f14cdb9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=16751",
"triggerID" : "4b1a437943dbf05b91590eed252f8ba83f14cdb9",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "822192133",
"triggerType" : "MANUAL"
}, {
"hash" : "ebe907b1a908c981b23450d81f95350f43826c09",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=16834",
"triggerID" : "ebe907b1a908c981b23450d81f95350f43826c09",
"triggerType" : "PUSH"
}, {
"hash" : "7b216e786bdfc2d287333d117c34496ff3005197",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=16920",
"triggerID" : "7b216e786bdfc2d287333d117c34496ff3005197",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ebe907b1a908c981b23450d81f95350f43826c09 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=16834)
* 7b216e786bdfc2d287333d117c34496ff3005197 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=16920)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14880: [FLINK-21302][table-planner-blink] Fix NPE when use row_number() in over agg
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14880:
URL: https://github.com/apache/flink/pull/14880#issuecomment-774029330
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "958d56cf87affe70f80257b1464d572bc86fe4b1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13001",
"triggerID" : "958d56cf87affe70f80257b1464d572bc86fe4b1",
"triggerType" : "PUSH"
}, {
"hash" : "4b1a437943dbf05b91590eed252f8ba83f14cdb9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=16751",
"triggerID" : "822192133",
"triggerType" : "MANUAL"
}, {
"hash" : "4b1a437943dbf05b91590eed252f8ba83f14cdb9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=16751",
"triggerID" : "4b1a437943dbf05b91590eed252f8ba83f14cdb9",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "822192133",
"triggerType" : "MANUAL"
}, {
"hash" : "ebe907b1a908c981b23450d81f95350f43826c09",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=16834",
"triggerID" : "ebe907b1a908c981b23450d81f95350f43826c09",
"triggerType" : "PUSH"
}, {
"hash" : "7b216e786bdfc2d287333d117c34496ff3005197",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=16920",
"triggerID" : "7b216e786bdfc2d287333d117c34496ff3005197",
"triggerType" : "PUSH"
}, {
"hash" : "72a1f4b213d987c5d3ff3cba388973f66650cd18",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=16928",
"triggerID" : "72a1f4b213d987c5d3ff3cba388973f66650cd18",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 72a1f4b213d987c5d3ff3cba388973f66650cd18 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=16928)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14880: [FLINK-21302][table-planner-blink] Fix NPE when use row_number() in over agg
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14880:
URL: https://github.com/apache/flink/pull/14880#issuecomment-774029330
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "958d56cf87affe70f80257b1464d572bc86fe4b1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13001",
"triggerID" : "958d56cf87affe70f80257b1464d572bc86fe4b1",
"triggerType" : "PUSH"
}, {
"hash" : "4b1a437943dbf05b91590eed252f8ba83f14cdb9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=16751",
"triggerID" : "822192133",
"triggerType" : "MANUAL"
}, {
"hash" : "4b1a437943dbf05b91590eed252f8ba83f14cdb9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=16751",
"triggerID" : "4b1a437943dbf05b91590eed252f8ba83f14cdb9",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "822192133",
"triggerType" : "MANUAL"
}, {
"hash" : "ebe907b1a908c981b23450d81f95350f43826c09",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=16834",
"triggerID" : "ebe907b1a908c981b23450d81f95350f43826c09",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ebe907b1a908c981b23450d81f95350f43826c09 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=16834)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] JingsongLi commented on a change in pull request #14880: [FLINK-21302][table-planner-blink] Fix NPE when use row_number() in over agg
Posted by GitBox <gi...@apache.org>.
JingsongLi commented on a change in pull request #14880:
URL: https://github.com/apache/flink/pull/14880#discussion_r619963485
##########
File path: flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/runtime/stream/sql/OverAggregateITCase.scala
##########
@@ -55,6 +55,36 @@ class OverAggregateITCase(mode: StateBackendMode) extends StreamingWithStateTest
env.getCheckpointConfig.enableUnalignedCheckpoints(false)
}
+ @Test
+ def testRowNumberOnOver(): Unit = {
+ val t = failingDataSource(TestData.tupleData5)
+ .toTable(tEnv, 'a, 'b, 'c, 'd, 'e, 'proctime.proctime)
+ tEnv.registerTable("MyTable", t)
+ val sqlQuery = "SELECT a, ROW_NUMBER() OVER (PARTITION BY a ORDER BY proctime()) FROM MyTable"
+
+ val sink = new TestingAppendSink
+ tEnv.sqlQuery(sqlQuery).toAppendStream[Row].addSink(sink)
+ env.execute()
+
+ val expected = List(
+ "1,1",
+ "2,1",
+ "2,2",
+ "3,1",
+ "3,2",
+ "3,3",
+ "4,1",
+ "4,2",
+ "4,3",
+ "4,4",
+ "5,1",
+ "5,2",
+ "5,3",
+ "5,4",
+ "5,5")
+ assertEquals(expected, sink.getAppendResults)
Review comment:
No sort here, this case is unstable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14880: [FLINK-21302][table-planner-blink] Fix NPE when use row_number() in over agg
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14880:
URL: https://github.com/apache/flink/pull/14880#issuecomment-774029330
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "958d56cf87affe70f80257b1464d572bc86fe4b1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13001",
"triggerID" : "958d56cf87affe70f80257b1464d572bc86fe4b1",
"triggerType" : "PUSH"
}, {
"hash" : "4b1a437943dbf05b91590eed252f8ba83f14cdb9",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=16751",
"triggerID" : "822192133",
"triggerType" : "MANUAL"
}, {
"hash" : "4b1a437943dbf05b91590eed252f8ba83f14cdb9",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=16751",
"triggerID" : "4b1a437943dbf05b91590eed252f8ba83f14cdb9",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "822192133",
"triggerType" : "MANUAL"
}, {
"hash" : "ebe907b1a908c981b23450d81f95350f43826c09",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "ebe907b1a908c981b23450d81f95350f43826c09",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4b1a437943dbf05b91590eed252f8ba83f14cdb9 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=16751)
* ebe907b1a908c981b23450d81f95350f43826c09 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14880: [FLINK-21302][table-planner-blink] Fix NPE when use row_number() in over agg
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14880:
URL: https://github.com/apache/flink/pull/14880#issuecomment-774029330
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "958d56cf87affe70f80257b1464d572bc86fe4b1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13001",
"triggerID" : "958d56cf87affe70f80257b1464d572bc86fe4b1",
"triggerType" : "PUSH"
}, {
"hash" : "4b1a437943dbf05b91590eed252f8ba83f14cdb9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=16751",
"triggerID" : "822192133",
"triggerType" : "MANUAL"
}, {
"hash" : "4b1a437943dbf05b91590eed252f8ba83f14cdb9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=16751",
"triggerID" : "4b1a437943dbf05b91590eed252f8ba83f14cdb9",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "822192133",
"triggerType" : "MANUAL"
}, {
"hash" : "ebe907b1a908c981b23450d81f95350f43826c09",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=16834",
"triggerID" : "ebe907b1a908c981b23450d81f95350f43826c09",
"triggerType" : "PUSH"
}, {
"hash" : "7b216e786bdfc2d287333d117c34496ff3005197",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=16920",
"triggerID" : "7b216e786bdfc2d287333d117c34496ff3005197",
"triggerType" : "PUSH"
}, {
"hash" : "72a1f4b213d987c5d3ff3cba388973f66650cd18",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=16928",
"triggerID" : "72a1f4b213d987c5d3ff3cba388973f66650cd18",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7b216e786bdfc2d287333d117c34496ff3005197 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=16920)
* 72a1f4b213d987c5d3ff3cba388973f66650cd18 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=16928)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] godfreyhe closed pull request #14880: [FLINK-21302][table-planner-blink] Fix NPE when use row_number() in over agg
Posted by GitBox <gi...@apache.org>.
godfreyhe closed pull request #14880:
URL: https://github.com/apache/flink/pull/14880
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] beyond1920 commented on pull request #14880: [FLINK-21302][table-planner-blink] Fix NPE when use row_number() in over agg
Posted by GitBox <gi...@apache.org>.
beyond1920 commented on pull request #14880:
URL: https://github.com/apache/flink/pull/14880#issuecomment-822179197
@godfreyhe Thanks for the review. I've addressed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14880: [FLINK-21302][table-planner-blink] Fix NPE when use row_number() in over agg
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14880:
URL: https://github.com/apache/flink/pull/14880#issuecomment-774029330
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "958d56cf87affe70f80257b1464d572bc86fe4b1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13001",
"triggerID" : "958d56cf87affe70f80257b1464d572bc86fe4b1",
"triggerType" : "PUSH"
}, {
"hash" : "4b1a437943dbf05b91590eed252f8ba83f14cdb9",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "822192133",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "CANCELED",
"url" : "TBD",
"triggerID" : "822192133",
"triggerType" : "MANUAL"
}, {
"hash" : "4b1a437943dbf05b91590eed252f8ba83f14cdb9",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "4b1a437943dbf05b91590eed252f8ba83f14cdb9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* Unknown: [CANCELED](TBD)
* 4b1a437943dbf05b91590eed252f8ba83f14cdb9 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] beyond1920 commented on pull request #14880: [FLINK-21302][table-planner-blink] Fix NPE when use row_number() in over agg
Posted by GitBox <gi...@apache.org>.
beyond1920 commented on pull request #14880:
URL: https://github.com/apache/flink/pull/14880#issuecomment-822192133
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org