You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "timsaucer (via GitHub)" <gi...@apache.org> on 2025/12/16 17:15:12 UTC
[PR] Update 4 crates to rust 2024 edition [datafusion]
timsaucer opened a new pull request, #19357:
URL: https://github.com/apache/datafusion/pull/19357
## Which issue does this PR close?
This addresses part of https://github.com/apache/datafusion/issues/15804 but does not close it.
## Rationale for this change
Now that we are on MSRV 1.88 we can use rust edition 2024, which brings let chains and other nice features. It also improves `unsafe` checking. In order to introduce these changes in slower way instead of one massive PR that is too difficult to manage we are updating a few crates at a time.
## What changes are included in this PR?
Updates these crates to 2024.
- datafusion-cli
- datafusion-proto
- datafusion-substrait
- datafusion-wasmtest
## Are these changes tested?
Existing unit tests. There are no functional code changes.
## Are there any user-facing changes?
None.
## Note
It is recommended to review with the ignore whitespace setting: https://github.com/apache/datafusion/pull/19332/files?w=1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Update 4 crates to rust 2024 edition [datafusion]
Posted by "timsaucer (via GitHub)" <gi...@apache.org>.
timsaucer merged PR #19357:
URL: https://github.com/apache/datafusion/pull/19357
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Update 4 crates to rust 2024 edition [datafusion]
Posted by "timsaucer (via GitHub)" <gi...@apache.org>.
timsaucer commented on code in PR #19357:
URL: https://github.com/apache/datafusion/pull/19357#discussion_r2624255896
##########
datafusion-cli/src/catalog.rs:
##########
@@ -219,12 +219,12 @@ impl SchemaProvider for DynamicObjectStoreSchemaProvider {
}
pub fn substitute_tilde(cur: String) -> String {
- if let Some(usr_dir_path) = home_dir() {
- if let Some(usr_dir) = usr_dir_path.to_str() {
- if cur.starts_with('~') && !usr_dir.is_empty() {
- return cur.replacen('~', usr_dir, 1);
- }
- }
+ if let Some(usr_dir_path) = home_dir()
+ && let Some(usr_dir) = usr_dir_path.to_str()
+ && cur.starts_with('~')
+ && !usr_dir.is_empty()
+ {
+ return cur.replacen('~', usr_dir, 1);
Review Comment:
So much nicer!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org