You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@geode.apache.org by DivineEnder <gi...@git.apache.org> on 2017/07/06 00:02:02 UTC

[GitHub] geode pull request #619: Feature/geode 2901

GitHub user DivineEnder opened a pull request:

    https://github.com/apache/geode/pull/619

    Feature/geode 2901

    Thank you for submitting a contribution to Apache Geode.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
    
    - [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
    
    - [ ] Is your initial contribution a single, squashed commit?
    
    - [ ] Does `gradlew build` run cleanly?
    
    - [ ] Have you written or updated unit tests to verify your changes?
    
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and
    submit an update to your PR as soon as possible. If you need help, please send an
    email to dev@geode.apache.org.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/DivineEnder/geode feature/GEODE-2901

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/geode/pull/619.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #619
    
----
commit 5d5ede50a1367f6851b3c9eb5db7a843b84cb4ac
Author: David Anuta <da...@gmail.com>
Date:   2017-07-05T17:12:01Z

    GEODE-3167: Added commons-validator dependency to modify_war script and Tomcat required jars

commit e1b5570bac6d56bce6132daa93c84e39938f5f88
Author: David Anuta <da...@gmail.com>
Date:   2017-07-03T23:55:03Z

    Updating installation and container management to allow more container independence (just in time for the 4th)

commit 2350d37f294bf8a03a45cc8626522dcd1b610440
Author: David Anuta <da...@gmail.com>
Date:   2017-07-04T00:12:29Z

    Fixed incorrect local cache enabled property setting for jetty and tomcat
    
    Setting has previously been set as a cache property as enableLocalCache. Jetty needs the cache property enable_local_cache so moved the setting of this property within each container (Tomcat and Jetty) with their respective variable names

commit 1ad5395befdf330b35b931624a0bf79155dafa0f
Author: David Anuta <da...@gmail.com>
Date:   2017-07-05T23:21:27Z

    Fixed server.xml so that it was no longer installation specific
    
    Previously, each container edited the same file, which led to some concurrency issues. Now the configuration holds the server xml configuration and only writes it to the configuration folder when a container is started.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode issue #619: Feature/geode 2901

Posted by DivineEnder <gi...@git.apache.org>.

Github user DivineEnder commented on the issue:

    https://github.com/apache/geode/pull/619
  
    @ladyVader @nabarunnag @boglesby @jhuynh1 @upthewaterspout @gesterzhou 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode issue #619: Feature/geode 2901

Posted by DivineEnder <gi...@git.apache.org>.

Github user DivineEnder commented on the issue:

    https://github.com/apache/geode/pull/619
  
    Still working on adding javadoc, but the actual code is all in place


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #619: GEODE-2901: Refining session replication tests

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/geode/pull/619


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---