[GitHub] [nifi-minifi-cpp] arpadboda commented on a change in pull request #668: MINIFICPP-1072 - Fixed temporary path for GetFileTests on Windows

[GitBox <gi...@apache.org>]

arpadboda commented on a change in pull request #668: MINIFICPP-1072 - Fixed temporary path for GetFileTests on Windows
URL: https://github.com/apache/nifi-minifi-cpp/pull/668#discussion_r342630449
 
 

 ##########
 File path: extensions/standard-processors/tests/unit/GetFileTests.cpp
 ##########
 @@ -52,7 +52,7 @@ TEST_CASE("GetFile: MaxSize", "[getFileFifo]") {  // NOLINT
   std::string in_file = temp_path + utils::file::FileUtils::get_separator() + "testfifo";
 
   // Define test input file
-  std::string hidden_in_file(in_dir);
+  std::string hidden_in_file(temp_path);
 
 Review comment:
   This is wrong.
   
   The goal here is to create two files in the same dir:
   ```
   testinfo #not hidden
   .testinfo #hidden 
   ```
   
   Your change puts the latter one in a different directory. 
   
   The correct fix would be:
   ```
   std::string hidden_in_file(in_dir + utils::file::FileUtils::get_separator() + ".testfifo");  // hidden
   ```
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services