You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "jwtryg (via GitHub)" <gi...@apache.org> on 2025/04/30 05:19:10 UTC
[I] table.doCommit call fails when metadata file is already removed [iceberg-go]
jwtryg opened a new issue, #411:
URL: https://github.com/apache/iceberg-go/issues/411
### Apache Iceberg version
main (development)
### Please describe the bug 🐞
When `write.metadata.delete-after-commit.enabled` is set to true, the [deleteOldMetadata](https://github.com/apache/iceberg-go/blob/5cf1bdba4ee442bd61f2a8d9e5c64d3f42a75763/table/table.go#L222) function will delete the old metadata files from the underlying fs. If this deletion fails, then the `doCommit` call will fail, even though the commit itself actually succeeded. This will happen fx. if a metadata file to be deleted has already been deleted by an external entity.
This problem occurs when using the [Lakekeeper rest catalog implementation](https://github.com/lakekeeper/lakekeeper). Lakekeeper will also delete old metadata files when committing if `write.metadata.delete-after-commit.enabled` is set to true.
For reference, pyIceberg will simply log any failed delete. Should the goIceberg client maybe use the same approach?
I am happy to submit a PR to change this behaviour.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] table.doCommit call fails when metadata file is already removed [iceberg-go]
Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade closed issue #411: table.doCommit call fails when metadata file is already removed
URL: https://github.com/apache/iceberg-go/issues/411
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] table.doCommit call fails when metadata file is already removed [iceberg-go]
Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade closed issue #411: table.doCommit call fails when metadata file is already removed
URL: https://github.com/apache/iceberg-go/issues/411
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] table.doCommit call fails when metadata file is already removed [iceberg-go]
Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade commented on issue #411:
URL: https://github.com/apache/iceberg-go/issues/411#issuecomment-2842219665
That seems like a reasonable solution!
> I am happy to submit a PR to change this behaviour.
Please do! I'll happily review it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org