You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@shindig.apache.org by "Ryan Baxter (JIRA)" <ji...@apache.org> on 2013/08/26 19:45:55 UTC

[jira] [Resolved] (SHINDIG-1930) Bug fix for last review (configurable to support different SHA algorithm) https://reviews.apache.org/r/11299

     [ https://issues.apache.org/jira/browse/SHINDIG-1930?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ryan Baxter resolved SHINDIG-1930.
----------------------------------

       Resolution: Fixed
    Fix Version/s:     (was: 2.5.0-beta6)
                   2.5.1

Committed revision 1517617
                
> Bug fix for last review (configurable to support different SHA algorithm) https://reviews.apache.org/r/11299
> ------------------------------------------------------------------------------------------------------------
>
>                 Key: SHINDIG-1930
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1930
>             Project: Shindig
>          Issue Type: Bug
>          Components: Java
>    Affects Versions: 2.5.0-beta6
>            Reporter: Zhihong Yang
>             Fix For: 2.5.1
>
>
> in last patch, (configurable to support different SHA algorithm) https://reviews.apache.org/r/11299:
> a problem appears to be in
> BasicBlobCrypter.unwarp, more specifically the problem is with these two
> lines
>      byte[] hmac = new byte[Crypto.HMAC_SHA_LEN];
>      byte[] cipherText = new byte[bin.length-Crypto.HMAC_SHA_LEN];
> Crypto.HMAC_SHA_LEN is the length of the HMAC SHA1, so once you change the
> hashing algorithm to something else the wrap function throws an exception.
> and more junit tests are added.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira