You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by Simon Kitching <si...@chello.at> on 2008/01/21 09:03:26 UTC

Re: svn commit: r613743 - in /myfaces/core/trunk_1.2.x: api/pom.xml build/pom.xml impl/pom.xml pom.xml

---- matzew@apache.org schrieb:
> -removed redundant versions as well...

>        <plugin>
> -        <groupId>org.apache.myfaces.trinidadbuild</groupId>
> -        <artifactId>maven-faces-plugin</artifactId>
> -        <version>1.2.6-SNAPSHOT</version>
> +        <groupId>org.apache.myfaces.buildtools</groupId>
> +        <artifactId>myfaces-faces-plugin</artifactId>

Why is there no version tag here?

A plugin with no version specified == unpredictable builds.

> --- myfaces/core/trunk_1.2.x/pom.xml (original)
> +++ myfaces/core/trunk_1.2.x/pom.xml Sun Jan 20 19:50:35 2008
> @@ -64,9 +64,9 @@
>      <pluginManagement>
>        <plugins>
>          <plugin>
> -          <groupId>org.apache.myfaces.trinidadbuild</groupId>
> -          <artifactId>maven-faces-plugin</artifactId>
> -          <version>1.2.6-SNAPSHOT</version>
> +          <groupId>org.apache.myfaces.buildtools</groupId>
> +          <artifactId>myfaces-faces-plugin</artifactId>
> +          <version>1.0.0-SNAPSHOT</version>

That looks better to me...

Regards,
Simon


Re: svn commit: r613743 - in /myfaces/core/trunk_1.2.x: api/pom.xml build/pom.xml impl/pom.xml pom.xml

Posted by Matthias Wessendorf <ma...@apache.org>.
On Jan 21, 2008 12:03 AM, Simon Kitching <si...@chello.at> wrote:
> ---- matzew@apache.org schrieb:
> > -removed redundant versions as well...
>
> >        <plugin>
> > -        <groupId>org.apache.myfaces.trinidadbuild</groupId>
> > -        <artifactId>maven-faces-plugin</artifactId>
> > -        <version>1.2.6-SNAPSHOT</version>
> > +        <groupId>org.apache.myfaces.buildtools</groupId>
> > +        <artifactId>myfaces-faces-plugin</artifactId>
>
> Why is there no version tag here?

because this is inheriting the version from the plugin-mgmt.


>
> A plugin with no version specified == unpredictable builds.
>
> > --- myfaces/core/trunk_1.2.x/pom.xml (original)
> > +++ myfaces/core/trunk_1.2.x/pom.xml Sun Jan 20 19:50:35 2008
> > @@ -64,9 +64,9 @@
> >      <pluginManagement>
> >        <plugins>
> >          <plugin>
> > -          <groupId>org.apache.myfaces.trinidadbuild</groupId>
> > -          <artifactId>maven-faces-plugin</artifactId>
> > -          <version>1.2.6-SNAPSHOT</version>
> > +          <groupId>org.apache.myfaces.buildtools</groupId>
> > +          <artifactId>myfaces-faces-plugin</artifactId>
> > +          <version>1.0.0-SNAPSHOT</version>
>
> That looks better to me...

from this one..

>
> Regards,
> Simon
>
>



-- 
Matthias Wessendorf

further stuff:
blog: http://matthiaswessendorf.wordpress.com/
sessions: http://www.slideshare.net/mwessendorf
mail: matzew-at-apache-dot-org