You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2020/07/29 07:44:57 UTC

[GitHub] [couchdb] nickva commented on pull request #3043: add local_seq option to views

nickva commented on pull request #3043:
URL: https://github.com/apache/couchdb/pull/3043#issuecomment-665220158


   @garrensmith This is a nice feature!
   
   See a minor comment about keymember vs keyfind and value checking.
   
   Then perhaps we could add is a eunit test to maintain test coverage in fabric. There is already a map test with a variety of views in https://github.com/apache/couchdb/blob/12b7cdc4355866113c1df3f7ba2b036cbdd6c8a0/src/couch_views/test/couch_views_map_test.erl#L499 so could add it there. Maybe one where it is defined and `false` and the other one where it is `true`.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org