You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@cloudstack.apache.org by bharat kumar <bh...@citrix.com> on 2013/11/01 06:40:46 UTC

Review Request 15173: Dynamic compute offering.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15173/
-----------------------------------------------------------

Review request for cloudstack, Kishan Kavala and Koushik Das.


Bugs: CLOUDSTACK-4738
    https://issues.apache.org/jira/browse/CLOUDSTACK-4738


Repository: cloudstack-git


Description
-------

https://issues.apache.org/jira/browse/CLOUDSTACK-4738
Dynamic compute Offering.

Still need to test this. Facing some auto wiring problems when UsageEventUtils bean is created. 


Diffs
-----

  api/src/com/cloud/offering/ServiceOffering.java 9f7bf8e 
  api/src/com/cloud/vm/UserVmService.java 0b142e8 
  api/src/org/apache/cloudstack/api/ApiConstants.java b1bfcfb 
  api/src/org/apache/cloudstack/api/command/admin/offering/CreateServiceOfferingCmd.java decac29 
  api/src/org/apache/cloudstack/api/command/user/vm/DeployVMCmd.java 8a6cea7 
  engine/api/src/org/apache/cloudstack/engine/orchestration/service/VolumeOrchestrationService.java a773ac4 
  engine/api/src/org/apache/cloudstack/engine/service/api/OrchestrationService.java 64ef063 
  engine/components-api/src/com/cloud/configuration/ConfigurationManager.java 03a549f 
  engine/components-api/src/com/cloud/event/UsageEventUtils.java b44ed32 
  engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java b74b4c5 
  engine/orchestration/src/org/apache/cloudstack/engine/orchestration/CloudOrchestrator.java 2fd10b6 
  engine/orchestration/src/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java 0821c81 
  engine/schema/src/com/cloud/event/UsageEventDetailsVO.java PRE-CREATION 
  engine/schema/src/com/cloud/event/dao/UsageEventDetailsDao.java PRE-CREATION 
  engine/schema/src/com/cloud/event/dao/UsageEventDetailsDaoImpl.java PRE-CREATION 
  engine/schema/src/com/cloud/service/ServiceOfferingVO.java 9a262c5 
  engine/schema/src/com/cloud/service/dao/ServiceOfferingDao.java 7da7208 
  engine/schema/src/com/cloud/service/dao/ServiceOfferingDaoImpl.java f807f0d 
  plugins/network-elements/internal-loadbalancer/src/org/apache/cloudstack/network/lb/InternalLoadBalancerVMManagerImpl.java b6269eb 
  server/src/com/cloud/agent/manager/allocator/impl/UserConcentratedAllocator.java 0da2c92 
  server/src/com/cloud/api/query/QueryManagerImpl.java f9d9c4f 
  server/src/com/cloud/capacity/CapacityManagerImpl.java 72905a7 
  server/src/com/cloud/configuration/ConfigurationManagerImpl.java e3aa4fa 
  server/src/com/cloud/consoleproxy/ConsoleProxyManagerImpl.java e82aaba 
  server/src/com/cloud/network/NetworkModelImpl.java df9f651 
  server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java a93480b 
  server/src/com/cloud/vm/UserVmManagerImpl.java 80a4036 
  server/test/com/cloud/capacity/CapacityManagerTest.java 3faa32f 
  server/test/com/cloud/vpc/MockConfigurationManagerImpl.java 3147f1f 
  server/test/resources/createNetworkOffering.xml 9d684ba 
  setup/db/db/schema-421to430.sql 0de9dfd 

Diff: https://reviews.apache.org/r/15173/diff/


Testing
-------

Not tested.


Thanks,

bharat kumar

Re: Review Request 15173: Dynamic compute offering.

Posted by Koushik Das <ko...@citrix.com>.


> On Nov. 7, 2013, 7:17 a.m., Koushik Das wrote:
> > Ship It!

commit 7095ea2b5e497620c8c879517565046e3b46e493


- Koushik


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15173/#review28355
-----------------------------------------------------------


On Nov. 7, 2013, 6:24 a.m., bharat kumar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15173/
> -----------------------------------------------------------
> 
> (Updated Nov. 7, 2013, 6:24 a.m.)
> 
> 
> Review request for cloudstack, Kishan Kavala and Koushik Das.
> 
> 
> Bugs: CLOUDSTACK-4738
>     https://issues.apache.org/jira/browse/CLOUDSTACK-4738
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> https://issues.apache.org/jira/browse/CLOUDSTACK-4738
> Dynamic compute Offering.
> 
> Still need to test this. Facing some auto wiring problems when UsageEventUtils bean is created. 
> 
> 
> Diffs
> -----
> 
>   api/src/com/cloud/offering/ServiceOffering.java 9f7bf8e 
>   api/src/com/cloud/vm/UserVmService.java 0b142e8 
>   api/src/org/apache/cloudstack/api/ApiConstants.java 8ab6c5e 
>   api/src/org/apache/cloudstack/api/command/admin/offering/CreateServiceOfferingCmd.java decac29 
>   api/src/org/apache/cloudstack/api/command/user/vm/DeployVMCmd.java 8a6cea7 
>   engine/api/src/org/apache/cloudstack/engine/orchestration/service/VolumeOrchestrationService.java a773ac4 
>   engine/api/src/org/apache/cloudstack/engine/service/api/OrchestrationService.java 64ef063 
>   engine/components-api/src/com/cloud/event/UsageEventUtils.java b44ed32 
>   engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java b74b4c5 
>   engine/orchestration/src/org/apache/cloudstack/engine/orchestration/CloudOrchestrator.java 2fd10b6 
>   engine/orchestration/src/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java ab626c8 
>   engine/schema/resources/META-INF/cloudstack/core/spring-engine-schema-core-daos-context.xml 98ef018 
>   engine/schema/src/com/cloud/event/UsageEventDetailsVO.java PRE-CREATION 
>   engine/schema/src/com/cloud/event/dao/UsageEventDao.java 01979e1 
>   engine/schema/src/com/cloud/event/dao/UsageEventDaoImpl.java 4333903 
>   engine/schema/src/com/cloud/event/dao/UsageEventDetailsDao.java PRE-CREATION 
>   engine/schema/src/com/cloud/event/dao/UsageEventDetailsDaoImpl.java PRE-CREATION 
>   engine/schema/src/com/cloud/service/ServiceOfferingVO.java 9a262c5 
>   engine/schema/src/com/cloud/service/dao/ServiceOfferingDao.java 7da7208 
>   engine/schema/src/com/cloud/service/dao/ServiceOfferingDaoImpl.java f807f0d 
>   plugins/deployment-planners/implicit-dedication/test/org/apache/cloudstack/implicitplanner/ImplicitPlannerTest.java f1fa71c 
>   plugins/hypervisors/baremetal/src/com/cloud/baremetal/networkservice/BaremetalPxeManagerImpl.java ef6ec31 
>   server/src/com/cloud/agent/manager/allocator/impl/UserConcentratedAllocator.java 0da2c92 
>   server/src/com/cloud/api/query/QueryManagerImpl.java f34e60e 
>   server/src/com/cloud/capacity/CapacityManagerImpl.java 1c5f189 
>   server/src/com/cloud/configuration/ConfigurationManagerImpl.java a31d06f 
>   server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java 9b35a4b 
>   server/src/com/cloud/vm/UserVmManagerImpl.java 9e69962 
>   server/test/com/cloud/capacity/CapacityManagerTest.java 3faa32f 
>   server/test/com/cloud/vm/UserVmManagerTest.java df676d3 
>   server/test/org/apache/cloudstack/networkoffering/CreateNetworkOfferingTest.java f2ebf67 
>   server/test/org/apache/cloudstack/service/ServiceOfferingVOTest.java PRE-CREATION 
>   server/test/resources/createNetworkOffering.xml 9d684ba 
>   setup/db/db/schema-421to430.sql 980650d 
> 
> Diff: https://reviews.apache.org/r/15173/diff/
> 
> 
> Testing
> -------
> 
> Tested on master.
> 
> 
> Thanks,
> 
> bharat kumar
> 
>