Re: [PR] [SPARK-48350][SQL] Introduction of Custom Exceptions for Sql Scripting [spark]

["davidm-db (via GitHub)" <gi...@apache.org>]

davidm-db commented on code in PR #47147:
URL: https://github.com/apache/spark/pull/47147#discussion_r1673753400


##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala:
##########
@@ -142,27 +142,29 @@ class AstBuilder extends DataTypeAstBuilder with SQLConfHelper with Logging {
     CompoundBody(buff.toSeq, label)
   }
 
-  override def visitBeginEndCompoundBlock(ctx: BeginEndCompoundBlockContext): CompoundBody = {
-    val beginLabelCtx = Option(ctx.beginLabel())
-    val endLabelCtx = Option(ctx.endLabel())
+  override def visitBeginEndCompoundBlock(ctx: BeginEndCompoundBlockContext): CompoundBody =
+    withOrigin(ctx) {

Review Comment:
   we are not using origin anywhere in this function, maybe remove for now and we can add if needed later.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org