You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@streampipes.apache.org by GitBox <gi...@apache.org> on 2021/12/30 19:58:17 UTC
[GitHub] [incubator-streampipes] hutcheb opened a new pull request #71: [WIP][STREAMPIPES-] - Webpack 5 issues
hutcheb opened a new pull request #71:
URL: https://github.com/apache/incubator-streampipes/pull/71
<!--
~ Licensed to the Apache Software Foundation (ASF) under one or more
~ contributor license agreements. See the NOTICE file distributed with
~ this work for additional information regarding copyright ownership.
~ The ASF licenses this file to You under the Apache License, Version 2.0
~ (the "License"); you may not use this file except in compliance with
~ the License. You may obtain a copy of the License at
~
~ http://www.apache.org/licenses/LICENSE-2.0
~
~ Unless required by applicable law or agreed to in writing, software
~ distributed under the License is distributed on an "AS IS" BASIS,
~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
~ See the License for the specific language governing permissions and
~ limitations under the License.
~
-->
### Purpose
I ran into some issues that seem to be related to webpack 5.
1) When running ng build without the --configuration production option, it complained about a missing assert package
2) When running the ui using npm start, and opening in the browser. An error message is generated complaining about not being able to find the process variable.
### Approach
1) I have added the assert package to packes.json as a dev dependancy.
2) I have added the provide plugin to the webpack configuration to include 'process/browser'
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-streampipes] dominikriemer merged pull request #71: [STREAMPIPES-491] - Webpack 5 issues
Posted by GitBox <gi...@apache.org>.
dominikriemer merged pull request #71:
URL: https://github.com/apache/incubator-streampipes/pull/71
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-streampipes] hutcheb commented on pull request #71: [STREAMPIPES-491] - Webpack 5 issues
Posted by GitBox <gi...@apache.org>.
hutcheb commented on pull request #71:
URL: https://github.com/apache/incubator-streampipes/pull/71#issuecomment-1003645668
np it’s a nice way to poke around to see how it all works :)
hope you had a good new year
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-streampipes] hutcheb commented on pull request #71: [WIP][STREAMPIPES-491] - Webpack 5 issues
Posted by GitBox <gi...@apache.org>.
hutcheb commented on pull request #71:
URL: https://github.com/apache/incubator-streampipes/pull/71#issuecomment-1003314643
ngx-color-picker and ng-simple-slideshow still need to be updated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-streampipes] dominikriemer commented on pull request #71: [STREAMPIPES-491] - Webpack 5 issues
Posted by GitBox <gi...@apache.org>.
dominikriemer commented on pull request #71:
URL: https://github.com/apache/incubator-streampipes/pull/71#issuecomment-1003568247
Awesome, thanks and happy new year :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-streampipes] dominikriemer commented on pull request #71: [WIP][STREAMPIPES-] - Webpack 5 issues
Posted by GitBox <gi...@apache.org>.
dominikriemer commented on pull request #71:
URL: https://github.com/apache/incubator-streampipes/pull/71#issuecomment-1003182460
Great, looks good to me!
Does the ng build command also execute the prebuild script? Maybe we could also add a script "build-dev" to the npm scripts to run a non-production build.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org