You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/03/02 12:35:41 UTC
[GitHub] [flink] WeiZhong94 opened a new pull request #15063: [FLINK-21434][python] Fix encoding error when using the fast coder to encode a row-type field containing more than 14 fields
WeiZhong94 opened a new pull request #15063:
URL: https://github.com/apache/flink/pull/15063
## What is the purpose of the change
*This pull request fixes a encoding error when using the fast coder to encode a row-type field containing more than 14 fields.)*
## Brief change log
- *Consider the ROW_KIND_BIT_SIZE when calculating the leading_complete_bytes_num and remaining_bits_num.*
## Verifying this change
This change is already covered by existing tests.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #15063: [FLINK-21434][python] Fix encoding error when using the fast coder to encode a row-type field containing more than 14 fields
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15063:
URL: https://github.com/apache/flink/pull/15063#issuecomment-788890531
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "dd8cf7d77215c679a8c2631bb2651c2fc724ee96",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14001",
"triggerID" : "dd8cf7d77215c679a8c2631bb2651c2fc724ee96",
"triggerType" : "PUSH"
}, {
"hash" : "2effd19d74334e7da661d4774eedbaf303cb3ba8",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14024",
"triggerID" : "2effd19d74334e7da661d4774eedbaf303cb3ba8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* dd8cf7d77215c679a8c2631bb2651c2fc724ee96 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14001)
* 2effd19d74334e7da661d4774eedbaf303cb3ba8 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14024)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #15063: [FLINK-21434][python] Fix encoding error when using the fast coder to encode a row-type field containing more than 14 fields
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15063:
URL: https://github.com/apache/flink/pull/15063#issuecomment-788890531
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "dd8cf7d77215c679a8c2631bb2651c2fc724ee96",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14001",
"triggerID" : "dd8cf7d77215c679a8c2631bb2651c2fc724ee96",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* dd8cf7d77215c679a8c2631bb2651c2fc724ee96 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14001)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #15063: [FLINK-21434][python] Fix encoding error when using the fast coder to encode a row-type field containing more than 14 fields
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15063:
URL: https://github.com/apache/flink/pull/15063#issuecomment-788890531
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "dd8cf7d77215c679a8c2631bb2651c2fc724ee96",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14001",
"triggerID" : "dd8cf7d77215c679a8c2631bb2651c2fc724ee96",
"triggerType" : "PUSH"
}, {
"hash" : "2effd19d74334e7da661d4774eedbaf303cb3ba8",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "2effd19d74334e7da661d4774eedbaf303cb3ba8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* dd8cf7d77215c679a8c2631bb2651c2fc724ee96 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14001)
* 2effd19d74334e7da661d4774eedbaf303cb3ba8 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #15063: [FLINK-21434][python] Fix encoding error when using the fast coder to encode a row-type field containing more than 14 fields
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15063:
URL: https://github.com/apache/flink/pull/15063#issuecomment-788890531
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "dd8cf7d77215c679a8c2631bb2651c2fc724ee96",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14001",
"triggerID" : "dd8cf7d77215c679a8c2631bb2651c2fc724ee96",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* dd8cf7d77215c679a8c2631bb2651c2fc724ee96 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14001)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #15063: [FLINK-21434][python] Fix encoding error when using the fast coder to encode a row-type field containing more than 14 fields
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15063:
URL: https://github.com/apache/flink/pull/15063#issuecomment-788890531
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "dd8cf7d77215c679a8c2631bb2651c2fc724ee96",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14001",
"triggerID" : "dd8cf7d77215c679a8c2631bb2651c2fc724ee96",
"triggerType" : "PUSH"
}, {
"hash" : "2effd19d74334e7da661d4774eedbaf303cb3ba8",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14024",
"triggerID" : "2effd19d74334e7da661d4774eedbaf303cb3ba8",
"triggerType" : "PUSH"
}, {
"hash" : "2b27ed5151bf2515e5ca23063032269c944b8bea",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14035",
"triggerID" : "2b27ed5151bf2515e5ca23063032269c944b8bea",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2effd19d74334e7da661d4774eedbaf303cb3ba8 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14024)
* 2b27ed5151bf2515e5ca23063032269c944b8bea Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14035)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #15063: [FLINK-21434][python] Fix encoding error when using the fast coder to encode a row-type field containing more than 14 fields
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15063:
URL: https://github.com/apache/flink/pull/15063#issuecomment-788890531
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "dd8cf7d77215c679a8c2631bb2651c2fc724ee96",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14001",
"triggerID" : "dd8cf7d77215c679a8c2631bb2651c2fc724ee96",
"triggerType" : "PUSH"
}, {
"hash" : "2effd19d74334e7da661d4774eedbaf303cb3ba8",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14024",
"triggerID" : "2effd19d74334e7da661d4774eedbaf303cb3ba8",
"triggerType" : "PUSH"
}, {
"hash" : "2b27ed5151bf2515e5ca23063032269c944b8bea",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "2b27ed5151bf2515e5ca23063032269c944b8bea",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2effd19d74334e7da661d4774eedbaf303cb3ba8 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14024)
* 2b27ed5151bf2515e5ca23063032269c944b8bea UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #15063: [FLINK-21434][python] Fix encoding error when using the fast coder to encode a row-type field containing more than 14 fields
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #15063:
URL: https://github.com/apache/flink/pull/15063#issuecomment-788890531
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "dd8cf7d77215c679a8c2631bb2651c2fc724ee96",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "dd8cf7d77215c679a8c2631bb2651c2fc724ee96",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* dd8cf7d77215c679a8c2631bb2651c2fc724ee96 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #15063: [FLINK-21434][python] Fix encoding error when using the fast coder to encode a row-type field containing more than 14 fields
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #15063:
URL: https://github.com/apache/flink/pull/15063#issuecomment-788890531
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "dd8cf7d77215c679a8c2631bb2651c2fc724ee96",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14001",
"triggerID" : "dd8cf7d77215c679a8c2631bb2651c2fc724ee96",
"triggerType" : "PUSH"
}, {
"hash" : "2effd19d74334e7da661d4774eedbaf303cb3ba8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14024",
"triggerID" : "2effd19d74334e7da661d4774eedbaf303cb3ba8",
"triggerType" : "PUSH"
}, {
"hash" : "2b27ed5151bf2515e5ca23063032269c944b8bea",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14035",
"triggerID" : "2b27ed5151bf2515e5ca23063032269c944b8bea",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2b27ed5151bf2515e5ca23063032269c944b8bea Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=14035)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] WeiZhong94 merged pull request #15063: [FLINK-21434][python] Fix encoding error when using the fast coder to encode a row-type field containing more than 14 fields
Posted by GitBox <gi...@apache.org>.
WeiZhong94 merged pull request #15063:
URL: https://github.com/apache/flink/pull/15063
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #15063: [FLINK-21434][python] Fix encoding error when using the fast coder to encode a row-type field containing more than 14 fields
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #15063:
URL: https://github.com/apache/flink/pull/15063#issuecomment-788886807
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit dd8cf7d77215c679a8c2631bb2651c2fc724ee96 (Tue Mar 02 12:53:03 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] HuangXingBo commented on a change in pull request #15063: [FLINK-21434][python] Fix encoding error when using the fast coder to encode a row-type field containing more than 14 fields
Posted by GitBox <gi...@apache.org>.
HuangXingBo commented on a change in pull request #15063:
URL: https://github.com/apache/flink/pull/15063#discussion_r586043837
##########
File path: flink-python/pyflink/fn_execution/coder_impl_fast.pyx
##########
@@ -700,8 +700,8 @@ cdef class FlattenRowCoderImpl(BaseCoderImpl):
# Row
row_field_coders = (<RowCoderImpl> field_coder).field_coders
row_field_count = len(row_field_coders)
- leading_complete_bytes_num = row_field_count // 8
- remaining_bits_num = row_field_count % 8
+ leading_complete_bytes_num = (row_field_count + ROW_KIND_BIT_SIZE) // 8
+ remaining_bits_num = (row_field_count + ROW_KIND_BIT_SIZE % 8
Review comment:
```suggestion
remaining_bits_num = (row_field_count + ROW_KIND_BIT_SIZE) % 8
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org