[GitHub] [zookeeper] eolivelli commented on pull request #1198: ZOOKEEPER-3670: Clean Up Log Statements for SLF4J

[GitBox <gi...@apache.org>]

eolivelli commented on pull request #1198:
URL: https://github.com/apache/zookeeper/pull/1198#issuecomment-758076083


   @belugabehr 
   thanks for the reminder that also thanks for bringing this point forward.
   
   I am still convinced that it is better to leave guards and enforce a "best practice" (as @anmolnar said).
   
   Calling methods is still "doing something", that is more costly than "not doing anything", in fact the guard is still a method call, but without arguments and probably it is something that can be optimised better by the JVM.
   
   but the main point is that having a consistent style that protects the codebase from stupid errors that could cost lot of resources in production, like leaking some call to a toString() method of a big object is a value.
   
   that said, simply I am not blocking this patch, but I am not sponsoring it, 
   if other people in the community are willing to sponsor this approach than I will be happy to participate in the discussion with 'open mind'
   again, thanks for bringing up this topic to the community 
   
   One way to look for a sponsor is to write to dev@zookeeper.apache.org and start a longer discussion (if we already haven't started it :-) )


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org