[GitHub] [arrow] pitrou commented on a diff in pull request #13595: ARROW-16093: [Python] Address docstrings in Filesystems (Python Implementations)

[GitBox <gi...@apache.org>]

pitrou commented on code in PR #13595:
URL: https://github.com/apache/arrow/pull/13595#discussion_r920100720


##########
python/pyarrow/_fs.pyx:
##########
@@ -1027,6 +1027,23 @@ cdef class PyFileSystem(FileSystem):
     ----------
     handler : FileSystemHandler
         The handler object implementing custom filesystem behavior.
+
+    Examples
+    --------
+    Create an fsspec-based filesystem object for Google Cloud Storage:

Review Comment:
   Also, for the record, we now have a native GCS filesystem class, so I don't know if this is a great example.
   There is a [list of built-in fsspec implementations](https://filesystem-spec.readthedocs.io/en/latest/api.html#built-in-implementations) to choose from, a nice one could perhaps be the Github filesystem?



##########
python/pyarrow/_fs.pyx:
##########
@@ -1027,6 +1027,23 @@ cdef class PyFileSystem(FileSystem):
     ----------
     handler : FileSystemHandler
         The handler object implementing custom filesystem behavior.
+
+    Examples
+    --------
+    Create an fsspec-based filesystem object for Google Cloud Storage:

Review Comment:
   Looks like this fails the CI documentation tests as `gcsfs` isn't installed.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org