You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@struts.apache.org by swiftelan <gi...@git.apache.org> on 2015/05/22 16:29:53 UTC
[GitHub] struts pull request: WW-4503 Build Struts with JDK 7
GitHub user swiftelan opened a pull request:
https://github.com/apache/struts/pull/39
WW-4503 Build Struts with JDK 7
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/swiftelan/struts master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/struts/pull/39.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #39
----
commit e262854e2a1b7548efa0a1eb50d350ecd215231b
Author: Aaron Johnson <aa...@pearson.com>
Date: 2015-05-22T14:28:08Z
WW-4503 Build Struts with JDK 7
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
[GitHub] struts pull request: WW-4503 Build Struts with JDK 7
Posted by swiftelan <gi...@git.apache.org>.
Github user swiftelan closed the pull request at:
https://github.com/apache/struts/pull/39
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
[GitHub] struts pull request: WW-4503 Build Struts with JDK 7
Posted by lukaszlenart <gi...@git.apache.org>.
Github user lukaszlenart commented on a diff in the pull request:
https://github.com/apache/struts/pull/39#discussion_r31052042
--- Diff: pom.xml ---
@@ -352,7 +353,7 @@
<dependency>
<groupId>org.apache.struts</groupId>
<artifactId>struts-annotations</artifactId>
- <version>1.0.5</version>
+ <version>1.0.6-SNAPSHOT</version>
--- End diff --
Do we need this? I thought after dropping APT we can drop this as well
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
[GitHub] struts pull request: WW-4503 Build Struts with JDK 7
Posted by lukaszlenart <gi...@git.apache.org>.
Github user lukaszlenart commented on the pull request:
https://github.com/apache/struts/pull/39#issuecomment-105879836
Yeah... each change must be in separated branch and every commit to that branch will be automatically exposed as a part of PR. That's how it works :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
[GitHub] struts pull request: WW-4503 Build Struts with JDK 7
Posted by lukaszlenart <gi...@git.apache.org>.
Github user lukaszlenart commented on a diff in the pull request:
https://github.com/apache/struts/pull/39#discussion_r31053051
--- Diff: pom.xml ---
@@ -352,7 +353,7 @@
<dependency>
<groupId>org.apache.struts</groupId>
<artifactId>struts-annotations</artifactId>
- <version>1.0.5</version>
+ <version>1.0.6-SNAPSHOT</version>
--- End diff --
Now I get it, we must first update struts-annotations project, release it and then we can use it here
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
[GitHub] struts pull request: WW-4503 Build Struts with JDK 7
Posted by swiftelan <gi...@git.apache.org>.
Github user swiftelan commented on the pull request:
https://github.com/apache/struts/pull/39#issuecomment-105621794
I understand. I merged changes from the GitHub mirror to my fork. I didn't know that it would update the existing pull request, that was not my intention.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
[GitHub] struts pull request: WW-4503 Build Struts with JDK 7
Posted by lukaszlenart <gi...@git.apache.org>.
Github user lukaszlenart commented on the pull request:
https://github.com/apache/struts/pull/39#issuecomment-105588791
It's better to use two dedicated PRs where each addresses just one issue.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
[GitHub] struts pull request: WW-4503 Build Struts with JDK 7
Posted by lukaszlenart <gi...@git.apache.org>.
Github user lukaszlenart commented on the pull request:
https://github.com/apache/struts/pull/39#issuecomment-105880104
Are you going to open a new PR to introduce JDK7? If not I can do it directly based on your changes - it's an easy fix :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
[GitHub] struts pull request: WW-4503 Build Struts with JDK 7
Posted by lukaszlenart <gi...@git.apache.org>.
Github user lukaszlenart commented on the pull request:
https://github.com/apache/struts/pull/39#issuecomment-106001352
Ok, I will handle this based on your work, thanks! It will take some time as releasing new version of struts-annotations requires a vote
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
[GitHub] struts pull request: WW-4503 Build Struts with JDK 7
Posted by lukaszlenart <gi...@git.apache.org>.
Github user lukaszlenart commented on the pull request:
https://github.com/apache/struts/pull/39#issuecomment-105598273
This PRs mixed fixes for two different things :(
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
[GitHub] struts pull request: WW-4503 Build Struts with JDK 7
Posted by swiftelan <gi...@git.apache.org>.
Github user swiftelan commented on the pull request:
https://github.com/apache/struts/pull/39#issuecomment-105947844
Moving to Java 7 requires the new annotation parser or the removal of the maven-apt-plugin. The annotation parser [job](https://builds.apache.org/view/S-Z/view/Struts/job/struts-annotations/) is disabled. Using a snapshot version of the annotation processor will fail the build. It might be easier for you to coordinate changes to both repositories.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org