You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "xiaoxiang781216 (via GitHub)" <gi...@apache.org> on 2023/07/20 16:33:32 UTC
[GitHub] [nuttx] xiaoxiang781216 opened a new pull request, #9863: sched: Remove the unnecessary DEBUG_TCBINFO option
xiaoxiang781216 opened a new pull request, #9863:
URL: https://github.com/apache/nuttx/pull/9863
## Summary
since the linker can remove g_tcbinfo, if no code really reference it
## Impact
gdb debugging
## Testing
ci
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 commented on pull request #9863: sched: Remove the unnecessary DEBUG_TCBINFO option
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on PR #9863:
URL: https://github.com/apache/nuttx/pull/9863#issuecomment-1648373675
> > @Ouss4 , @gustavonihei I think you both wrote/worked this/in file (arch/xtensa/src/common/xtensa_tcbinfo.c)
>
> The point that @xiaoxiang781216 is making is that the are just data definitions in a static library. It doesn't need to be built conditionally because it will not be drawn into the build from the library if it is not referenced by anything. Nothing else is changed.
>
> There are a few additional changes here that don't related to the title or description.
>
> * Corrects a register name
These changes are moved to https://github.com/apache/nuttx/pull/9859.
> * Removes TCB_STACK_OFF and TCB_STACK_SIZE_OFF (unused?)
Good catch! it's fixed by https://github.com/apache/nuttx/pull/9878. Both fields are used to support TRACE32 thread awareness debugging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] patacongo commented on pull request #9863: sched: Remove the unnecessary DEBUG_TCBINFO option
Posted by "patacongo (via GitHub)" <gi...@apache.org>.
patacongo commented on PR #9863:
URL: https://github.com/apache/nuttx/pull/9863#issuecomment-1646944183
> @Ouss4 , @gustavonihei I think you both wrote/worked this/in file (arch/xtensa/src/common/xtensa_tcbinfo.c)
The point that @xiaoxiang781216 is making is that the are just data definitions in a static library. It doesn't need to be built conditionally because it will not be drawn into the build from the library if it is not referenced by anything. Nothing else is changed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] jerpelea merged pull request #9863: sched: Rename DEBUG_TCBINFO to ARCH_HAVE_TCBINFO
Posted by "jerpelea (via GitHub)" <gi...@apache.org>.
jerpelea merged PR #9863:
URL: https://github.com/apache/nuttx/pull/9863
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] acassis commented on pull request #9863: sched: Remove the unnecessary DEBUG_TCBINFO option
Posted by "acassis (via GitHub)" <gi...@apache.org>.
acassis commented on PR #9863:
URL: https://github.com/apache/nuttx/pull/9863#issuecomment-1646939744
@Ouss4 , @gustavonihei I think you both wrote/worked this/in file
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 commented on pull request #9863: sched: Remove the unnecessary DEBUG_TCBINFO option
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on PR #9863:
URL: https://github.com/apache/nuttx/pull/9863#issuecomment-1648375656
> > @Ouss4 , @gustavonihei I think you both wrote/worked this/in file (arch/xtensa/src/common/xtensa_tcbinfo.c)
>
> The point that @xiaoxiang781216 is making is that the are just data definitions in a static library. It doesn't need to be built conditionally because it will not be drawn into the build from the library if it is not referenced by anything. Nothing else is changed.
>
> There are a few additional changes here that don't related to the title or description.
>
> * Corrects a register name
These changes are moved to https://github.com/apache/nuttx/pull/9859.
> * Removes TCB_STACK_OFF and TCB_STACK_SIZE_OFF (unused?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org