You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by Sun Dapeng <da...@intel.com> on 2014/09/24 03:42:14 UTC
Review Request 25977: SENTRY-456 Service discovery for SENTRY high
availability
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25977/
-----------------------------------------------------------
Review request for sentry, Arun Suresh, Prasad Mujumdar, and Sravya Tirukkovalur.
Bugs: SENTRY-456
https://issues.apache.org/jira/browse/SENTRY-456
Repository: sentry
Description
-------
* Add curator dependence in pom.xml.
* HAContext is used for Store HAContext related configuration
* ServiceManager is used for get avaliable service from Zookeeper
* ServiceRegister is used for register current service to Zookeeper
Diffs
-----
pom.xml e172e92
sentry-provider/sentry-provider-db/pom.xml b4167e4
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/FixedJsonInstanceSerializer.java PRE-CREATION
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/HAContext.java PRE-CREATION
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/ServiceManager.java PRE-CREATION
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/ServiceRegister.java PRE-CREATION
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/ServiceConstants.java 52eaeed
sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryServiceDiscovery.java PRE-CREATION
Diff: https://reviews.apache.org/r/25977/diff/
Testing
-------
* TestSentryServiceDiscovery.java is the Unit Test
* Other Unit Test passed in local environment
Thanks,
Sun Dapeng
Re: Review Request 25977: SENTRY-456 Service discovery for SENTRY high
availability
Posted by Prasad Mujumdar <pr...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25977/#review60742
-----------------------------------------------------------
Ship it!
- Prasad Mujumdar
On Oct. 27, 2014, 6:29 a.m., Dapeng Sun wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25977/
> -----------------------------------------------------------
>
> (Updated Oct. 27, 2014, 6:29 a.m.)
>
>
> Review request for sentry, Arun Suresh, Lenni Kuff, Prasad Mujumdar, and Sravya Tirukkovalur.
>
>
> Bugs: SENTRY-456
> https://issues.apache.org/jira/browse/SENTRY-456
>
>
> Repository: sentry
>
>
> Description
> -------
>
> * Add curator dependence in pom.xml.
> * HAContext is used for Store HAContext related configuration
> * ServiceManager is used for get avaliable service from Zookeeper
> * ServiceRegister is used for register current service to Zookeeper
>
>
> Diffs
> -----
>
> pom.xml e172e92
> sentry-provider/sentry-provider-db/pom.xml b4167e4
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/FixedJsonInstanceSerializer.java PRE-CREATION
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/HAContext.java PRE-CREATION
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/ServiceManager.java PRE-CREATION
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/ServiceRegister.java PRE-CREATION
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/ServiceConstants.java 52eaeed
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryServiceDiscovery.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/25977/diff/
>
>
> Testing
> -------
>
> * TestSentryServiceDiscovery.java is the Unit Test
> * Other Unit Test passed in local environment
>
>
> Thanks,
>
> Dapeng Sun
>
>
Re: Review Request 25977: SENTRY-456 Service discovery for SENTRY high
availability
Posted by Arun Suresh <ar...@gmail.com>.
> On Nov. 11, 2014, 5:04 a.m., Arun Suresh wrote:
> > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/HAContext.java, line 55
> > <https://reviews.apache.org/r/25977/diff/1/?file=703987#file703987line55>
> >
> > I Apologize for the late review.. But... this might not work with a Secure Zookeeper cluster..
> >
> > You would need to provide an ACLProvider implementation and set it in the builder using the .aclProvider(..) method.
> >
> > For pointers on how to set the ACL provider, you might want to check out how its being used in some of the hadoop classes (Specifically ZKDelegationTokenSecretManager : https://github.com/apache/hadoop/blob/8a261e68e4177b47be01ceae7310ea56aeb7ca38/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/token/delegation/ZKDelegationTokenSecretManager.java)
Aah.. Just noticed the SENTRY-459 JIRA...
Feel free to drop this.. thanks
- Arun
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25977/#review60748
-----------------------------------------------------------
On Oct. 27, 2014, 6:29 a.m., Dapeng Sun wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25977/
> -----------------------------------------------------------
>
> (Updated Oct. 27, 2014, 6:29 a.m.)
>
>
> Review request for sentry, Arun Suresh, Lenni Kuff, Prasad Mujumdar, and Sravya Tirukkovalur.
>
>
> Bugs: SENTRY-456
> https://issues.apache.org/jira/browse/SENTRY-456
>
>
> Repository: sentry
>
>
> Description
> -------
>
> * Add curator dependence in pom.xml.
> * HAContext is used for Store HAContext related configuration
> * ServiceManager is used for get avaliable service from Zookeeper
> * ServiceRegister is used for register current service to Zookeeper
>
>
> Diffs
> -----
>
> pom.xml e172e92
> sentry-provider/sentry-provider-db/pom.xml b4167e4
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/FixedJsonInstanceSerializer.java PRE-CREATION
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/HAContext.java PRE-CREATION
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/ServiceManager.java PRE-CREATION
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/ServiceRegister.java PRE-CREATION
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/ServiceConstants.java 52eaeed
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryServiceDiscovery.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/25977/diff/
>
>
> Testing
> -------
>
> * TestSentryServiceDiscovery.java is the Unit Test
> * Other Unit Test passed in local environment
>
>
> Thanks,
>
> Dapeng Sun
>
>
Re: Review Request 25977: SENTRY-456 Service discovery for SENTRY high
availability
Posted by Dapeng Sun <da...@intel.com>.
> On 十一月 11, 2014, 1:04 p.m., Arun Suresh wrote:
> > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/HAContext.java, line 55
> > <https://reviews.apache.org/r/25977/diff/1/?file=703987#file703987line55>
> >
> > I Apologize for the late review.. But... this might not work with a Secure Zookeeper cluster..
> >
> > You would need to provide an ACLProvider implementation and set it in the builder using the .aclProvider(..) method.
> >
> > For pointers on how to set the ACL provider, you might want to check out how its being used in some of the hadoop classes (Specifically ZKDelegationTokenSecretManager : https://github.com/apache/hadoop/blob/8a261e68e4177b47be01ceae7310ea56aeb7ca38/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/token/delegation/ZKDelegationTokenSecretManager.java)
>
> Arun Suresh wrote:
> Aah.. Just noticed the SENTRY-459 JIRA...
> Feel free to drop this.. thanks
Hi, Arun, thank you for your review, I knew you are focus on another big feature. I will look into **ZKDelegationTokenSecretManager**.
Feel free to comment, if you have time :)
- Dapeng
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25977/#review60748
-----------------------------------------------------------
On 十月 27, 2014, 2:29 p.m., Dapeng Sun wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25977/
> -----------------------------------------------------------
>
> (Updated 十月 27, 2014, 2:29 p.m.)
>
>
> Review request for sentry, Arun Suresh, Lenni Kuff, Prasad Mujumdar, and Sravya Tirukkovalur.
>
>
> Bugs: SENTRY-456
> https://issues.apache.org/jira/browse/SENTRY-456
>
>
> Repository: sentry
>
>
> Description
> -------
>
> * Add curator dependence in pom.xml.
> * HAContext is used for Store HAContext related configuration
> * ServiceManager is used for get avaliable service from Zookeeper
> * ServiceRegister is used for register current service to Zookeeper
>
>
> Diffs
> -----
>
> pom.xml e172e92
> sentry-provider/sentry-provider-db/pom.xml b4167e4
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/FixedJsonInstanceSerializer.java PRE-CREATION
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/HAContext.java PRE-CREATION
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/ServiceManager.java PRE-CREATION
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/ServiceRegister.java PRE-CREATION
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/ServiceConstants.java 52eaeed
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryServiceDiscovery.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/25977/diff/
>
>
> Testing
> -------
>
> * TestSentryServiceDiscovery.java is the Unit Test
> * Other Unit Test passed in local environment
>
>
> Thanks,
>
> Dapeng Sun
>
>
Re: Review Request 25977: SENTRY-456 Service discovery for SENTRY high
availability
Posted by Arun Suresh <ar...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25977/#review60748
-----------------------------------------------------------
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/HAContext.java
<https://reviews.apache.org/r/25977/#comment102148>
I Apologize for the late review.. But... this might not work with a Secure Zookeeper cluster..
You would need to provide an ACLProvider implementation and set it in the builder using the .aclProvider(..) method.
For pointers on how to set the ACL provider, you might want to check out how its being used in some of the hadoop classes (Specifically ZKDelegationTokenSecretManager : https://github.com/apache/hadoop/blob/8a261e68e4177b47be01ceae7310ea56aeb7ca38/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/token/delegation/ZKDelegationTokenSecretManager.java)
- Arun Suresh
On Oct. 27, 2014, 6:29 a.m., Dapeng Sun wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25977/
> -----------------------------------------------------------
>
> (Updated Oct. 27, 2014, 6:29 a.m.)
>
>
> Review request for sentry, Arun Suresh, Lenni Kuff, Prasad Mujumdar, and Sravya Tirukkovalur.
>
>
> Bugs: SENTRY-456
> https://issues.apache.org/jira/browse/SENTRY-456
>
>
> Repository: sentry
>
>
> Description
> -------
>
> * Add curator dependence in pom.xml.
> * HAContext is used for Store HAContext related configuration
> * ServiceManager is used for get avaliable service from Zookeeper
> * ServiceRegister is used for register current service to Zookeeper
>
>
> Diffs
> -----
>
> pom.xml e172e92
> sentry-provider/sentry-provider-db/pom.xml b4167e4
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/FixedJsonInstanceSerializer.java PRE-CREATION
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/HAContext.java PRE-CREATION
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/ServiceManager.java PRE-CREATION
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/ServiceRegister.java PRE-CREATION
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/ServiceConstants.java 52eaeed
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryServiceDiscovery.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/25977/diff/
>
>
> Testing
> -------
>
> * TestSentryServiceDiscovery.java is the Unit Test
> * Other Unit Test passed in local environment
>
>
> Thanks,
>
> Dapeng Sun
>
>
Re: Review Request 25977: SENTRY-456 Service discovery for SENTRY high
availability
Posted by Sun Dapeng <da...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25977/
-----------------------------------------------------------
(Updated 十月 27, 2014, 2:29 p.m.)
Review request for sentry, Arun Suresh, Lenni Kuff, Prasad Mujumdar, and Sravya Tirukkovalur.
Changes
-------
Update patch according Prasad's comments, thank Prasad
Bugs: SENTRY-456
https://issues.apache.org/jira/browse/SENTRY-456
Repository: sentry
Description
-------
* Add curator dependence in pom.xml.
* HAContext is used for Store HAContext related configuration
* ServiceManager is used for get avaliable service from Zookeeper
* ServiceRegister is used for register current service to Zookeeper
Diffs (updated)
-----
pom.xml e172e92
sentry-provider/sentry-provider-db/pom.xml b4167e4
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/FixedJsonInstanceSerializer.java PRE-CREATION
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/HAContext.java PRE-CREATION
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/ServiceManager.java PRE-CREATION
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/ServiceRegister.java PRE-CREATION
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/ServiceConstants.java 52eaeed
sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryServiceDiscovery.java PRE-CREATION
Diff: https://reviews.apache.org/r/25977/diff/
Testing
-------
* TestSentryServiceDiscovery.java is the Unit Test
* Other Unit Test passed in local environment
Thanks,
Sun Dapeng
Re: Review Request 25977: SENTRY-456 Service discovery for SENTRY high
availability
Posted by Sun Dapeng <da...@intel.com>.
> On 十月 21, 2014, 8:24 a.m., Prasad Mujumdar wrote:
> > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/ServiceConstants.java, line 107
> > <https://reviews.apache.org/r/25977/diff/1/?file=703990#file703990line107>
> >
> > Nit: It would be better to define the common tags like namespace in a single place
Okay, good suggestion.
> On 十月 21, 2014, 8:24 a.m., Prasad Mujumdar wrote:
> > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryServiceDiscovery.java, line 106
> > <https://reviews.apache.org/r/25977/diff/1/?file=703991#file703991line106>
> >
> > The test is registering 3 services and calling getServiceInstance() 4 times.
Thank Prasad, I will change it, but it's okay actually, serviceInstance will always is service map.
- Sun
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25977/#review57467
-----------------------------------------------------------
On 十月 27, 2014, 2:29 p.m., Sun Dapeng wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25977/
> -----------------------------------------------------------
>
> (Updated 十月 27, 2014, 2:29 p.m.)
>
>
> Review request for sentry, Arun Suresh, Lenni Kuff, Prasad Mujumdar, and Sravya Tirukkovalur.
>
>
> Bugs: SENTRY-456
> https://issues.apache.org/jira/browse/SENTRY-456
>
>
> Repository: sentry
>
>
> Description
> -------
>
> * Add curator dependence in pom.xml.
> * HAContext is used for Store HAContext related configuration
> * ServiceManager is used for get avaliable service from Zookeeper
> * ServiceRegister is used for register current service to Zookeeper
>
>
> Diffs
> -----
>
> pom.xml e172e92
> sentry-provider/sentry-provider-db/pom.xml b4167e4
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/FixedJsonInstanceSerializer.java PRE-CREATION
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/HAContext.java PRE-CREATION
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/ServiceManager.java PRE-CREATION
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/ServiceRegister.java PRE-CREATION
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/ServiceConstants.java 52eaeed
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryServiceDiscovery.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/25977/diff/
>
>
> Testing
> -------
>
> * TestSentryServiceDiscovery.java is the Unit Test
> * Other Unit Test passed in local environment
>
>
> Thanks,
>
> Sun Dapeng
>
>
Re: Review Request 25977: SENTRY-456 Service discovery for SENTRY high
availability
Posted by Prasad Mujumdar <pr...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25977/#review57467
-----------------------------------------------------------
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/ServiceConstants.java
<https://reviews.apache.org/r/25977/#comment98171>
Nit: It would be better to define the common tags like namespace in a single place
sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryServiceDiscovery.java
<https://reviews.apache.org/r/25977/#comment98178>
The test is registering 3 services and calling getServiceInstance() 4 times.
- Prasad Mujumdar
On Oct. 9, 2014, 5:45 a.m., Sun Dapeng wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25977/
> -----------------------------------------------------------
>
> (Updated Oct. 9, 2014, 5:45 a.m.)
>
>
> Review request for sentry, Arun Suresh, Lenni Kuff, Prasad Mujumdar, and Sravya Tirukkovalur.
>
>
> Bugs: SENTRY-456
> https://issues.apache.org/jira/browse/SENTRY-456
>
>
> Repository: sentry
>
>
> Description
> -------
>
> * Add curator dependence in pom.xml.
> * HAContext is used for Store HAContext related configuration
> * ServiceManager is used for get avaliable service from Zookeeper
> * ServiceRegister is used for register current service to Zookeeper
>
>
> Diffs
> -----
>
> pom.xml e172e92
> sentry-provider/sentry-provider-db/pom.xml b4167e4
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/FixedJsonInstanceSerializer.java PRE-CREATION
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/HAContext.java PRE-CREATION
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/ServiceManager.java PRE-CREATION
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/ServiceRegister.java PRE-CREATION
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/ServiceConstants.java 52eaeed
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryServiceDiscovery.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/25977/diff/
>
>
> Testing
> -------
>
> * TestSentryServiceDiscovery.java is the Unit Test
> * Other Unit Test passed in local environment
>
>
> Thanks,
>
> Sun Dapeng
>
>
Re: Review Request 25977: SENTRY-456 Service discovery for SENTRY high
availability
Posted by Sun Dapeng <da...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25977/
-----------------------------------------------------------
(Updated 十月 9, 2014, 1:45 p.m.)
Review request for sentry, Arun Suresh, Lenni Kuff, Prasad Mujumdar, and Sravya Tirukkovalur.
Changes
-------
Add Lenni.
Bugs: SENTRY-456
https://issues.apache.org/jira/browse/SENTRY-456
Repository: sentry
Description
-------
* Add curator dependence in pom.xml.
* HAContext is used for Store HAContext related configuration
* ServiceManager is used for get avaliable service from Zookeeper
* ServiceRegister is used for register current service to Zookeeper
Diffs
-----
pom.xml e172e92
sentry-provider/sentry-provider-db/pom.xml b4167e4
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/FixedJsonInstanceSerializer.java PRE-CREATION
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/HAContext.java PRE-CREATION
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/ServiceManager.java PRE-CREATION
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/ServiceRegister.java PRE-CREATION
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/ServiceConstants.java 52eaeed
sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryServiceDiscovery.java PRE-CREATION
Diff: https://reviews.apache.org/r/25977/diff/
Testing
-------
* TestSentryServiceDiscovery.java is the Unit Test
* Other Unit Test passed in local environment
Thanks,
Sun Dapeng