You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Karl Fogel <kf...@newton.ch.collab.net> on 2002/05/09 04:20:15 UTC
Re: svn commit: rev 1908 - trunk/subversion/libsvn_fs
cmpilato@tigris.org writes:
> * subversion/libsvn_fs/reps-strings.c
> (make_fulltext_rep): Omigosh. Nobody saw that happen, right? :-)
> Actually use the mutability state dictated by the caller...
>
> Modified: trunk/subversion/libsvn_fs/reps-strings.c
> ==============================================================================
> --- trunk/subversion/libsvn_fs/reps-strings.c (original)
> +++ trunk/subversion/libsvn_fs/reps-strings.c Wed May 8 14:25:14 2002
> @@ -57,7 +57,7 @@
>
> {
> svn_fs__representation_t *rep = apr_palloc (pool, sizeof (*rep));
> - rep->is_mutable = 1;
> + rep->is_mutable = mutable;
> rep->kind = svn_fs__rep_kind_fulltext;
> rep->contents.fulltext.string_key = apr_pstrdup (pool, str_key);
> return rep;
Holy cow, dude.
<karl wonders if he wrote that>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn commit: rev 1908 - trunk/subversion/libsvn_fs
Posted by cm...@collab.net.
Karl Fogel <kf...@newton.ch.collab.net> writes:
> cmpilato@tigris.org writes:
> > * subversion/libsvn_fs/reps-strings.c
> > (make_fulltext_rep): Omigosh. Nobody saw that happen, right? :-)
> > Actually use the mutability state dictated by the caller...
> >
> > Modified: trunk/subversion/libsvn_fs/reps-strings.c
> > ==============================================================================
> > --- trunk/subversion/libsvn_fs/reps-strings.c (original)
> > +++ trunk/subversion/libsvn_fs/reps-strings.c Wed May 8 14:25:14 2002
> > @@ -57,7 +57,7 @@
> >
> > {
> > svn_fs__representation_t *rep = apr_palloc (pool, sizeof (*rep));
> > - rep->is_mutable = 1;
> > + rep->is_mutable = mutable;
> > rep->kind = svn_fs__rep_kind_fulltext;
> > rep->contents.fulltext.string_key = apr_pstrdup (pool, str_key);
> > return rep;
>
> Holy cow, dude.
>
> <karl wonders if he wrote that>
No, pretty sure that was me doing the skel conversion. When
converting this function, my brain was thinking it was named
`make_mutable_rep' instead of `make_fulltext_rep'. In fact, this
mixing up of mutability and fulltextiness plagued the whole
conversion, though most of the instances were finalized correctly.
This case, however, was missed.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org