You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@arrow.apache.org by "Wes McKinney (JIRA)" <ji...@apache.org> on 2017/08/23 02:43:00 UTC

[jira] [Created] (ARROW-1402) [C++] Possibly deprecate public APIs that use MutableBuffer

Wes McKinney created ARROW-1402:
-----------------------------------

             Summary: [C++] Possibly deprecate public APIs that use MutableBuffer
                 Key: ARROW-1402
                 URL: https://issues.apache.org/jira/browse/ARROW-1402
             Project: Apache Arrow
          Issue Type: Improvement
          Components: C++
            Reporter: Wes McKinney
             Fix For: 0.7.0


I am not sure it is useful to expose {{arrow::MutableBuffer}} as the out argument in functions like {{arrow::AllocateBuffer}}. See e.g. http://arrow.apache.org/docs/cpp/namespacearrow.html#a4e4daf985e41d6879c9dbb0131157c51

In my experience this is more of a nuisance than anything, as mutability is a dynamic property of buffers (we have {{buffer->is_mutable()}} on base instances). If we were doing a lot of compile time reasoning about buffers, that would be a different story, but we are not. 

I don't think we should nix the MutableBuffer class, just return pointers to base from functions. We can still get it back with {{std::dynamic_pointer_cast}}. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)