You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "Frun1na (via GitHub)" <gi...@apache.org> on 2026/09/22 12:19:47 UTC

[PR] fix(web): keep the pending question when the run was never admitted [rocketmq-dashboard]

Frun1na opened a new pull request, #4921:
URL: https://github.com/apache/rocketmq-dashboard/pull/4921

   ### Which Issue(s) This PR Fixes
   
   - Fixes #(issue to be linked)
   
   ### Brief Description
   
   `finishStream` cleared `pendingUserMessage` unconditionally after a successful timeline refetch. The refetch succeeding does not imply the transcript gained the user row: when the stream failed **before** the `run_started` frame (connection refused, 401, 409 from a second tab) the run was never admitted, so clearing the optimistic copy made the operator's question vanish without a trace. The hook now tracks admission via the `run_started` frame and only drops the pending bubble when the run was admitted (or the stream ended cleanly). The code's own comment already stated the invariant - "the transcript never got the row" - but the refetch-success branch did not honour it.
   
   ### How Did You Test This Change?
   
   ```
   cd web && npx vitest run src/pages/ai/hooks/useAgentRun.test.ts
   
   Test Files  1 passed (1)
        Tests  16 passed (16)
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix(web): keep the pending question when the run was never admitted [rocketmq-dashboard]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #4921: fix(web): keep the pending question when the run was never admitted
URL: https://github.com/apache/rocketmq-dashboard/pull/4921


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix(web): keep the pending question when the run was never admitted [rocketmq-dashboard]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #4921:
URL: https://github.com/apache/rocketmq-dashboard/pull/4921#issuecomment-5901568276

   This pull request has been automatically closed because there has been no activity for 7 days. If you would like to continue working on this, please reopen the PR with updated changes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org