You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Niklas Nielsen <ni...@qni.dk> on 2015/06/04 19:42:43 UTC

Review Request 35079: Added wrapper header for mesos/slave/oversubscription.pb.h

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35079/
-----------------------------------------------------------

Review request for mesos and Jie Yu.


Repository: mesos


Description
-------

Added wrapper header for mesos/slave/oversubscription.pb.h


Diffs
-----

  include/mesos/slave/oversubscription.hpp PRE-CREATION 

Diff: https://reviews.apache.org/r/35079/diff/


Testing
-------


Thanks,

Niklas Nielsen


Re: Review Request 35079: Added wrapper header for mesos/slave/oversubscription.pb.h

Posted by Niklas Nielsen <ni...@qni.dk>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35079/
-----------------------------------------------------------

(Updated June 4, 2015, 2:28 p.m.)


Review request for mesos and Jie Yu.


Changes
-------

Addressed Jie's comments


Repository: mesos


Description
-------

Added wrapper header for mesos/slave/oversubscription.pb.h


Diffs (updated)
-----

  include/mesos/slave/oversubscription.hpp PRE-CREATION 
  src/Makefile.am cc3d2e60fe2bb2b78ca93dd05dbf004a049c4aa5 

Diff: https://reviews.apache.org/r/35079/diff/


Testing
-------


Thanks,

Niklas Nielsen


Re: Review Request 35079: Added wrapper header for mesos/slave/oversubscription.pb.h

Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35079/#review86676
-----------------------------------------------------------

Ship it!



include/mesos/slave/oversubscription.hpp
<https://reviews.apache.org/r/35079/#comment138739>

    `__SLAVE_OVERSUBSCRIPTION_PROTO_HPP__`


- Jie Yu


On June 4, 2015, 5:42 p.m., Niklas Nielsen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35079/
> -----------------------------------------------------------
> 
> (Updated June 4, 2015, 5:42 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added wrapper header for mesos/slave/oversubscription.pb.h
> 
> 
> Diffs
> -----
> 
>   include/mesos/slave/oversubscription.hpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/35079/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Niklas Nielsen
> 
>