You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Dmitro Lisnichenko <dl...@hortonworks.com> on 2014/11/24 21:50:25 UTC

Review Request 28405: Distribute Repositories/Install Components - server part

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28405/
-----------------------------------------------------------

Review request for Ambari, Alejandro Fernandez, Nate Cole, and Yurii Shylov.


Bugs: AMBARI-8434
    https://issues.apache.org/jira/browse/AMBARI-8434


Repository: ambari


Description
-------

Preview version of patch. 


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterStackVersionService.java ed94877 
  ambari-server/src/main/java/org/apache/ambari/server/api/services/HostStackVersionService.java 86a00a8 
  ambari-server/src/main/java/org/apache/ambari/server/api/services/RequestService.java fc1b515 
  ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementController.java 5af88a8 
  ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 8f90cf4 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java 0fc590e 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/DefaultProviderModule.java d0ce1cf 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProvider.java 67e62d7 
  ambari-server/src/main/java/org/apache/ambari/server/controller/spi/ResourceProvider.java de1c9dd 
  ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/RepositoryVersionHelper.java PRE-CREATION 
  ambari-server/src/main/java/org/apache/ambari/server/state/RepositoryVersionData.java PRE-CREATION 
  ambari-server/src/main/resources/custom_actions/scripts/install_packages.py 850f079 
  ambari-server/src/test/java/org/apache/ambari/server/controller/utilities/RepositoryVersionHelperTest.java PRE-CREATION 

Diff: https://reviews.apache.org/r/28405/diff/


Testing
-------

manual verification on 2-node cluster

proper unit test coverage is pending


Thanks,

Dmitro Lisnichenko

Re: Review Request 28405: Distribute Repositories/Install Components - server part

Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28405/#review63005
-----------------------------------------------------------



ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java
<https://reviews.apache.org/r/28405/#comment105182>

    Small typo in "Cannot"



ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProvider.java
<https://reviews.apache.org/r/28405/#comment105183>

    Perhaps this should be a different exception.


- Alejandro Fernandez


On Nov. 24, 2014, 8:50 p.m., Dmitro Lisnichenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28405/
> -----------------------------------------------------------
> 
> (Updated Nov. 24, 2014, 8:50 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Nate Cole, and Yurii Shylov.
> 
> 
> Bugs: AMBARI-8434
>     https://issues.apache.org/jira/browse/AMBARI-8434
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Preview version of patch. 
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterStackVersionService.java ed94877 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/HostStackVersionService.java 86a00a8 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/RequestService.java fc1b515 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementController.java 5af88a8 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 8f90cf4 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java 0fc590e 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/DefaultProviderModule.java d0ce1cf 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProvider.java 67e62d7 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/spi/ResourceProvider.java de1c9dd 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/RepositoryVersionHelper.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/state/RepositoryVersionData.java PRE-CREATION 
>   ambari-server/src/main/resources/custom_actions/scripts/install_packages.py 850f079 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/utilities/RepositoryVersionHelperTest.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/28405/diff/
> 
> 
> Testing
> -------
> 
> manual verification on 2-node cluster
> 
> proper unit test coverage is pending
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>

Re: Review Request 28405: Distribute Repositories/Install Components - server part

Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.

> On Nov. 25, 2014, 4:53 p.m., Nate Cole wrote:
> > Looks good to me - I'm assuming this will work parallel across all hosts?

yes, every host gets his own configuration and all actions are performed in parallel within the same stage


- Dmitro


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28405/#review62998
-----------------------------------------------------------


On Nov. 24, 2014, 8:50 p.m., Dmitro Lisnichenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28405/
> -----------------------------------------------------------
> 
> (Updated Nov. 24, 2014, 8:50 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Nate Cole, and Yurii Shylov.
> 
> 
> Bugs: AMBARI-8434
>     https://issues.apache.org/jira/browse/AMBARI-8434
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Preview version of patch. 
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterStackVersionService.java ed94877 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/HostStackVersionService.java 86a00a8 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/RequestService.java fc1b515 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementController.java 5af88a8 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 8f90cf4 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java 0fc590e 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/DefaultProviderModule.java d0ce1cf 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProvider.java 67e62d7 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/spi/ResourceProvider.java de1c9dd 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/RepositoryVersionHelper.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/state/RepositoryVersionData.java PRE-CREATION 
>   ambari-server/src/main/resources/custom_actions/scripts/install_packages.py 850f079 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/utilities/RepositoryVersionHelperTest.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/28405/diff/
> 
> 
> Testing
> -------
> 
> manual verification on 2-node cluster
> 
> proper unit test coverage is pending
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>

Re: Review Request 28405: Distribute Repositories/Install Components - server part

Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28405/#review62998
-----------------------------------------------------------

Ship it!


Looks good to me - I'm assuming this will work parallel across all hosts?


ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java
<https://reviews.apache.org/r/28405/#comment105169>

    No sysout here.


- Nate Cole


On Nov. 24, 2014, 3:50 p.m., Dmitro Lisnichenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28405/
> -----------------------------------------------------------
> 
> (Updated Nov. 24, 2014, 3:50 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Nate Cole, and Yurii Shylov.
> 
> 
> Bugs: AMBARI-8434
>     https://issues.apache.org/jira/browse/AMBARI-8434
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Preview version of patch. 
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterStackVersionService.java ed94877 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/HostStackVersionService.java 86a00a8 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/RequestService.java fc1b515 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementController.java 5af88a8 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 8f90cf4 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java 0fc590e 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/DefaultProviderModule.java d0ce1cf 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProvider.java 67e62d7 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/spi/ResourceProvider.java de1c9dd 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/RepositoryVersionHelper.java PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/state/RepositoryVersionData.java PRE-CREATION 
>   ambari-server/src/main/resources/custom_actions/scripts/install_packages.py 850f079 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/utilities/RepositoryVersionHelperTest.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/28405/diff/
> 
> 
> Testing
> -------
> 
> manual verification on 2-node cluster
> 
> proper unit test coverage is pending
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>

Re: Review Request 28405: Distribute Repositories/Install Components - server part

Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28405/#review63248
-----------------------------------------------------------


wrong patch

- Dmitro Lisnichenko


On Nov. 27, 2014, 8:20 p.m., Dmitro Lisnichenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28405/
> -----------------------------------------------------------
> 
> (Updated Nov. 27, 2014, 8:20 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Nate Cole, and Yurii Shylov.
> 
> 
> Bugs: AMBARI-8434
>     https://issues.apache.org/jira/browse/AMBARI-8434
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Preview version of patch. 
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProvider.java 67e62d7 
> 
> Diff: https://reviews.apache.org/r/28405/diff/
> 
> 
> Testing
> -------
> 
> manual verification on 2-node cluster
> 
> proper unit test coverage is pending
> 
> 
> File Attachments
> ----------------
> 
> patch_27.11
>   https://reviews.apache.org/media/uploaded/files/2014/11/27/3565983c-b9ec-4dc4-94de-cd0b875ccdc4__a2.patch
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>

Re: Review Request 28405: Distribute Repositories/Install Components - server part

Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28405/#review63670
-----------------------------------------------------------

Ship it!


Ship It!

- Nate Cole


On Dec. 3, 2014, 8:55 a.m., Dmitro Lisnichenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28405/
> -----------------------------------------------------------
> 
> (Updated Dec. 3, 2014, 8:55 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Nate Cole, and Yurii Shylov.
> 
> 
> Bugs: AMBARI-8434
>     https://issues.apache.org/jira/browse/AMBARI-8434
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Distribute Repositories/Install Components API
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterStackVersionService.java ed94877 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/HostService.java c4ad169 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/HostStackVersionService.java 86a00a8 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/RequestService.java 95d8963 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementController.java a1ece2c 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 0e65a1d 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java da05edf 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java 0fc590e 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/DefaultProviderModule.java 698737b 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProvider.java 67e62d7 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/spi/NoSuchParentResourceException.java 308841f 
>   ambari-server/src/main/resources/custom_actions/scripts/install_packages.py 850f079 
>   ambari-server/src/test/java/org/apache/ambari/server/api/services/HostStackVersionServiceTest.java 960a485 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java 75e0868 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProviderTest.java PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProviderTest.java PRE-CREATION 
>   ambari-server/src/test/python/custom_actions/TestInstallPackages.py 51fc9e1 
>   ambari-server/src/test/python/custom_actions/configs/install_packages_config.json 1055a40 
> 
> Diff: https://reviews.apache.org/r/28405/diff/
> 
> 
> Testing
> -------
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Ambari Views ...................................... SUCCESS [3.774s]
> [INFO] Ambari Server ..................................... SUCCESS [29:53.751s]
> [INFO] Ambari Agent ...................................... SUCCESS [7.372s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 30:05.984s
> [INFO] Finished at: Wed Dec 03 14:53:41 FET 2014
> [INFO] Final Memory: 25M/189M
> [INFO] ------------------------------------------------------------------------
> 
> 
> File Attachments
> ----------------
> 
> patch_27.11
>   https://reviews.apache.org/media/uploaded/files/2014/11/27/3565983c-b9ec-4dc4-94de-cd0b875ccdc4__a2.patch
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>

Re: Review Request 28405: Distribute Repositories/Install Components - server part

Posted by Vitalyi Brodetskyi <vb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28405/#review63671
-----------------------------------------------------------

Ship it!


Ship It!

- Vitalyi Brodetskyi


On Гру. 3, 2014, 1:55 після полудня, Dmitro Lisnichenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28405/
> -----------------------------------------------------------
> 
> (Updated Гру. 3, 2014, 1:55 після полудня)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Nate Cole, and Yurii Shylov.
> 
> 
> Bugs: AMBARI-8434
>     https://issues.apache.org/jira/browse/AMBARI-8434
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Distribute Repositories/Install Components API
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterStackVersionService.java ed94877 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/HostService.java c4ad169 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/HostStackVersionService.java 86a00a8 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/RequestService.java 95d8963 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementController.java a1ece2c 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 0e65a1d 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java da05edf 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java 0fc590e 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/DefaultProviderModule.java 698737b 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProvider.java 67e62d7 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/spi/NoSuchParentResourceException.java 308841f 
>   ambari-server/src/main/resources/custom_actions/scripts/install_packages.py 850f079 
>   ambari-server/src/test/java/org/apache/ambari/server/api/services/HostStackVersionServiceTest.java 960a485 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java 75e0868 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProviderTest.java PRE-CREATION 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProviderTest.java PRE-CREATION 
>   ambari-server/src/test/python/custom_actions/TestInstallPackages.py 51fc9e1 
>   ambari-server/src/test/python/custom_actions/configs/install_packages_config.json 1055a40 
> 
> Diff: https://reviews.apache.org/r/28405/diff/
> 
> 
> Testing
> -------
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Ambari Views ...................................... SUCCESS [3.774s]
> [INFO] Ambari Server ..................................... SUCCESS [29:53.751s]
> [INFO] Ambari Agent ...................................... SUCCESS [7.372s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 30:05.984s
> [INFO] Finished at: Wed Dec 03 14:53:41 FET 2014
> [INFO] Final Memory: 25M/189M
> [INFO] ------------------------------------------------------------------------
> 
> 
> File Attachments
> ----------------
> 
> patch_27.11
>   https://reviews.apache.org/media/uploaded/files/2014/11/27/3565983c-b9ec-4dc4-94de-cd0b875ccdc4__a2.patch
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>

Re: Review Request 28405: Distribute Repositories/Install Components - server part

Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28405/
-----------------------------------------------------------

(Updated Dec. 3, 2014, 1:55 p.m.)


Review request for Ambari, Alejandro Fernandez, Nate Cole, and Yurii Shylov.


Bugs: AMBARI-8434
    https://issues.apache.org/jira/browse/AMBARI-8434


Repository: ambari


Description (updated)
-------

Distribute Repositories/Install Components API


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterStackVersionService.java ed94877 
  ambari-server/src/main/java/org/apache/ambari/server/api/services/HostService.java c4ad169 
  ambari-server/src/main/java/org/apache/ambari/server/api/services/HostStackVersionService.java 86a00a8 
  ambari-server/src/main/java/org/apache/ambari/server/api/services/RequestService.java 95d8963 
  ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementController.java a1ece2c 
  ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 0e65a1d 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java da05edf 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java 0fc590e 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/DefaultProviderModule.java 698737b 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProvider.java 67e62d7 
  ambari-server/src/main/java/org/apache/ambari/server/controller/spi/NoSuchParentResourceException.java 308841f 
  ambari-server/src/main/resources/custom_actions/scripts/install_packages.py 850f079 
  ambari-server/src/test/java/org/apache/ambari/server/api/services/HostStackVersionServiceTest.java 960a485 
  ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java 75e0868 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProviderTest.java PRE-CREATION 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProviderTest.java PRE-CREATION 
  ambari-server/src/test/python/custom_actions/TestInstallPackages.py 51fc9e1 
  ambari-server/src/test/python/custom_actions/configs/install_packages_config.json 1055a40 

Diff: https://reviews.apache.org/r/28405/diff/


Testing
-------

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO] 
[INFO] Ambari Views ...................................... SUCCESS [3.774s]
[INFO] Ambari Server ..................................... SUCCESS [29:53.751s]
[INFO] Ambari Agent ...................................... SUCCESS [7.372s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 30:05.984s
[INFO] Finished at: Wed Dec 03 14:53:41 FET 2014
[INFO] Final Memory: 25M/189M
[INFO] ------------------------------------------------------------------------


File Attachments
----------------

patch_27.11
  https://reviews.apache.org/media/uploaded/files/2014/11/27/3565983c-b9ec-4dc4-94de-cd0b875ccdc4__a2.patch


Thanks,

Dmitro Lisnichenko

Re: Review Request 28405: Distribute Repositories/Install Components - server part

Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28405/
-----------------------------------------------------------

(Updated Dec. 3, 2014, 1:54 p.m.)


Review request for Ambari, Alejandro Fernandez, Nate Cole, and Yurii Shylov.


Bugs: AMBARI-8434
    https://issues.apache.org/jira/browse/AMBARI-8434


Repository: ambari


Description
-------

Preview version of patch. 


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterStackVersionService.java ed94877 
  ambari-server/src/main/java/org/apache/ambari/server/api/services/HostService.java c4ad169 
  ambari-server/src/main/java/org/apache/ambari/server/api/services/HostStackVersionService.java 86a00a8 
  ambari-server/src/main/java/org/apache/ambari/server/api/services/RequestService.java 95d8963 
  ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementController.java a1ece2c 
  ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 0e65a1d 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java da05edf 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java 0fc590e 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/DefaultProviderModule.java 698737b 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProvider.java 67e62d7 
  ambari-server/src/main/java/org/apache/ambari/server/controller/spi/NoSuchParentResourceException.java 308841f 
  ambari-server/src/main/resources/custom_actions/scripts/install_packages.py 850f079 
  ambari-server/src/test/java/org/apache/ambari/server/api/services/HostStackVersionServiceTest.java 960a485 
  ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java 75e0868 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProviderTest.java PRE-CREATION 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProviderTest.java PRE-CREATION 
  ambari-server/src/test/python/custom_actions/TestInstallPackages.py 51fc9e1 
  ambari-server/src/test/python/custom_actions/configs/install_packages_config.json 1055a40 

Diff: https://reviews.apache.org/r/28405/diff/


Testing (updated)
-------

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO] 
[INFO] Ambari Views ...................................... SUCCESS [3.774s]
[INFO] Ambari Server ..................................... SUCCESS [29:53.751s]
[INFO] Ambari Agent ...................................... SUCCESS [7.372s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 30:05.984s
[INFO] Finished at: Wed Dec 03 14:53:41 FET 2014
[INFO] Final Memory: 25M/189M
[INFO] ------------------------------------------------------------------------


File Attachments
----------------

patch_27.11
  https://reviews.apache.org/media/uploaded/files/2014/11/27/3565983c-b9ec-4dc4-94de-cd0b875ccdc4__a2.patch


Thanks,

Dmitro Lisnichenko

Re: Review Request 28405: Distribute Repositories/Install Components - server part

Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28405/
-----------------------------------------------------------

(Updated Dec. 2, 2014, 8:46 p.m.)


Review request for Ambari, Alejandro Fernandez, Nate Cole, and Yurii Shylov.


Changes
-------

Uploaded patch that applies on top of Yuriy's latest patch.


Bugs: AMBARI-8434
    https://issues.apache.org/jira/browse/AMBARI-8434


Repository: ambari


Description
-------

Preview version of patch. 


Diffs (updated)
-----

  ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterStackVersionService.java ed94877 
  ambari-server/src/main/java/org/apache/ambari/server/api/services/HostService.java c4ad169 
  ambari-server/src/main/java/org/apache/ambari/server/api/services/HostStackVersionService.java 86a00a8 
  ambari-server/src/main/java/org/apache/ambari/server/api/services/RequestService.java 95d8963 
  ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementController.java a1ece2c 
  ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 0e65a1d 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java da05edf 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java 0fc590e 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/DefaultProviderModule.java 698737b 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProvider.java 67e62d7 
  ambari-server/src/main/java/org/apache/ambari/server/controller/spi/NoSuchParentResourceException.java 308841f 
  ambari-server/src/main/resources/custom_actions/scripts/install_packages.py 850f079 
  ambari-server/src/test/java/org/apache/ambari/server/api/services/HostStackVersionServiceTest.java 960a485 
  ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java 75e0868 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProviderTest.java PRE-CREATION 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProviderTest.java PRE-CREATION 
  ambari-server/src/test/python/custom_actions/TestInstallPackages.py 51fc9e1 
  ambari-server/src/test/python/custom_actions/configs/install_packages_config.json 1055a40 

Diff: https://reviews.apache.org/r/28405/diff/


Testing
-------

manual verification on 2-node cluster


File Attachments
----------------

patch_27.11
  https://reviews.apache.org/media/uploaded/files/2014/11/27/3565983c-b9ec-4dc4-94de-cd0b875ccdc4__a2.patch


Thanks,

Dmitro Lisnichenko

Re: Review Request 28405: Distribute Repositories/Install Components - server part

Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28405/
-----------------------------------------------------------

(Updated Dec. 2, 2014, 3:46 p.m.)


Review request for Ambari, Alejandro Fernandez, Nate Cole, and Yurii Shylov.


Changes
-------

Uploaded patch that applies on top of Yuriy's latest patch.
My patch is not final (discussed current design with UI team, they need another workflow).


Bugs: AMBARI-8434
    https://issues.apache.org/jira/browse/AMBARI-8434


Repository: ambari


Description
-------

Preview version of patch. 


Diffs (updated)
-----

  ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterStackVersionService.java ed94877 
  ambari-server/src/main/java/org/apache/ambari/server/api/services/HostService.java c4ad169 
  ambari-server/src/main/java/org/apache/ambari/server/api/services/HostStackVersionService.java 86a00a8 
  ambari-server/src/main/java/org/apache/ambari/server/api/services/RequestService.java 95d8963 
  ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementController.java a1ece2c 
  ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 0e65a1d 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java da05edf 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java 0fc590e 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/DefaultProviderModule.java 83f0e0f 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProvider.java 67e62d7 
  ambari-server/src/main/java/org/apache/ambari/server/controller/spi/NoSuchParentResourceException.java 308841f 
  ambari-server/src/main/java/org/apache/ambari/server/controller/spi/ResourceProvider.java de1c9dd 
  ambari-server/src/main/resources/custom_actions/scripts/install_packages.py 850f079 
  ambari-server/src/test/java/org/apache/ambari/server/api/services/HostStackVersionServiceTest.java 960a485 
  ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java 75e0868 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProviderTest.java PRE-CREATION 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProviderTest.java PRE-CREATION 
  ambari-server/src/test/python/custom_actions/TestInstallPackages.py 51fc9e1 
  ambari-server/src/test/python/custom_actions/configs/install_packages_config.json 1055a40 

Diff: https://reviews.apache.org/r/28405/diff/


Testing
-------

manual verification on 2-node cluster


File Attachments
----------------

patch_27.11
  https://reviews.apache.org/media/uploaded/files/2014/11/27/3565983c-b9ec-4dc4-94de-cd0b875ccdc4__a2.patch


Thanks,

Dmitro Lisnichenko

Re: Review Request 28405: Distribute Repositories/Install Components - server part

Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28405/
-----------------------------------------------------------

(Updated Nov. 28, 2014, 6:07 p.m.)


Review request for Ambari, Alejandro Fernandez, Nate Cole, and Yurii Shylov.


Changes
-------

Patch is covered with unit tests. 

Waiting for Yuriy's patch to double-check and commit.


Bugs: AMBARI-8434
    https://issues.apache.org/jira/browse/AMBARI-8434


Repository: ambari


Description
-------

Preview version of patch. 


Diffs (updated)
-----

  ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterStackVersionService.java ed94877 
  ambari-server/src/main/java/org/apache/ambari/server/api/services/HostService.java c4ad169 
  ambari-server/src/main/java/org/apache/ambari/server/api/services/HostStackVersionService.java 86a00a8 
  ambari-server/src/main/java/org/apache/ambari/server/api/services/RequestService.java 95d8963 
  ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementController.java a1ece2c 
  ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 0e65a1d 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java da05edf 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java 0fc590e 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/DefaultProviderModule.java 83f0e0f 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProvider.java 67e62d7 
  ambari-server/src/main/java/org/apache/ambari/server/controller/spi/NoSuchParentResourceException.java 308841f 
  ambari-server/src/main/java/org/apache/ambari/server/controller/spi/ResourceProvider.java de1c9dd 
  ambari-server/src/main/resources/custom_actions/scripts/install_packages.py 850f079 
  ambari-server/src/test/java/org/apache/ambari/server/api/services/HostStackVersionServiceTest.java 960a485 
  ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java 75e0868 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProviderTest.java PRE-CREATION 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProviderTest.java PRE-CREATION 
  ambari-server/src/test/python/custom_actions/TestInstallPackages.py 51fc9e1 
  ambari-server/src/test/python/custom_actions/configs/install_packages_config.json 1055a40 

Diff: https://reviews.apache.org/r/28405/diff/


Testing (updated)
-------

manual verification on 2-node cluster


File Attachments
----------------

patch_27.11
  https://reviews.apache.org/media/uploaded/files/2014/11/27/3565983c-b9ec-4dc4-94de-cd0b875ccdc4__a2.patch


Thanks,

Dmitro Lisnichenko

Re: Review Request 28405: Distribute Repositories/Install Components - server part

Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.

> On Nov. 28, 2014, 2:10 a.m., Nate Cole wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/api/services/HostStackVersionService.java, line 117
> > <https://reviews.apache.org/r/28405/diff/3/?file=777883#file777883line117>
> >
> >     What about if just this.clusterName == null?

I've used another class as an example. Your suggestion is good, will fix both classes.


- Dmitro


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28405/#review63253
-----------------------------------------------------------


On Nov. 27, 2014, 8:26 p.m., Dmitro Lisnichenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28405/
> -----------------------------------------------------------
> 
> (Updated Nov. 27, 2014, 8:26 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Nate Cole, and Yurii Shylov.
> 
> 
> Bugs: AMBARI-8434
>     https://issues.apache.org/jira/browse/AMBARI-8434
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Preview version of patch. 
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterStackVersionService.java ed94877 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/HostService.java c4ad169 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/HostStackVersionService.java 86a00a8 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/RequestService.java 95d8963 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementController.java a1ece2c 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 0e65a1d 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java 0fc590e 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/DefaultProviderModule.java 83f0e0f 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProvider.java 67e62d7 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/spi/NoSuchParentResourceException.java 308841f 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/spi/ResourceProvider.java de1c9dd 
>   ambari-server/src/main/resources/custom_actions/scripts/install_packages.py 850f079 
>   ambari-server/src/test/java/org/apache/ambari/server/api/services/HostStackVersionServiceTest.java 960a485 
>   ambari-server/src/test/python/custom_actions/TestInstallPackages.py 51fc9e1 
>   ambari-server/src/test/python/custom_actions/configs/install_packages_config.json 1055a40 
> 
> Diff: https://reviews.apache.org/r/28405/diff/
> 
> 
> Testing
> -------
> 
> manual verification on 2-node cluster
> 
> proper unit test coverage is pending
> 
> 
> File Attachments
> ----------------
> 
> patch_27.11
>   https://reviews.apache.org/media/uploaded/files/2014/11/27/3565983c-b9ec-4dc4-94de-cd0b875ccdc4__a2.patch
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>

Re: Review Request 28405: Distribute Repositories/Install Components - server part

Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28405/#review63253
-----------------------------------------------------------

Ship it!


Looks good.  If this is dependent on another review, please coordinate to make sure tests pass.  We can't have a broken trunk.  We can live (for now) without new tests, but we sure can't break existing ones.


ambari-server/src/main/java/org/apache/ambari/server/api/services/HostStackVersionService.java
<https://reviews.apache.org/r/28405/#comment105427>

    What about if just this.clusterName == null?


- Nate Cole


On Nov. 27, 2014, 3:26 p.m., Dmitro Lisnichenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28405/
> -----------------------------------------------------------
> 
> (Updated Nov. 27, 2014, 3:26 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Nate Cole, and Yurii Shylov.
> 
> 
> Bugs: AMBARI-8434
>     https://issues.apache.org/jira/browse/AMBARI-8434
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Preview version of patch. 
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterStackVersionService.java ed94877 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/HostService.java c4ad169 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/HostStackVersionService.java 86a00a8 
>   ambari-server/src/main/java/org/apache/ambari/server/api/services/RequestService.java 95d8963 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementController.java a1ece2c 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 0e65a1d 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java 0fc590e 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/DefaultProviderModule.java 83f0e0f 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProvider.java 67e62d7 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/spi/NoSuchParentResourceException.java 308841f 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/spi/ResourceProvider.java de1c9dd 
>   ambari-server/src/main/resources/custom_actions/scripts/install_packages.py 850f079 
>   ambari-server/src/test/java/org/apache/ambari/server/api/services/HostStackVersionServiceTest.java 960a485 
>   ambari-server/src/test/python/custom_actions/TestInstallPackages.py 51fc9e1 
>   ambari-server/src/test/python/custom_actions/configs/install_packages_config.json 1055a40 
> 
> Diff: https://reviews.apache.org/r/28405/diff/
> 
> 
> Testing
> -------
> 
> manual verification on 2-node cluster
> 
> proper unit test coverage is pending
> 
> 
> File Attachments
> ----------------
> 
> patch_27.11
>   https://reviews.apache.org/media/uploaded/files/2014/11/27/3565983c-b9ec-4dc4-94de-cd0b875ccdc4__a2.patch
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>

Re: Review Request 28405: Distribute Repositories/Install Components - server part

Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28405/
-----------------------------------------------------------

(Updated Nov. 27, 2014, 8:26 p.m.)


Review request for Ambari, Alejandro Fernandez, Nate Cole, and Yurii Shylov.


Changes
-------

correct patch.


Bugs: AMBARI-8434
    https://issues.apache.org/jira/browse/AMBARI-8434


Repository: ambari


Description
-------

Preview version of patch. 


Diffs (updated)
-----

  ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterStackVersionService.java ed94877 
  ambari-server/src/main/java/org/apache/ambari/server/api/services/HostService.java c4ad169 
  ambari-server/src/main/java/org/apache/ambari/server/api/services/HostStackVersionService.java 86a00a8 
  ambari-server/src/main/java/org/apache/ambari/server/api/services/RequestService.java 95d8963 
  ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementController.java a1ece2c 
  ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 0e65a1d 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java 0fc590e 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/DefaultProviderModule.java 83f0e0f 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProvider.java 67e62d7 
  ambari-server/src/main/java/org/apache/ambari/server/controller/spi/NoSuchParentResourceException.java 308841f 
  ambari-server/src/main/java/org/apache/ambari/server/controller/spi/ResourceProvider.java de1c9dd 
  ambari-server/src/main/resources/custom_actions/scripts/install_packages.py 850f079 
  ambari-server/src/test/java/org/apache/ambari/server/api/services/HostStackVersionServiceTest.java 960a485 
  ambari-server/src/test/python/custom_actions/TestInstallPackages.py 51fc9e1 
  ambari-server/src/test/python/custom_actions/configs/install_packages_config.json 1055a40 

Diff: https://reviews.apache.org/r/28405/diff/


Testing
-------

manual verification on 2-node cluster

proper unit test coverage is pending


File Attachments
----------------

patch_27.11
  https://reviews.apache.org/media/uploaded/files/2014/11/27/3565983c-b9ec-4dc4-94de-cd0b875ccdc4__a2.patch


Thanks,

Dmitro Lisnichenko

Re: Review Request 28405: Distribute Repositories/Install Components - server part

Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28405/
-----------------------------------------------------------

(Updated Nov. 27, 2014, 8:20 p.m.)


Review request for Ambari, Alejandro Fernandez, Nate Cole, and Yurii Shylov.


Changes
-------

Attached my patch as is since reviewboard seems to be not able to apply it correctly. 
Should be applied on top of Yuriy's patch


Bugs: AMBARI-8434
    https://issues.apache.org/jira/browse/AMBARI-8434


Repository: ambari


Description
-------

Preview version of patch. 


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProvider.java 67e62d7 

Diff: https://reviews.apache.org/r/28405/diff/


Testing
-------

manual verification on 2-node cluster

proper unit test coverage is pending


File Attachments (updated)
----------------

patch_27.11
  https://reviews.apache.org/media/uploaded/files/2014/11/27/3565983c-b9ec-4dc4-94de-cd0b875ccdc4__a2.patch


Thanks,

Dmitro Lisnichenko

Re: Review Request 28405: Distribute Repositories/Install Components - server part

Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28405/
-----------------------------------------------------------

(Updated Nov. 27, 2014, 8:17 p.m.)


Review request for Ambari, Alejandro Fernandez, Nate Cole, and Yurii Shylov.


Changes
-------

E2E tested version that works with Yuriy's patch. Still not final version (dealing with unit tests). May be used by UI team for testing


Bugs: AMBARI-8434
    https://issues.apache.org/jira/browse/AMBARI-8434


Repository: ambari


Description
-------

Preview version of patch. 


Diffs (updated)
-----

  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProvider.java 67e62d7 

Diff: https://reviews.apache.org/r/28405/diff/


Testing
-------

manual verification on 2-node cluster

proper unit test coverage is pending


Thanks,

Dmitro Lisnichenko