You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pivot.apache.org by "Roger Whitcomb (JIRA)" <ji...@apache.org> on 2019/06/05 17:58:00 UTC

[jira] [Commented] (PIVOT-1044) Avoid using FileInputStream / FileOutputStream to avoid GC issues with finalizer

    [ https://issues.apache.org/jira/browse/PIVOT-1044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16856920#comment-16856920 ] 

Roger Whitcomb commented on PIVOT-1044:
---------------------------------------

Fixed the "core" (that is, non-demo or non-tutorial) classes:

Sending core\src\org\apache\pivot\io\FileSerializer.java
Sending web-server\src\org\apache\pivot\web\server\QueryServlet.java
Transmitting file data ..done
Committing transaction...
Committed revision 1860673.

> Avoid using FileInputStream / FileOutputStream to avoid GC issues with finalizer
> --------------------------------------------------------------------------------
>
>                 Key: PIVOT-1044
>                 URL: https://issues.apache.org/jira/browse/PIVOT-1044
>             Project: Pivot
>          Issue Type: Improvement
>          Components: core, web
>            Reporter: Roger Whitcomb
>            Assignee: Roger Whitcomb
>            Priority: Minor
>             Fix For: 2.1.0
>
>
> From this blog post (and similar) ([https://www.cloudbees.com/blog/fileinputstream-fileoutputstream-considered-harmful)] as well as pending changes to Ant ([https://github.com/apache/ant/pull/77)] it seems wise to change these uses, which are just in a couple of places:  FileSerializer and QueryServlet (and some demos, but those don't seem as important as "core" classes).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)