You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2020/05/04 22:09:22 UTC
[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #5328: Fix the bug introduced in #5132 where ScanBasedDocIdIterator.isMatch() is still required
Jackie-Jiang commented on a change in pull request #5328:
URL: https://github.com/apache/incubator-pinot/pull/5328#discussion_r419758565
##########
File path: pinot-core/src/main/java/org/apache/pinot/core/operator/dociditerators/AndDocIdIterator.java
##########
@@ -102,6 +102,17 @@ public int next() {
i = -1;
}
}
+ if (hasScanBasedIterators && i == docIdIterators.length - 1) {
+ // this means we found the docId common to all nonScanBased iterators, now we need to ensure
+ // that its also found in scanBasedIterator, if not matched, we restart the intersection
+ for (ScanBasedDocIdIterator iterator : scanBasedDocIdIterators) {
+ if (!iterator.isMatch(currentMax)) {
+ i = -1;
Review comment:
@mcvsubbu Planning to do some clean-up in the following pr. Wanted to keep this pr small and focus on the bug fix.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org