You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/03/07 20:35:12 UTC

[GitHub] [incubator-nuttx] robin-raymond opened a new issue #483: usbhost/usbhost_xboxcontroller.c compilation error

robin-raymond opened a new issue #483: usbhost/usbhost_xboxcontroller.c compilation error
URL: https://github.com/apache/incubator-nuttx/issues/483
 
 
   ````
   CC:  usbhost/usbhost_xboxcontroller.c
   usbhost/usbhost_xboxcontroller.c: In function 'usbhost_notify':
   usbhost/usbhost_xboxcontroller.c:561:36: error: 'struct usbhost_state_s' has no member named 'fds'
          FAR struct pollfd *fds = priv->fds[i];
                                       ^~
   usbhost/usbhost_xboxcontroller.c: In function 'usbhost_poll':
   usbhost/usbhost_xboxcontroller.c:2136:20: error: 'struct usbhost_state_s' has no member named 'fds'
              if (!priv->fds[i])
                       ^~
   usbhost/usbhost_xboxcontroller.c:2140:19: error: 'struct usbhost_state_s' has no member named 'fds'
                  priv->fds[i] = fds;
                      ^~
   usbhost/usbhost_xboxcontroller.c:2141:35: error: 'struct usbhost_state_s' has no member named 'fds'
                  fds->priv    = &priv->fds[i];
                                      ^~
   usbhost/usbhost_xboxcontroller.c:2159:11: warning: implicit declaration of function 'usbhost_pollnotify' [-Wimplicit-function-declaration]
              usbhost_pollnotify(priv);
              ^~~~~~~~~~~~~~~~~~
   ````
   
   Think it's missing:
   
   ````
     /* The following is a list if poll structures of threads waiting for
      * driver events. The 'struct pollfd' reference for each open is also
      * retained in the f_priv field of the 'struct file'.
      */
   
     struct pollfd *fds[CONFIG_HIDMOUSE_NPOLLWAITERS];
   ````
   
   inside `struct usbhost_state_s`
   
   But I'm not entirely sure if that's the right fix.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] patacongo closed issue #483: usbhost/usbhost_xboxcontroller.c compilation error

Posted by GitBox <gi...@apache.org>.
patacongo closed issue #483: usbhost/usbhost_xboxcontroller.c compilation error
URL: https://github.com/apache/incubator-nuttx/issues/483
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] robin-raymond edited a comment on issue #483: usbhost/usbhost_xboxcontroller.c compilation error

Posted by GitBox <gi...@apache.org>.
robin-raymond edited a comment on issue #483: usbhost/usbhost_xboxcontroller.c compilation error
URL: https://github.com/apache/incubator-nuttx/issues/483#issuecomment-596135364
 
 
   related -- I think a forward declaration is missing:
   ````
   static void usbhost_pollnotify(FAR struct usbhost_state_s *dev);
   ````
   
   (and implementation)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] robin-raymond commented on issue #483: usbhost/usbhost_xboxcontroller.c compilation error

Posted by GitBox <gi...@apache.org>.
robin-raymond commented on issue #483: usbhost/usbhost_xboxcontroller.c compilation error
URL: https://github.com/apache/incubator-nuttx/issues/483#issuecomment-596135364
 
 
   related -- I think a forward declaration is missing:
   ````
   static void usbhost_pollnotify(FAR struct usbhost_state_s *dev);
   ````
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] patacongo commented on issue #483: usbhost/usbhost_xboxcontroller.c compilation error

Posted by GitBox <gi...@apache.org>.
patacongo commented on issue #483: usbhost/usbhost_xboxcontroller.c compilation error
URL: https://github.com/apache/incubator-nuttx/issues/483#issuecomment-596142974
 
 
   Resolved with PR #485 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] acassis commented on issue #483: usbhost/usbhost_xboxcontroller.c compilation error

Posted by GitBox <gi...@apache.org>.
acassis commented on issue #483: usbhost/usbhost_xboxcontroller.c compilation error
URL: https://github.com/apache/incubator-nuttx/issues/483#issuecomment-596137660
 
 
   Hi Robin,
   I think you fix is fine, could you please submit a PR ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services