You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "LuciferYang (via GitHub)" <gi...@apache.org> on 2023/10/16 03:28:57 UTC
[PR] [SPARK-44619][INFRA][3.5] Free up disk space for container jobs [spark]
LuciferYang opened a new pull request, #43381:
URL: https://github.com/apache/spark/pull/43381
### What changes were proposed in this pull request?
Free up disk space for container jobs
### Why are the changes needed?
increase the available disk space
before this PR
after this PR
### Does this PR introduce _any_ user-facing change?
No, infra-only
### How was this patch tested?
updated CI
### Was this patch authored or co-authored using generative AI tooling?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-44619][INFRA][3.5] Free up disk space for container jobs [spark]
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on PR #43381:
URL: https://github.com/apache/spark/pull/43381#issuecomment-1763672247
https://github.com/apache/spark/actions/runs/6510937376
found `No space left on device` log on branch-3.5 ci:
<img width="1234" alt="image" src="https://github.com/apache/spark/assets/1475305/5777d152-68cd-4995-840b-ff8561062e86">
<img width="1267" alt="image" src="https://github.com/apache/spark/assets/1475305/0acaa85c-b916-4b02-8e24-5e5cc04fc07e">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-44619][INFRA][3.5] Free up disk space for container jobs [spark]
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on code in PR #43381:
URL: https://github.com/apache/spark/pull/43381#discussion_r1360065756
##########
.github/workflows/build_and_test.yml:
##########
@@ -407,6 +407,8 @@ jobs:
key: pyspark-coursier-${{ hashFiles('**/pom.xml', '**/plugins.sbt') }}
restore-keys: |
pyspark-coursier-
+ - name: Free up disk space
Review Comment:
shall we add a condition?
```
if [ -f ./dev/free_disk_space_container ]; then
./dev/free_disk_space_container
fi
```
since this might be also used in 3.4?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-44619][INFRA][3.5] Free up disk space for container jobs [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on code in PR #43381:
URL: https://github.com/apache/spark/pull/43381#discussion_r1360082517
##########
.github/workflows/build_and_test.yml:
##########
@@ -407,6 +407,8 @@ jobs:
key: pyspark-coursier-${{ hashFiles('**/pom.xml', '**/plugins.sbt') }}
restore-keys: |
pyspark-coursier-
+ - name: Free up disk space
Review Comment:
The current `build_and_test.yml` is for individual branch (when a commit is arrived, and the job is triggered).
The confusion is from the fact that we share the same `build_and_test.yml` in the `master` branch for scheduled jobs in other branches (e.g., https://github.com/apache/spark/actions/workflows/build_branch34.yml).
Scheduled jobs use the one in the `master` branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-44619][INFRA][3.5] Free up disk space for container jobs [spark]
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on code in PR #43381:
URL: https://github.com/apache/spark/pull/43381#discussion_r1360066932
##########
.github/workflows/build_and_test.yml:
##########
@@ -407,6 +407,8 @@ jobs:
key: pyspark-coursier-${{ hashFiles('**/pom.xml', '**/plugins.sbt') }}
restore-keys: |
pyspark-coursier-
+ - name: Free up disk space
Review Comment:
hmmm, I am confused now. ignore ^^^ if it doesn't break anything.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-44619][INFRA][3.5] Free up disk space for container jobs [spark]
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang closed pull request #43381: [SPARK-44619][INFRA][3.5] Free up disk space for container jobs
URL: https://github.com/apache/spark/pull/43381
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-44619][INFRA][3.5] Free up disk space for container jobs [spark]
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on code in PR #43381:
URL: https://github.com/apache/spark/pull/43381#discussion_r1360066949
##########
.github/workflows/build_and_test.yml:
##########
@@ -407,6 +407,8 @@ jobs:
key: pyspark-coursier-${{ hashFiles('**/pom.xml', '**/plugins.sbt') }}
restore-keys: |
pyspark-coursier-
+ - name: Free up disk space
Review Comment:
I think it's unnecessary, this yml file won't be used by other branches.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-44619][INFRA][3.5] Free up disk space for container jobs [spark]
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on PR #43381:
URL: https://github.com/apache/spark/pull/43381#issuecomment-1764072144
Merged into branch-3.5. Thanks @zhengruifeng @LuciferYang @yaooqinn @beliefer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-44619][INFRA][3.5] Free up disk space for container jobs [spark]
Posted by "beliefer (via GitHub)" <gi...@apache.org>.
beliefer commented on PR #43381:
URL: https://github.com/apache/spark/pull/43381#issuecomment-1764076016
@LuciferYang Thank you. I retriggered GA for https://github.com/apache/spark/pull/43330
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-44619][INFRA][3.5] Free up disk space for container jobs [spark]
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on PR #43381:
URL: https://github.com/apache/spark/pull/43381#issuecomment-1764046181
<img width="1212" alt="image" src="https://github.com/apache/spark/assets/1475305/a2502e0d-0fbc-46c4-8f8f-7da5eb92a73c">
GA passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org