You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2019/11/22 17:57:27 UTC

[GitHub] [helix] narendly commented on issue #629: Add close() to ClusterSetup to avoid ZkClient leak

narendly commented on issue #629: Add close() to ClusterSetup to avoid ZkClient leak
URL: https://github.com/apache/helix/pull/629#issuecomment-557630849
 
 
   This PR is ready to be merged, approved by @lei-xia.
   
   "ClusterSetup is a helper class that's used for cluster-related operations. This class is missing a close() method users could call to prevent ZkClient/ZkConnection leak. This commit adds close() method."

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org