You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by vmakhaev <gi...@git.apache.org> on 2015/10/02 01:52:33 UTC
[GitHub] incubator-zeppelin pull request: Send back message with note data ...
GitHub user vmakhaev opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/332
Send back message with note data on create and clone
We use web-socket api for creating and cloning notes from our servers. To know noteId of created or cloned note, we need some response message. I propose sending NOTE message to client on creating/cloning note.
There could be other ways to reach it. For example, we can send newId and note for creation an id, name, newId for cloning. If newId is not exists, we generate it on server.
Another way will be to create separate api for this, to not mix this with front-end api. It could be REST or smth.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/vmakhaev/incubator-zeppelin master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-zeppelin/pull/332.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #332
----
commit f846eb00c28a5884e9fb05e26e5b2fad813ce723
Author: vmakhaev <vm...@gmail.com>
Date: 2015-10-01T23:36:43Z
Send back message with note data on create and clone
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Send back message with note data ...
Posted by nberserk <gi...@git.apache.org>.
Github user nberserk commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/332#issuecomment-145049779
@eranwitkon i also interested to design/implement that service.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Send back message with note data ...
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/332#issuecomment-144899696
Hi @vmakhaev ,
Can you explain what you try to achieve in this PR?
The title and description are telling different things, also the current description of this PR is what is already happening in Zeppelin.
If you have an improvement/feature in mind and a use-case as example, it could help us guide you
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Send back message with note data ...
Posted by vmakhaev <gi...@git.apache.org>.
Github user vmakhaev commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/332#issuecomment-145048314
Yes, please. CRUD and clone will be enough for the beginning. If you need anything from me, let me know.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Send back message with note data ...
Posted by vmakhaev <gi...@git.apache.org>.
Github user vmakhaev commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/332#issuecomment-145027589
The problem is to know id of just created Note (or just cloned Note).
In our case, we store metadata (Note ids and names) in our databases and create/clone Notes with websocket api. You can create Note with whatever name you like, but id will be generated in Zeppelin and will not be return somehow.
At the moment the only option is to get list of notes before creating one and after creating, make diff and find new just created Note with it's id.
Hope it makes it more clear.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Send back message with note data ...
Posted by vmakhaev <gi...@git.apache.org>.
Github user vmakhaev closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/332
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Send back message with note data ...
Posted by eranwitkon <gi...@git.apache.org>.
Github user eranwitkon commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/332#issuecomment-145045031
I don't know what was the original intent for separating the API between socket API and REST API but to me socket API are more internal and less descriptive then REST\JSON API.
If we see a need for people to interact from external application with Zeppelin server we should provide them with a REST API and keep it stable as much as possible.
If needed I can do it for the above services.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Send back message with note data ...
Posted by eranwitkon <gi...@git.apache.org>.
Github user eranwitkon commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/332#issuecomment-145060183
@nberserk No problem, it wasn't my intention to hijack this PR.
Can you open a JIRA ticket for this and we will start the work from it.
Also, please advise on what is the best way to do it together...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---