You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@opendal.apache.org by "wcy-fdu (via GitHub)" <gi...@apache.org> on 2023/04/27 13:47:04 UTC
[GitHub] [incubator-opendal] wcy-fdu commented on a diff in pull request #2142: feat(services/gcs): support batch delete for gcs
wcy-fdu commented on code in PR #2142:
URL: https://github.com/apache/incubator-opendal/pull/2142#discussion_r1179186997
##########
core/src/services/gcs/backend.rs:
##########
@@ -501,6 +503,52 @@ impl Accessor for GcsBackend {
GcsPager::new(self.core.clone(), path, "", args.limit()),
))
}
+ async fn batch(&self, args: OpBatch) -> Result<RpBatch> {
+ let ops = args.into_operation();
+ if ops.len() > 99 {
Review Comment:
>You should not include more than 100 calls in a single batch request.
Not sure whether batch request itself is included, so in case, 99 means 99 delete calls and 1 batch header.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org