You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@arrow.apache.org by "Nicola Crane (Jira)" <ji...@apache.org> on 2022/01/11 15:35:00 UTC
[jira] [Commented] (ARROW-15301) [R] Discussion: reorganise the testthat test helpers
[ https://issues.apache.org/jira/browse/ARROW-15301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17472832#comment-17472832 ]
Nicola Crane commented on ARROW-15301:
--------------------------------------
I don't find them too bad, but given I wrote a load of extra documentation for some of the functions as I just couldn't understand the whole lot in the first place, I'm probably not the best person to ask here ;)
One thing I'll say is that I don't think there's necessarily a need to know about all the custom expectations until you need to use them, and can do so by analogy; I'm a committer and have written a fair few bindings but am unaware of at least half of those custom expectations as I've never needed them.
All that said, *if* there's no negative consequences of doing so, I don't see the harm in reorganising things here though, and am in favour of things that'll make life easier for new contributors regardless.
> [R] Discussion: reorganise the testthat test helpers
> -----------------------------------------------------
>
> Key: ARROW-15301
> URL: https://issues.apache.org/jira/browse/ARROW-15301
> Project: Apache Arrow
> Issue Type: Improvement
> Components: R
> Reporter: Dragoș Moldovan-Grünfeld
> Priority: Major
> Fix For: 8.0.0
>
>
> Would it make sense to have all custom expectations in {{R/}} , maybe {{R/test-helpers.R}} ? Reasons: * easier for newbies to read a file and figure out what custom testthat helpers we have
> * easier to document
> * respects the testthat author's suggestion to have them there
> Currently we have 17 different custom expectations, all defined in different files.
> A follow-up thought: maybe move all helpers there ({{{}is.{}}}, {{{}as_{}}}, {{{}compare_{}}}, {{verify}} etc).
--
This message was sent by Atlassian Jira
(v8.20.1#820001)