[GitHub] [incubator-doris] gaodayue commented on a change in pull request #3025: Restructure storage type to support complex types expending

[GitBox <gi...@apache.org>]

gaodayue commented on a change in pull request #3025: Restructure storage type to support complex types expending
URL: https://github.com/apache/incubator-doris/pull/3025#discussion_r394093086
 
 

 ##########
 File path: be/src/olap/CMakeLists.txt
 ##########
 @@ -113,4 +113,7 @@ add_library(Olap STATIC
     task/engine_publish_version_task.cpp
     task/engine_alter_tablet_task.cpp
     olap_snapshot_converter.cpp
+    collection.h
+    column_vector.h
 
 Review comment:
   there is no need to put header file here, it's implicitly included by cpp file

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org