[GitHub] eric-haibin-lin commented on a change in pull request #13409: Fix shape inference problems in Activation backward

[GitBox <gi...@apache.org>]

eric-haibin-lin commented on a change in pull request #13409: Fix shape inference problems in Activation backward
URL: https://github.com/apache/incubator-mxnet/pull/13409#discussion_r236848009
 
 

 ##########
 File path: src/operator/elemwise_op_common.h
 ##########
 @@ -128,29 +128,33 @@ inline bool ElemwiseAttr(const nnvm::NodeAttrs& attrs,
   if (n_out != -1)
     out_size = static_cast<size_t>(n_out);
 
-  auto deduce = [&](std::vector<AttrType> *vec, size_t size, const char *name) {
 
 Review comment:
   Can we revert this change? The common practice is that if we change the elements in the vector, we will use pointer instead of const reference.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services