You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "massucattoj (via GitHub)" <gi...@apache.org> on 2026/01/13 15:54:45 UTC
[PR] fix(config): add iframe support to HTML_SANITIZATION_SCHEMA_EXTENSIONS [superset]
massucattoj opened a new pull request, #37104:
URL: https://github.com/apache/superset/pull/37104
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
### SUMMARY
Adds an example configuration for `HTML_SANITIZATION_SCHEMA_EXTENSIONS` in the development config to allow iframe embedding in Markdown components and Handlebars charts.
By default, Superset's HTML sanitization (using GitHub's schema via `rehype-sanitize`) strips iframe tags for security reasons. This prevents users from embedding content like YouTube videos in dashboard Markdown components, even when specifying width/height attributes.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
- The **BEFORE** is nothing. Markdown and Handlebars are ignoring the iframe tag.
https://github.com/user-attachments/assets/0e468770-75ae-405a-9171-5da886ac321d
https://github.com/user-attachments/assets/7bbd2b15-8a7c-4f73-b48b-182dcbd1522d
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
First scenario: Adding iframe to Dashboard markdown content
1. In shell, Navigate to Dashboards
2. Select to create / edit a dashboard
3. Add a markdown component
4. Copy the iframe code of a youtube video (from share > embed option)
5. Paste the iframe code to the Dashboard and save
6. Notice the video will fill the entire markdown area
7. Try editing the dashboard and changing the width or the height of the video
8. Notice the changes **NOW** make effect into the Dashboard
Second scenario: Adding Iframe to a Handlebar chart
1. In shell navigate to database connections
2. Connect to a new Google Sheet and paste the following sheet: https://docs.google.com/spreadsheets/d/1O4wGQUgiSgMlAdyg7YJebl3NZpAgx4GTUfhwjZXHAWI/edit?gid=0#gid=0
3. Save
4. Navigate to Datasets
5. Add a new Dataset for the connected Google sheet
6. Click to save and create a new chart
7. Change chart type to Handlebar
8. Go to Customize and add this piece of code on template
```
<ul>
{{#each data}}
<li><iframe
width="560"
height="315"
src="{{url}}"
title="Video"
frameborder="0"
allow="accelerometer; autoplay; clipboard-write; encrypted-media; gyroscope;
picture-in-picture; web-share"
referrerpolicy="strict-origin-when-cross-origin"
allowfullscreen>
</iframe></li>
{{/each}}
</ul>
```
9. All should work as expected.
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(config): add iframe support to HTML_SANITIZATION_SCHEMA_EXTENSIONS [superset]
Posted by "msyavuz (via GitHub)" <gi...@apache.org>.
msyavuz closed pull request #37104: fix(config): add iframe support to HTML_SANITIZATION_SCHEMA_EXTENSIONS
URL: https://github.com/apache/superset/pull/37104
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(config): add iframe support to HTML_SANITIZATION_SCHEMA_EXTENSIONS [superset]
Posted by "massucattoj (via GitHub)" <gi...@apache.org>.
massucattoj commented on code in PR #37104:
URL: https://github.com/apache/superset/pull/37104#discussion_r2690258534
##########
docker/pythonpath_dev/superset_config.py:
##########
@@ -117,6 +117,27 @@ class CeleryConfig:
log_level_text = os.getenv("SUPERSET_LOG_LEVEL", "INFO")
LOG_LEVEL = getattr(logging, log_level_text.upper(), logging.INFO)
+# Allow iframes in Markdown components (for embedding YouTube videos, etc.)
+HTML_SANITIZATION_SCHEMA_EXTENSIONS = {
+ "tagNames": ["iframe"],
+ "attributes": {
+ "iframe": [
+ "src",
+ "width",
+ "height",
+ "frameborder",
+ "allow",
+ "allowfullscreen",
+ "title",
+ "referrerpolicy",
+ "sandbox",
+ ],
Review Comment:
No need.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(config): add iframe support to HTML_SANITIZATION_SCHEMA_EXTENSIONS [superset]
Posted by "codeant-ai-for-open-source[bot] (via GitHub)" <gi...@apache.org>.
codeant-ai-for-open-source[bot] commented on PR #37104:
URL: https://github.com/apache/superset/pull/37104#issuecomment-3768257267
CodeAnt AI is running Incremental review
---
### Thanks for using CodeAnt! 🎉
We're free for open-source projects. if you're enjoying it, help us grow by sharing.
[Share on X](https://twitter.com/intent/tweet?text=Just%20tried%20%40CodeAntAI%20for%20automated%20code%20review%20and%20I%27m%20impressed%21%20Free%20for%20open%20source%20with%20a%20free%20trial%20for%20private%20repos.%20Worth%20checking%20out%3A&url=https%3A//codeant.ai) ·
[Reddit](https://www.reddit.com/submit?title=Check%20out%20CodeAnt%20for%20automated%20code%20review&text=Just%20tried%20CodeAnt%20for%20automated%20code%20review%20and%20I%27m%20impressed%21%20Free%20for%20open%20source%20with%20a%20free%20trial%20for%20private%20repos.%20Worth%20checking%20out%3A%20https%3A//codeant.ai) ·
[LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcodeant.ai&mini=true&title=Check%20out%20CodeAnt%20for%20automated%20code%20review&summary=Just%20tried%20CodeAnt%20for%20automated%20code%20review%20and%20I%27m%20impressed%21%20Free%20for%20open%20source%20with%20a%20free%20trial%20for%20private%20repos)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(config): add iframe support to HTML_SANITIZATION_SCHEMA_EXTENSIONS [superset]
Posted by "codeant-ai-for-open-source[bot] (via GitHub)" <gi...@apache.org>.
codeant-ai-for-open-source[bot] commented on PR #37104:
URL: https://github.com/apache/superset/pull/37104#issuecomment-3745108105
CodeAnt AI is reviewing your PR.
---
### Thanks for using CodeAnt! 🎉
We're free for open-source projects. if you're enjoying it, help us grow by sharing.
[Share on X](https://twitter.com/intent/tweet?text=Just%20tried%20%40CodeAntAI%20for%20automated%20code%20review%20and%20I%27m%20impressed%21%20Free%20for%20open%20source%20with%20a%20free%20trial%20for%20private%20repos.%20Worth%20checking%20out%3A&url=https%3A//codeant.ai) ·
[Reddit](https://www.reddit.com/submit?title=Check%20out%20CodeAnt%20for%20automated%20code%20review&text=Just%20tried%20CodeAnt%20for%20automated%20code%20review%20and%20I%27m%20impressed%21%20Free%20for%20open%20source%20with%20a%20free%20trial%20for%20private%20repos.%20Worth%20checking%20out%3A%20https%3A//codeant.ai) ·
[LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcodeant.ai&mini=true&title=Check%20out%20CodeAnt%20for%20automated%20code%20review&summary=Just%20tried%20CodeAnt%20for%20automated%20code%20review%20and%20I%27m%20impressed%21%20Free%20for%20open%20source%20with%20a%20free%20trial%20for%20private%20repos)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(config): add iframe support to HTML_SANITIZATION_SCHEMA_EXTENSIONS [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #37104:
URL: https://github.com/apache/superset/pull/37104#issuecomment-3792222116
Not sure, but... should you just add iframe support in your config, and leave it off for the default state in off-the-shelf Superset so people don't do anything dangerous? Secure is a good default-state :D
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(config): add iframe support to HTML_SANITIZATION_SCHEMA_EXTENSIONS [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #37104:
URL: https://github.com/apache/superset/pull/37104#issuecomment-3768537297
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
<details>
<summary>
Bito Usage Guide
</summary>
**Commands**
Type the following command in the pull request comment and save the comment.
- `/review` - Manually triggers a full AI review.
- `/pause` - Pauses automatic reviews on this pull request.
- `/resume` - Resumes automatic reviews.
- `/resolve` - Marks all Bito-posted review comments as resolved.
- `/abort` - Cancels all in-progress reviews.
Refer to the <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/available-commands" target="_blank" rel="noopener noreferrer">documentation</a> for additional commands.
**Configuration**
This repository uses `Superset` You can customize the agent settings <a href="https://alpha.bito.ai/home/ai-agents/code-review-agent" target="_blank" rel="noopener noreferrer">here</a> or contact your Bito workspace admin at evan@preset.io.
**Documentation & Help**
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/getting-started/install-run-using-bito-cloud/create-or-customize-an-agent-instance" target="_blank" rel="noopener noreferrer">Customize agent settings</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/implementing-custom-code-review-rules" target="_blank" rel="noopener noreferrer">Review rules</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent" target="_blank" rel="noopener noreferrer">General documentation</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/faqs" target="_blank" rel="noopener noreferrer">FAQ</a>
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(config): add iframe support to HTML_SANITIZATION_SCHEMA_EXTENSIONS [superset]
Posted by "codeant-ai-for-open-source[bot] (via GitHub)" <gi...@apache.org>.
codeant-ai-for-open-source[bot] commented on PR #37104:
URL: https://github.com/apache/superset/pull/37104#issuecomment-3768265888
CodeAnt AI Incremental review completed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(config): add iframe support to HTML_SANITIZATION_SCHEMA_EXTENSIONS [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #37104:
URL: https://github.com/apache/superset/pull/37104#issuecomment-3745108459
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(config): add iframe support to HTML_SANITIZATION_SCHEMA_EXTENSIONS [superset]
Posted by "gabotorresruiz (via GitHub)" <gi...@apache.org>.
gabotorresruiz commented on code in PR #37104:
URL: https://github.com/apache/superset/pull/37104#discussion_r2696193789
##########
docker/pythonpath_dev/superset_config.py:
##########
@@ -117,6 +117,27 @@ class CeleryConfig:
log_level_text = os.getenv("SUPERSET_LOG_LEVEL", "INFO")
LOG_LEVEL = getattr(logging, log_level_text.upper(), logging.INFO)
+# Allow iframes in Markdown components (for embedding YouTube videos, etc.)
+HTML_SANITIZATION_SCHEMA_EXTENSIONS = {
+ "tagNames": ["iframe"],
+ "attributes": {
+ "iframe": [
+ "src",
+ "width",
+ "height",
+ "frameborder",
+ "allow",
+ "allowfullscreen",
+ "title",
+ "referrerpolicy",
+ "sandbox",
Review Comment:
Consider adding the `loading` attribute to the allowed list. This enables native lazy loading for `iframes`, which can significantly improve page performance by deferring off-screen `iframes` until the user scrolls near them.
##########
docker/pythonpath_dev/superset_config.py:
##########
@@ -117,6 +117,27 @@ class CeleryConfig:
log_level_text = os.getenv("SUPERSET_LOG_LEVEL", "INFO")
LOG_LEVEL = getattr(logging, log_level_text.upper(), logging.INFO)
+# Allow iframes in Markdown components (for embedding YouTube videos, etc.)
+HTML_SANITIZATION_SCHEMA_EXTENSIONS = {
+ "tagNames": ["iframe"],
+ "attributes": {
+ "iframe": [
+ "src",
+ "width",
+ "height",
+ "frameborder",
Review Comment:
Minor note: The `frameborder` attribute is deprecated in `HTML5` (use CSS `border: none` instead), but including it doesn't hurt for backward compatibility.
Reference: https://developer.mozilla.org/en-US/docs/Web/HTML/Reference/Elements/iframe#frameborder
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(config): add iframe support to HTML_SANITIZATION_SCHEMA_EXTENSIONS [superset]
Posted by "codeant-ai-for-open-source[bot] (via GitHub)" <gi...@apache.org>.
codeant-ai-for-open-source[bot] commented on code in PR #37104:
URL: https://github.com/apache/superset/pull/37104#discussion_r2704718006
##########
docker/pythonpath_dev/superset_config.py:
##########
@@ -117,6 +117,27 @@ class CeleryConfig:
log_level_text = os.getenv("SUPERSET_LOG_LEVEL", "INFO")
LOG_LEVEL = getattr(logging, log_level_text.upper(), logging.INFO)
+# Allow iframes in Markdown components (for embedding YouTube videos, etc.)
+HTML_SANITIZATION_SCHEMA_EXTENSIONS = {
+ "tagNames": ["iframe"],
+ "attributes": {
+ "iframe": [
+ "src",
+ "width",
+ "height",
+ "allow",
+ "allowfullscreen",
+ "title",
+ "referrerpolicy",
+ "sandbox",
+ "loading",
+ ],
+ },
+ "protocols": {
+ "src": ["https"],
Review Comment:
**Suggestion:** Security bug: the `protocols` mapping is the wrong shape for rehype-sanitize-like schemas — it maps attribute names at the top level instead of mapping by tag then attribute. As written the protocol restriction will be ignored, potentially allowing unsafe protocols (e.g. javascript:) in `iframe` `src`. Move `src` under the `iframe` key so the sanitizer can enforce allowed protocols. [security]
<details>
<summary><b>Severity Level:</b> Critical 🚨</summary>
```mdx
- ❌ Dashboard Markdown iframe XSS if unsafe protocols allowed.
- ⚠️ Chart/Handlebars embeds may accept unsafe URLs.
- ⚠️ Dev images expose permissive sanitizer configuration.
```
</details>
```suggestion
"iframe": {"src": ["https"]},
```
<details>
<summary><b>Steps of Reproduction ✅ </b></summary>
```mdx
1. Start Superset using the Docker development image that includes
docker/pythonpath_dev/superset_config.py (file present at
docker/pythonpath_dev/superset_config.py:120-139).
2. In the web UI, create or edit a Dashboard and add a Markdown component (follow PR's
"First scenario" testing instructions to reach the Markdown editor).
3. Paste an iframe with a non-HTTPS/malicious protocol, e.g. <iframe
src="javascript:alert(1)"></iframe>, into the Markdown and save the dashboard.
4. Observe whether the iframe src protocol is rejected or allowed. Because the current
config places "protocols": {"src": ["https"]} at top-level
(docker/pythonpath_dev/superset_config.py:136-138), sanitizer implementations expecting
per-tag attribute mappings may ignore it, potentially allowing the unsafe protocol to
pass.
Note: The reproduction steps use the actual config location and the Dashboard Markdown
editor entry point referenced in the PR testing instructions; the behavior depends on how
the server/frontend merges this dict into the sanitizer schema.
```
</details>
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** docker/pythonpath_dev/superset_config.py
**Line:** 137:137
**Comment:**
*Security: Security bug: the `protocols` mapping is the wrong shape for rehype-sanitize-like schemas — it maps attribute names at the top level instead of mapping by tag then attribute. As written the protocol restriction will be ignored, potentially allowing unsafe protocols (e.g. javascript:) in `iframe` `src`. Move `src` under the `iframe` key so the sanitizer can enforce allowed protocols.
Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(config): add iframe support to HTML_SANITIZATION_SCHEMA_EXTENSIONS [superset]
Posted by "codeant-ai-for-open-source[bot] (via GitHub)" <gi...@apache.org>.
codeant-ai-for-open-source[bot] commented on code in PR #37104:
URL: https://github.com/apache/superset/pull/37104#discussion_r2687038485
##########
docker/pythonpath_dev/superset_config.py:
##########
@@ -117,6 +117,27 @@ class CeleryConfig:
log_level_text = os.getenv("SUPERSET_LOG_LEVEL", "INFO")
LOG_LEVEL = getattr(logging, log_level_text.upper(), logging.INFO)
+# Allow iframes in Markdown components (for embedding YouTube videos, etc.)
+HTML_SANITIZATION_SCHEMA_EXTENSIONS = {
+ "tagNames": ["iframe"],
+ "attributes": {
+ "iframe": [
+ "src",
+ "width",
+ "height",
+ "frameborder",
+ "allow",
+ "allowfullscreen",
+ "title",
+ "referrerpolicy",
+ "sandbox",
+ ],
Review Comment:
**Suggestion:** Many embed snippets and responsive iframe wrappers rely on inline `style` attributes (for example to control max-width or aspect ratio); `style` is not currently allowed on iframes so such layout/customization will be stripped—add `style` to the allowed attributes if you expect inline styling to be preserved. [possible bug]
**Severity Level:** Critical 🚨
```suggestion
"style",
```
<details>
<summary><b>Why it matters? ⭐ </b></summary>
Many embed snippets rely on inline style for sizing/aspect-ratio; disallowing style will strip those and break common responsive embeds. Allowing 'style' in the dev schema is a reasonable functional enhancement, but it should be accompanied by CSS/value restrictions or a sanitizer that handles style safely.
</details>
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** docker/pythonpath_dev/superset_config.py
**Line:** 134:134
**Comment:**
*Possible Bug: Many embed snippets and responsive iframe wrappers rely on inline `style` attributes (for example to control max-width or aspect ratio); `style` is not currently allowed on iframes so such layout/customization will be stripped—add `style` to the allowed attributes if you expect inline styling to be preserved.
Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(config): add iframe support to HTML_SANITIZATION_SCHEMA_EXTENSIONS [superset]
Posted by "netlify[bot] (via GitHub)" <gi...@apache.org>.
netlify[bot] commented on PR #37104:
URL: https://github.com/apache/superset/pull/37104#issuecomment-3745123210
### <span aria-hidden="true">✅</span> Deploy Preview for *superset-docs-preview* ready!
| Name | Link |
|:-:|------------------------|
|<span aria-hidden="true">🔨</span> Latest commit | a12bce170caec9b296bea9bed9f2a6fb1f52ad07 |
|<span aria-hidden="true">🔍</span> Latest deploy log | https://app.netlify.com/projects/superset-docs-preview/deploys/69666ac64db90900085b85f1 |
|<span aria-hidden="true">😎</span> Deploy Preview | [https://deploy-preview-37104--superset-docs-preview.netlify.app](https://deploy-preview-37104--superset-docs-preview.netlify.app) |
|<span aria-hidden="true">📱</span> Preview on mobile | <details><summary> Toggle QR Code... </summary><br /><br /><br /><br />_Use your smartphone camera to open QR code link._</details> |
---
<!-- [superset-docs-preview Preview](https://deploy-preview-37104--superset-docs-preview.netlify.app) -->
_To edit notification comments on pull requests, go to your [Netlify project configuration](https://app.netlify.com/projects/superset-docs-preview/configuration/notifications#deploy-notifications)._
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(config): add iframe support to HTML_SANITIZATION_SCHEMA_EXTENSIONS [superset]
Posted by "codeant-ai-for-open-source[bot] (via GitHub)" <gi...@apache.org>.
codeant-ai-for-open-source[bot] commented on PR #37104:
URL: https://github.com/apache/superset/pull/37104#issuecomment-3745120937
CodeAnt AI finished reviewing your PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org