You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Chengwei Yang <ch...@gmail.com> on 2014/04/15 09:21:13 UTC
Review Request 20362: Attribute operator << doesn't support type Value::SET
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20362/
-----------------------------------------------------------
Review request for mesos, Adam B, Ben Mahler, Jie Yu, and Vinod Kone.
Repository: mesos-git
Description
-------
Attribute operator << doesn't support type Value::SET
Since Attribute doesn't support type Value::SET, fail in operator << if
found such type of Attribute like other places.
Diffs
-----
src/common/attributes.cpp 851c92a
Diff: https://reviews.apache.org/r/20362/diff/
Testing
-------
make check passed.
Thanks,
Chengwei Yang
Re: Review Request 20362: Attribute operator << doesn't support type
Value::SET
Posted by Chengwei Yang <ch...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20362/#review40364
-----------------------------------------------------------
I'll upload a new version to fix all the places which use Value::SET type of Attribute.
- Chengwei Yang
On April 15, 2014, 3:21 p.m., Chengwei Yang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20362/
> -----------------------------------------------------------
>
> (Updated April 15, 2014, 3:21 p.m.)
>
>
> Review request for mesos, Adam B, Ben Mahler, Jie Yu, and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Attribute operator << doesn't support type Value::SET
>
> Since Attribute doesn't support type Value::SET, fail in operator << if
> found such type of Attribute like other places.
>
>
> Diffs
> -----
>
> src/common/attributes.cpp 851c92a
>
> Diff: https://reviews.apache.org/r/20362/diff/
>
>
> Testing
> -------
>
> make check passed.
>
>
> Thanks,
>
> Chengwei Yang
>
>
Re: Review Request 20362: Check strictly Attribute doesn't support type
Value::SET
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20362/#review40383
-----------------------------------------------------------
Patch looks great!
Reviews applied: [20362]
All tests passed.
- Mesos ReviewBot
On April 15, 2014, 9:07 a.m., Chengwei Yang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20362/
> -----------------------------------------------------------
>
> (Updated April 15, 2014, 9:07 a.m.)
>
>
> Review request for mesos, Adam B, Ben Mahler, Jie Yu, and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Check strictly Attribute doesn't support type Value::SET
>
> Review: https://reviews.apache.org/r/20362
>
>
> Diffs
> -----
>
> src/common/attributes.hpp e6271cd9fdf2e57acdbd48a9bde0a2e5fdec4d38
> src/common/attributes.cpp 851c92a88804370313bf052c85f99d483fd67416
> src/common/http.cpp e81a7ad299652d7a969353bed883727eb4bfd794
>
> Diff: https://reviews.apache.org/r/20362/diff/
>
>
> Testing
> -------
>
> make check passed.
>
>
> Thanks,
>
> Chengwei Yang
>
>
Re: Review Request 20362: Check strictly Attribute doesn't support type
Value::SET
Posted by Chengwei Yang <ch...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20362/#review40625
-----------------------------------------------------------
Any background for why we doesn't support Value::SET Attribute? There is a jira ticket for (maybe) add that support, MESOS-1215.
- Chengwei Yang
On April 17, 2014, 3:06 a.m., Chengwei Yang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20362/
> -----------------------------------------------------------
>
> (Updated April 17, 2014, 3:06 a.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Check strictly Attribute doesn't support type Value::SET
>
> Review: https://reviews.apache.org/r/20362
>
>
> Diffs
> -----
>
> src/common/attributes.hpp e6271cd9fdf2e57acdbd48a9bde0a2e5fdec4d38
> src/common/attributes.cpp 851c92a88804370313bf052c85f99d483fd67416
> src/common/http.cpp e81a7ad299652d7a969353bed883727eb4bfd794
>
> Diff: https://reviews.apache.org/r/20362/diff/
>
>
> Testing
> -------
>
> make check passed.
>
>
> Thanks,
>
> Chengwei Yang
>
>
Re: Review Request 20362: Check strictly Attribute doesn't support type
Value::SET
Posted by Chengwei Yang <ch...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20362/
-----------------------------------------------------------
(Updated April 16, 2014, 7:06 p.m.)
Review request for mesos and Benjamin Hindman.
Changes
-------
assigning to @benh to shepherd -- vinod.
Repository: mesos-git
Description
-------
Check strictly Attribute doesn't support type Value::SET
Review: https://reviews.apache.org/r/20362
Diffs
-----
src/common/attributes.hpp e6271cd9fdf2e57acdbd48a9bde0a2e5fdec4d38
src/common/attributes.cpp 851c92a88804370313bf052c85f99d483fd67416
src/common/http.cpp e81a7ad299652d7a969353bed883727eb4bfd794
Diff: https://reviews.apache.org/r/20362/diff/
Testing
-------
make check passed.
Thanks,
Chengwei Yang
Re: Review Request 20362: Check strictly Attribute doesn't support type
Value::SET
Posted by Chengwei Yang <ch...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20362/
-----------------------------------------------------------
(Updated April 15, 2014, 5:07 p.m.)
Review request for mesos, Adam B, Ben Mahler, Jie Yu, and Vinod Kone.
Summary (updated)
-----------------
Check strictly Attribute doesn't support type Value::SET
Repository: mesos-git
Description (updated)
-------
Check strictly Attribute doesn't support type Value::SET
Review: https://reviews.apache.org/r/20362
Diffs (updated)
-----
src/common/attributes.hpp e6271cd9fdf2e57acdbd48a9bde0a2e5fdec4d38
src/common/attributes.cpp 851c92a88804370313bf052c85f99d483fd67416
src/common/http.cpp e81a7ad299652d7a969353bed883727eb4bfd794
Diff: https://reviews.apache.org/r/20362/diff/
Testing
-------
make check passed.
Thanks,
Chengwei Yang