You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2018/08/17 09:46:20 UTC

[GitHub] ascrutae removed a comment on issue #1554: Fix #1549, spring-plugins bug

ascrutae removed a comment on issue #1554: Fix  #1549,  spring-plugins bug
URL: https://github.com/apache/incubator-skywalking/pull/1554#issuecomment-413814966
 
 
   I think that this is not the root cause about #1549, I suspect that the problem is caused by that the plugin only stores the `Request` and does not store `Response`。because  of the plugin had check if  `Request` is empty when creating span in `beforeMethod` and the plugin check the `Response` is empty when finish the span in `afterMethod`. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services