[GitHub] [airflow] potiuk commented on a change in pull request #5133: [AIRFLOW-4356] Add numWorkers and additionalUserLabels to DataFlowHook

[GitBox <gi...@apache.org>]

potiuk commented on a change in pull request #5133: [AIRFLOW-4356] Add numWorkers and additionalUserLabels to DataFlowHook
URL: https://github.com/apache/airflow/pull/5133#discussion_r277047446
 
 

 ##########
 File path: airflow/contrib/hooks/gcp_dataflow_hook.py
 ##########
 @@ -272,8 +272,9 @@ def _start_template_dataflow(self, name, variables, parameters,
         # Builds RuntimeEnvironment from variables dictionary
         # https://cloud.google.com/dataflow/docs/reference/rest/v1b3/RuntimeEnvironment
         environment = {}
-        for key in ['maxWorkers', 'zone', 'serviceAccountEmail', 'tempLocation',
-                    'bypassTempDirValidation', 'machineType', 'network', 'subnetwork']:
+        for key in ['numWorkers', 'maxWorkers', 'zone', 'serviceAccountEmail',
 
 Review comment:
   Maybe you could also add the "additionalExperiments" array. Seems to be the last missing out of the keys  defined in https://cloud.google.com/dataflow/docs/reference/rest/v1b3/RuntimeEnvironment . Anything preventing us from doing so ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services