Re: Review Request 28364: Refactored Master::_launchTasks().

[Ben Mahler <be...@gmail.com>]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28364/#review63592
-----------------------------------------------------------

Ship it!


Will get this committed for you!


src/master/master.hpp
<https://reviews.apache.org/r/28364/#comment105868>

    How about a bit more descriptive, since it's not obvious to me what this returns:
    
      // Add the task and its executor (if not already running) to the
      // framework and slave. Returns the resources consumed as a result,
      // which includes resources for the task and its executor
      // (if not already running).



src/master/master.cpp
<https://reviews.apache.org/r/28364/#comment105874>

    For now, we don't need to create this vector to copy in all of the valid tasks, we can just send the RunTaskMessage when we add the task. In isolation, that's what I would expect this patch to do. :)


- Ben Mahler


On Nov. 24, 2014, 7:34 p.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28364/
> -----------------------------------------------------------
> 
> (Updated Nov. 24, 2014, 7:34 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Needed for subsequent review where slave needs to be informed about persistent resources before the tasks reach it.
> 
> 
> Diffs
> -----
> 
>   src/master/master.hpp 6eabb07f0947242c74b2bcc9e2b57b0f727c2917 
>   src/master/master.cpp 5957db6538c1c66a4cc42c14f3908c0c2cc35f39 
> 
> Diff: https://reviews.apache.org/r/28364/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>